Changeset 147737 in webkit


Ignore:
Timestamp:
Apr 5, 2013 4:27:48 AM (11 years ago)
Author:
jocelyn.turcotte@digia.com
Message:

[Qt] PluginsX11: exposedRect offset is applied twice when painting windowless
https://bugs.webkit.org/show_bug.cgi?id=114020

Reviewed by Simon Hausmann.

Both XGetImage and QPainter::drawImage would apply the offset.
Since the XImage will only contain the exposed rect, no need to specify
the source rect to drawImage.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingXPixmap):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147732 r147737  
     12013-04-05  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
     2
     3        [Qt] PluginsX11: exposedRect offset is applied twice when painting windowless
     4        https://bugs.webkit.org/show_bug.cgi?id=114020
     5
     6        Reviewed by Simon Hausmann.
     7
     8        Both XGetImage and QPainter::drawImage would apply the offset.
     9        Since the XImage will only contain the exposed rect, no need to specify
     10        the source rect to drawImage.
     11
     12        * plugins/qt/PluginViewQt.cpp:
     13        (WebCore::PluginView::paintUsingXPixmap):
     14
    1152013-04-05  Seokju Kwon  <seokju.kwon@gmail.com>
    216
  • trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp

    r145913 r147737  
    230230    XImage* xImage = XGetImage(x11Display(), m_drawable, exposedRect.x(), exposedRect.y(),
    231231                               exposedRect.width(), exposedRect.height(), ULONG_MAX, ZPixmap);
    232     painter->drawImage(QPoint(exposedRect.x(), exposedRect.y()), qimageFromXImage(xImage), exposedRect);
     232    painter->drawImage(QPoint(exposedRect.x(), exposedRect.y()), qimageFromXImage(xImage));
    233233    XDestroyImage(xImage);
    234234}
Note: See TracChangeset for help on using the changeset viewer.