Changeset 147801 in webkit

Timestamp:

Apr 5, 2013 2:54:22 PM (11 years ago)

Author:

Chris Fleizach

Message:

WebSpeech: event.elapsedTime is always 1364484608
​https://bugs.webkit.org/show_bug.cgi?id=114045

Reviewed by Tim Horton.

Source/WebCore:

We were calculating elapsed time incorrectly.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html

• Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::fireEvent):

LayoutTests:

• platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
• platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt (added)
• LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/speech/SpeechSynthesis.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-05  Chris Fleizach  <cfleizach@apple.com>
+
+        WebSpeech: event.elapsedTime is always 1364484608
+        https://bugs.webkit.org/show_bug.cgi?id=114045
+
+        Reviewed by Tim Horton.
+
+        * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
+        * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
+
 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-05  Chris Fleizach  <cfleizach@apple.com>
+
+        WebSpeech: event.elapsedTime is always 1364484608
+        https://bugs.webkit.org/show_bug.cgi?id=114045
+
+        Reviewed by Tim Horton.
+
+        We were calculating elapsed time incorrectly.
+
+        Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
+
+        * Modules/speech/SpeechSynthesis.cpp:
+        (WebCore::SpeechSynthesis::fireEvent):
+
 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/Modules/speech/SpeechSynthesis.cpp

@@ -141 +141 @@
 void SpeechSynthesis::fireEvent(const AtomicString& type, SpeechSynthesisUtterance* utterance, unsigned long charIndex, const String& name)
 {
-    utterance->dispatchEvent(SpeechSynthesisEvent::create(type, charIndex, (currentTime() - utterance->startTime()), name));
+    utterance->dispatchEvent(SpeechSynthesisEvent::create(type, charIndex, (monotonicallyIncreasingTime() - utterance->startTime()), name));
 }