Changeset 147883 in webkit

Timestamp:

Apr 7, 2013 3:18:48 PM (11 years ago)

Author:

Patrick Gansterer

Message:

Add default implementation for KURL::fileSystemPath()
​https://bugs.webkit.org/show_bug.cgi?id=108326

Reviewed by Benjamin Poulain.

The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.

• PlatformBlackBerry.cmake:
• PlatformEfl.cmake:
• PlatformWinCE.cmake:
• platform/KURL.cpp:

(WebCore):
(WebCore::KURL::fileSystemPath):

• platform/blackberry/KURLBlackBerry.cpp: Removed.
• platform/efl/KURLEfl.cpp: Removed.
• platform/wince/KURLWinCE.cpp: Removed.
• platform/wx/KURLWx.cpp: Removed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• PlatformBlackBerry.cmake (modified) (1 diff)
• PlatformEfl.cmake (modified) (1 diff)
• PlatformWinCE.cmake (modified) (1 diff)
• platform/KURL.cpp (modified) (1 diff)
• platform/blackberry/KURLBlackBerry.cpp (deleted)
• platform/efl/KURLEfl.cpp (deleted)
• platform/wince/KURLWinCE.cpp (deleted)
• platform/wx/KURLWx.cpp (deleted)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-07  Patrick Gansterer  <paroga@webkit.org>
+
+        Add default implementation for KURL::fileSystemPath()
+        https://bugs.webkit.org/show_bug.cgi?id=108326
+
+        Reviewed by Benjamin Poulain.
+
+        The code for KURL::fileSystemPath() has been duplicated in different ports.
+        Add an implementation of this function to KURL.cpp for this ports and
+        get rid of the very similar port specific implementation files.
+
+        * PlatformBlackBerry.cmake:
+        * PlatformEfl.cmake:
+        * PlatformWinCE.cmake:
+        * platform/KURL.cpp:
+        (WebCore):
+        (WebCore::KURL::fileSystemPath):
+        * platform/blackberry/KURLBlackBerry.cpp: Removed.
+        * platform/efl/KURLEfl.cpp: Removed.
+        * platform/wince/KURLWinCE.cpp: Removed.
+        * platform/wx/KURLWx.cpp: Removed.
+
 2013-04-07  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebCore/PlatformBlackBerry.cmake

@@ -110 +110 @@
     platform/blackberry/DragImageBlackBerry.cpp
     platform/blackberry/EventLoopBlackBerry.cpp
-    platform/blackberry/KURLBlackBerry.cpp
     platform/blackberry/LocalizedStringsBlackBerry.cpp
     platform/blackberry/LoggingBlackBerry.cpp

trunk/Source/WebCore/PlatformEfl.cmake

@@ -66 +66 @@
     platform/efl/FileSystemEfl.cpp
     platform/efl/GamepadsEfl.cpp
-    platform/efl/KURLEfl.cpp
     platform/efl/LanguageEfl.cpp
     platform/efl/LocalizedStringsEfl.cpp

trunk/Source/WebCore/PlatformWinCE.cmake

@@ -65 +65 @@
 
     platform/wince/FileSystemWince.cpp
-    platform/wince/KURLWince.cpp
 
     platform/network/NetworkStorageSessionStub.cpp

trunk/Source/WebCore/platform/KURL.cpp

@@ -632 +632 @@
 }
 
+#if !PLATFORM(GTK) && !PLATFORM(QT) && !USE(CF)
+String KURL::fileSystemPath() const
+{
+    if (!isValid() || !isLocalFile())
+        return String();
+
+    return decodeURLEscapeSequences(path());
+}
+#endif
+
 #ifdef NDEBUG