Changeset 147884 in webkit

Timestamp:

Apr 7, 2013 4:00:28 PM (11 years ago)

Author:

Patrick Gansterer

Message:

[WIN] Fix problems with export macros of AutodrainedPool
​https://bugs.webkit.org/show_bug.cgi?id=114132

Reviewed by Geoffrey Garen.

Exporting an inline function results in an error with the MS compiler.

• wtf/AutodrainedPool.h:

(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/AutodrainedPool.h (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-04-07  Patrick Gansterer  <paroga@webkit.org>
+
+        [WIN] Fix problems with export macros of AutodrainedPool
+        https://bugs.webkit.org/show_bug.cgi?id=114132
+
+        Reviewed by Geoffrey Garen.
+
+        Exporting an inline function results in an error with the MS compiler.
+
+        * wtf/AutodrainedPool.h:
+        (AutodrainedPool):
+        (WTF::AutodrainedPool::AutodrainedPool):
+        (WTF::AutodrainedPool::~AutodrainedPool):
+        (WTF::AutodrainedPool::cycle):
+
 2013-04-07  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WTF/wtf/AutodrainedPool.h

@@ -39 +39 @@
     WTF_MAKE_NONCOPYABLE(AutodrainedPool);
 public:
+#if PLATFORM(MAC)
     WTF_EXPORT_PRIVATE explicit AutodrainedPool(int iterationLimit = 1);
     WTF_EXPORT_PRIVATE ~AutodrainedPool();
-    
+
     WTF_EXPORT_PRIVATE void cycle();
+#else
+    explicit AutodrainedPool(int = 1) { }
+    ~AutodrainedPool() { }
+    void cycle() { }
+#endif
     
 private:
@@ -52 +58 @@
 };
 
-#if !PLATFORM(MAC)
-inline AutodrainedPool::AutodrainedPool(int) { }
-inline AutodrainedPool::~AutodrainedPool() { }
-inline void AutodrainedPool::cycle() { }
-#endif
-
 } // namespace WTF
 
@@ -63 +63 @@
 
 #endif
-
-