Changeset 147914 in webkit


Ignore:
Timestamp:
Apr 8, 2013 8:26:39 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK][EFL] HEAD requests changed to GET after 303 redirection
https://bugs.webkit.org/show_bug.cgi?id=110127

Patch by Youenn Fablet <youennf@gmail.com> on 2013-04-08
Reviewed by Martin Robinson.

Source/WebCore:

Made shouldRedirectAsGET always return false for HEAD requests.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::shouldRedirectAsGET):

LayoutTests:

Added tests checking HEAD redirection.
Redirected HEAD requests are expected to remain HEAD requests.
(http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)

  • http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
  • http/tests/xmlhttprequest/head-redirection.html: Added.
  • http/tests/xmlhttprequest/resources/get_method.php: Added.
  • http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
  • platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r147907 r147914  
     12013-04-08  Youenn Fablet  <youennf@gmail.com>
     2
     3        [GTK][EFL] HEAD requests changed to GET after 303 redirection
     4        https://bugs.webkit.org/show_bug.cgi?id=110127
     5
     6        Reviewed by Martin Robinson.
     7
     8        Added tests checking HEAD redirection.
     9        Redirected HEAD requests are expected to remain HEAD requests.
     10        (http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)
     11
     12        * http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
     13        * http/tests/xmlhttprequest/head-redirection.html: Added.
     14        * http/tests/xmlhttprequest/resources/get_method.php: Added.
     15        * http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
     16        * platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
     17
    1182013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
    219
  • trunk/Source/WebCore/ChangeLog

    r147912 r147914  
     12013-04-08  Youenn Fablet  <youennf@gmail.com>
     2
     3        [GTK][EFL] HEAD requests changed to GET after 303 redirection
     4        https://bugs.webkit.org/show_bug.cgi?id=110127
     5
     6        Reviewed by Martin Robinson.
     7
     8        Made shouldRedirectAsGET always return false for HEAD requests.
     9
     10        * platform/network/soup/ResourceHandleSoup.cpp:
     11        (WebCore::shouldRedirectAsGET):
     12
    1132013-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
    214
  • trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

    r147642 r147914  
    420420static bool shouldRedirectAsGET(SoupMessage* message, KURL& newURL, bool crossOrigin)
    421421{
    422     if (message->method == SOUP_METHOD_GET)
     422    if (message->method == SOUP_METHOD_GET || message->method == SOUP_METHOD_HEAD)
    423423        return false;
    424424
Note: See TracChangeset for help on using the changeset viewer.