Changeset 147936 in webkit


Ignore:
Timestamp:
Apr 8, 2013 10:54:03 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Force horizontal list to be horizontal scrollable.
https://bugs.webkit.org/show_bug.cgi?id=114173

Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.

Force content to be horizontal/vertical overscrollable if it
scrolls in horizontal/vertical way.

PR 237440
Internally Reviewed by Arvid Nilsson.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

Location:
trunk/Source/WebKit/blackberry
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/blackberry/ChangeLog

    r147905 r147936  
     12013-04-08  Iris Wu  <shuwu@blackberry.com>
     2
     3        [BlackBerry] Force horizontal list to be horizontal scrollable.
     4        https://bugs.webkit.org/show_bug.cgi?id=114173
     5
     6        Reviewed by Rob Buis.
     7
     8        Force content to be horizontal/vertical overscrollable if it
     9        scrolls in horizontal/vertical way.
     10
     11        PR 237440
     12        Internally Reviewed by Arvid Nilsson.
     13
     14        * WebKitSupport/InRegionScrollableArea.cpp:
     15        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
     16
    1172013-04-08  Alberto Garcia  <agarcia@igalia.com>
    218
  • trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp

    r147744 r147936  
    128128        // Both caches below are self-exclusive.
    129129        if (m_layer->usesCompositedScrolling()) {
    130             m_forceContentToBeVerticallyScrollable = true;
     130            m_forceContentToBeHorizontallyScrollable = m_scrollsHorizontally;
     131            m_forceContentToBeVerticallyScrollable = m_scrollsVertically;
     132            // Force content to be scrollable even if it doesn't need to scroll in either direction.
     133            if (!m_scrollsHorizontally && !m_scrollsVertically)
     134                if (box->scrollsOverflowY())
     135                    m_forceContentToBeVerticallyScrollable = true;
     136                else if (box->scrollsOverflowX()) // If it's already forced scrollable vertically, don't force it to scroll horizontally
     137                    m_forceContentToBeHorizontallyScrollable = true;
    131138            m_supportsCompositedScrolling = true;
    132139            ASSERT(m_layer->backing()->hasScrollingLayer());
Note: See TracChangeset for help on using the changeset viewer.