Changeset 147993 in webkit

Timestamp:

Apr 9, 2013 12:30:09 AM (11 years ago)

Author:

g.czajkowski@samsung.com

Message:

[WK2][EFL] Mark not implemented methods in TextCheckerEfl.
​https://bugs.webkit.org/show_bug.cgi?id=112261

Reviewed by Anders Carlsson.

There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.

• UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/efl/TextCheckerEfl.cpp (modified) (5 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-04-08  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
+
+        [WK2][EFL] Mark not implemented methods in TextCheckerEfl.
+        https://bugs.webkit.org/show_bug.cgi?id=112261
+
+        Reviewed by Anders Carlsson.
+
+        There's no need to call client's methods in TextCheckerEfl.cpp if they are not
+        implemented. Mark them as not implemented until we provide proper implementation.
+
+        * UIProcess/efl/TextCheckerEfl.cpp:
+        (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
+        (WebKit::TextChecker::setGrammarCheckingEnabled):
+        (WebKit::TextChecker::grammarCheckingEnabledStateChanged):
+        (WebKit::TextChecker::checkGrammarOfString):
+        (WebKit::TextChecker::spellingUIIsShowing):
+        (WebKit::TextChecker::toggleSpellingUIIsShowing):
+        (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
+        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
+
 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp

@@ -29 +29 @@
 #include "TextChecker.h"
 
+#include "NotImplemented.h"
 #include "TextCheckerState.h"
 
@@ -60 +61 @@
 bool TextChecker::isContinuousSpellCheckingAllowed()
 {
-#if ENABLE(SPELLCHECK)
-    return WebTextChecker::shared()->client().continuousSpellCheckingAllowed();
-#else
+    notImplemented();
     return false;
-#endif
 }
 
@@ -80 +78 @@
 }
 
-void TextChecker::setGrammarCheckingEnabled(bool isGrammarCheckingEnabled)
-{
-#if ENABLE(SPELLCHECK)
-    if (state().isGrammarCheckingEnabled == isGrammarCheckingEnabled)
-        return;
-
-    textCheckerState.isGrammarCheckingEnabled = isGrammarCheckingEnabled;
-    WebTextChecker::shared()->client().setGrammarCheckingEnabled(isGrammarCheckingEnabled);
-#else
-    UNUSED_PARAM(isGrammarCheckingEnabled);
-#endif
+void TextChecker::setGrammarCheckingEnabled(bool)
+{
+    notImplemented();
 }
 
@@ -98 +88 @@
 }
 
-void TextChecker::grammarCheckingEnabledStateChanged(bool enabled)
-{
-#if ENABLE(SPELLCHECK)
-    textCheckerState.isGrammarCheckingEnabled = enabled;
-#else
-    UNUSED_PARAM(enabled);
-#endif
+void TextChecker::grammarCheckingEnabledStateChanged(bool)
+{
+    notImplemented();
 }
 
@@ -211 +197 @@
 }
 
-void TextChecker::checkGrammarOfString(int64_t spellDocumentTag, const UChar* text, uint32_t length, Vector<GrammarDetail>& grammarDetails, int32_t& badGrammarLocation, int32_t& badGrammarLength)
-{
-#if ENABLE(SPELLCHECK)
-    WebTextChecker::shared()->client().checkGrammarOfString(spellDocumentTag, String(text, length), grammarDetails, badGrammarLocation, badGrammarLength);
-#else
-    UNUSED_PARAM(spellDocumentTag);
-    UNUSED_PARAM(text);
-    UNUSED_PARAM(length);
-    UNUSED_PARAM(grammarDetails);
-    UNUSED_PARAM(badGrammarLocation);
-    UNUSED_PARAM(badGrammarLength);
-#endif
+void TextChecker::checkGrammarOfString(int64_t, const UChar*, uint32_t, Vector<GrammarDetail>&, int32_t&, int32_t&)
+{
+    notImplemented();
 }
 
 bool TextChecker::spellingUIIsShowing()
 {
-#if ENABLE(SPELLCHECK)
-    return WebTextChecker::shared()->client().spellingUIIsShowing();
-#else
+    notImplemented();
     return false;
-#endif
 }
 
 void TextChecker::toggleSpellingUIIsShowing()
 {
-#if ENABLE(SPELLCHECK)
-    WebTextChecker::shared()->client().toggleSpellingUIIsShowing();
-#endif
-}
-
-void TextChecker::updateSpellingUIWithMisspelledWord(int64_t spellDocumentTag, const String& misspelledWord)
-{
-#if ENABLE(SPELLCHECK)
-    WebTextChecker::shared()->client().updateSpellingUIWithMisspelledWord(spellDocumentTag, misspelledWord);
-#else
-    UNUSED_PARAM(spellDocumentTag);
-    UNUSED_PARAM(misspelledWord);
-#endif
-}
-
-void TextChecker::updateSpellingUIWithGrammarString(int64_t spellDocumentTag, const String& badGrammarPhrase, const GrammarDetail& grammarDetail)
-{
-#if ENABLE(SPELLCHECK)
-    WebTextChecker::shared()->client().updateSpellingUIWithGrammarString(spellDocumentTag, badGrammarPhrase, grammarDetail);
-#else
-    UNUSED_PARAM(spellDocumentTag);
-    UNUSED_PARAM(badGrammarPhrase);
-    UNUSED_PARAM(grammarDetail);
-#endif
+    notImplemented();
+}
+
+void TextChecker::updateSpellingUIWithMisspelledWord(int64_t, const String&)
+{
+    notImplemented();
+}
+
+void TextChecker::updateSpellingUIWithGrammarString(int64_t, const String&, const GrammarDetail&)
+{
+    notImplemented();
 }