Changeset 148022 in webkit


Ignore:
Timestamp:
Apr 9, 2013 7:31:35 AM (11 years ago)
Author:
rafael.lobo@openbossa.org
Message:

[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
​https://bugs.webkit.org/show_bug.cgi?id=112582

Reviewed by Andreas Kling.

Source/WebKit/qt:

We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.

  • WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.

Source/WebKit2:

We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.

LayoutTests:

Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.

  • fast/animation/request-animation-frame-time-unit-expected.txt: Added.
  • fast/animation/request-animation-frame-time-unit.html: Added.
  • fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
Location:
trunk
Files:
3 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r148019 r148022  
     12013-04-09  Rafael Brandao  <rafael.lobo@openbossa.org>
     2
     3        [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
     4        https://bugs.webkit.org/show_bug.cgi?id=112582
     5
     6        Reviewed by Andreas Kling.
     7
     8        Add test to measure if the time interval is coherent with the unit
     9        of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
     10
     11        * fast/animation/request-animation-frame-time-unit-expected.txt: Added.
     12        * fast/animation/request-animation-frame-time-unit.html: Added.
     13        * fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
     14
    1152013-04-09  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
    216

  • trunk/Source/WebKit/qt/ChangeLog

    r147979 r148022  
     12013-04-09  Rafael Brandao  <rafael.lobo@openbossa.org>
     2
     3        [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
     4        https://bugs.webkit.org/show_bug.cgi?id=112582
     5
     6        Reviewed by Andreas Kling.
     7
     8        We've been exposing different time unit for requestAnimationFrame because
     9        of wrong conversion before serviceScriptedAnimations function calls.
     10        Fixed it to use seconds instead of milliseconds.
     11
     12        * WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
     13
    1142013-04-08  Benjamin Poulain  <benjamin@webkit.org>
    215

  • trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

    r141265 r148022  
    626626void ChromeClientQt::serviceScriptedAnimations()
    627627{
    628     m_webPage->mainFrameAdapter()->frame->view()->serviceScriptedAnimations(convertSecondsToDOMTimeStamp(currentTime()));
     628    m_webPage->mainFrameAdapter()->frame->view()->serviceScriptedAnimations(currentTime());
    629629}
    630630#endif

  • trunk/Source/WebKit2/ChangeLog

    r148021 r148022  
     12013-04-09  Rafael Brandao  <rafael.lobo@openbossa.org>
     2
     3        [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
     4        https://bugs.webkit.org/show_bug.cgi?id=112582
     5
     6        Reviewed by Andreas Kling.
     7
     8        We've been exposing different time unit for requestAnimationFrame because
     9        of wrong conversion before serviceScriptedAnimations function calls.
     10        Fixed it to use seconds instead of milliseconds.
     11
     12        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
     13        (WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
     14
    1152013-04-09  Michael Brüning  <michael.bruning@digia.com>
    216

  • trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp

    r148000 r148022  
    507507#if ENABLE(REQUEST_ANIMATION_FRAME) && !USE(REQUEST_ANIMATION_FRAME_TIMER) && !USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
    508508    // Make sure that any previously registered animation callbacks are being executed before we flush the layers.
    509     m_webPage->corePage()->mainFrame()->view()->serviceScriptedAnimations(convertSecondsToDOMTimeStamp(currentTime()));
     509    m_webPage->corePage()->mainFrame()->view()->serviceScriptedAnimations(currentTime());
    510510#endif
    511511
Note: See TracChangeset for help on using the changeset viewer.