Changeset 148048 in webkit

Timestamp:

Apr 9, 2013 1:52:39 PM (11 years ago)

Author:

Simon Fraser

Message:

window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
​https://bugs.webkit.org/show_bug.cgi?id=114219

Reviewed by Beth Dakin.

Force layout when setTracksRepaints() is set to true, to flush out any pending
repaints from a layout that hasn't happened yet. Also force layout in
trackedRepaintRectsAsText(), so that any pending layout happpens and thus
repaints.

• page/FrameView.cpp:

(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-08  Simon Fraser  <simon.fraser@apple.com>
+
+        window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
+        https://bugs.webkit.org/show_bug.cgi?id=114219
+
+        Reviewed by Beth Dakin.
+
+        Force layout when setTracksRepaints() is set to true, to flush out any pending
+        repaints from a layout that hasn't happened yet. Also force layout in
+        trackedRepaintRectsAsText(), so that any pending layout happpens and thus
+        repaints.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setTracksRepaints):
+        (WebCore::FrameView::trackedRepaintRectsAsText):
+
 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -3921 +3921 @@
         return;
 
+    // Force layout to flush out any pending repaints.
+    if (trackRepaints) {
+        if (frame() && frame()->document())
+            frame()->document()->updateLayout();
+    }
+
 #if USE(ACCELERATED_COMPOSITING)
     for (Frame* frame = m_frame->tree()->top(); frame; frame = frame->tree()->traverseNext()) {
@@ -3943 +3949 @@
 String FrameView::trackedRepaintRectsAsText() const
 {
+    if (frame() && frame()->document())
+        frame()->document()->updateLayout();
+
     TextStream ts;
     if (!m_trackedRepaintRects.isEmpty()) {