Changeset 148055 in webkit


Ignore:
Timestamp:
Apr 9, 2013 3:02:17 PM (11 years ago)
Author:
rniwa@webkit.org
Message:

newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309

Reviewed by Benjamin Poulain.

Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r148051 r148055  
     12013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        newcommitbot (WKR) requires a subversion checkout
     4        https://bugs.webkit.org/show_bug.cgi?id=114309
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        Directly talk to the subversion server instead of relying on a local checkout.
     9        This allows us to run WKR off of a git clone.
     10
     11        * Scripts/webkitpy/tool/commands/newcommitbot.py:
     12        (NewCommitBot.next_work_item):
     13        (NewCommitBot.process_work_item):
     14
    1152013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
    216
  • trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py

    r147984 r148055  
    7676        _log.info('Last SVN revision: %d' % self._last_svn_revision)
    7777
    78         if self._tool.scm().executable_name != 'svn':
    79             _log.error('This bot only works inside a SVN checkout')
    80 
    8178        for revision in range(self._last_svn_revision + 1, self._last_svn_revision + self._maximum_number_of_revisions_to_avoid_spamming_irc):
    8279            try:
    83                 commit_log = self._tool.scm().svn_commit_log(revision)
     80                commit_log = self._tool.executive.run_command(['svn', 'log', 'https://svn.webkit.org/repository/webkit/trunk', '--non-interactive', '--revision',
     81                    self._tool.scm().strip_r_from_svn_revision(revision)])
    8482            except ScriptError:
    8583                break
    86             if self._is_empty_log(commit_log):
     84            if self._is_empty_log(commit_log) or commit_log.find('No such revision') >= 0:
    8785                continue
    8886            _log.info('Found revision %d' % revision)
     
    9593    def process_work_item(self, failure_map):
    9694        return True
    97 
    98     def _update_checkout(self):
    99         tool = self._tool
    100         tool.executive.run_and_throw_if_fail(tool.deprecated_port().update_webkit_command(), quiet=True, cwd=tool.scm().checkout_root)
    10195
    10296    _patch_by_regex = re.compile(r'^Patch\s+by\s+(?P<author>.+?)\s+on(\s+\d{4}-\d{2}-\d{2})?\n?', re.MULTILINE | re.IGNORECASE)
Note: See TracChangeset for help on using the changeset viewer.