Changeset 148055 in webkit
- Timestamp:
- Apr 9, 2013 3:02:17 PM (11 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r148051 r148055 1 2013-04-09 Ryosuke Niwa <rniwa@webkit.org> 2 3 newcommitbot (WKR) requires a subversion checkout 4 https://bugs.webkit.org/show_bug.cgi?id=114309 5 6 Reviewed by Benjamin Poulain. 7 8 Directly talk to the subversion server instead of relying on a local checkout. 9 This allows us to run WKR off of a git clone. 10 11 * Scripts/webkitpy/tool/commands/newcommitbot.py: 12 (NewCommitBot.next_work_item): 13 (NewCommitBot.process_work_item): 14 1 15 2013-04-09 Ryosuke Niwa <rniwa@webkit.org> 2 16 -
trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py
r147984 r148055 76 76 _log.info('Last SVN revision: %d' % self._last_svn_revision) 77 77 78 if self._tool.scm().executable_name != 'svn':79 _log.error('This bot only works inside a SVN checkout')80 81 78 for revision in range(self._last_svn_revision + 1, self._last_svn_revision + self._maximum_number_of_revisions_to_avoid_spamming_irc): 82 79 try: 83 commit_log = self._tool.scm().svn_commit_log(revision) 80 commit_log = self._tool.executive.run_command(['svn', 'log', 'https://svn.webkit.org/repository/webkit/trunk', '--non-interactive', '--revision', 81 self._tool.scm().strip_r_from_svn_revision(revision)]) 84 82 except ScriptError: 85 83 break 86 if self._is_empty_log(commit_log) :84 if self._is_empty_log(commit_log) or commit_log.find('No such revision') >= 0: 87 85 continue 88 86 _log.info('Found revision %d' % revision) … … 95 93 def process_work_item(self, failure_map): 96 94 return True 97 98 def _update_checkout(self):99 tool = self._tool100 tool.executive.run_and_throw_if_fail(tool.deprecated_port().update_webkit_command(), quiet=True, cwd=tool.scm().checkout_root)101 95 102 96 _patch_by_regex = re.compile(r'^Patch\s+by\s+(?P<author>.+?)\s+on(\s+\d{4}-\d{2}-\d{2})?\n?', re.MULTILINE | re.IGNORECASE)
Note: See TracChangeset
for help on using the changeset viewer.