Changeset 148096 in webkit

Timestamp:

Apr 10, 2013 8:44:29 AM (11 years ago)

Author:

ggaren@apple.com

Message:

Removed an annoying message from svn-create-patch
​https://bugs.webkit.org/show_bug.cgi?id=114332

Reviewed by Alexey Proskuryakov.

I see this message basically every time I write a patch, so it must not
be true.

• Scripts/svn-create-patch:

(generateDiff):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/svn-create-patch (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-04-09  Geoffrey Garen  <ggaren@apple.com>
+
+        Removed an annoying message from svn-create-patch
+        https://bugs.webkit.org/show_bug.cgi?id=114332
+
+        Reviewed by Alexey Proskuryakov.
+
+        I see this message basically every time I write a patch, so it must not
+        be true.
+
+        * Scripts/svn-create-patch:
+        (generateDiff):
+
 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
 

trunk/Tools/Scripts/svn-create-patch

@@ -102 +102 @@
 my $prefix = chdirReturningRelativePath($svnRoot);
 
-my $patchSize = 0;
-
-# Generate the diffs, in a order chosen for easy reviewing.
+# Generate the diffs, in an order chosen for ease of reviewing.
 for my $path (sort patchpathcmp values %diffFiles) {
-    $patchSize += generateDiff($path, $prefix);
-}
-
-if ($patchSize > 20480) {
-    print STDERR "WARNING: Patch's size is " . int($patchSize/1024) . " kbytes.\n";
-    print STDERR "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.\n";
+    generateDiff($path, $prefix);
 }
 
@@ -246 +239 @@
         outputBinaryContent($file);
     }
-    return length($patch);
 }