Changeset 148099 in webkit

Timestamp:

Apr 10, 2013, 9:25:14 AM (12 years ago)

Author:

eric.carlson@apple.com

Message:

Update all float attributes in HTMLMediaElement to double
​https://bugs.webkit.org/show_bug.cgi?id=113615

Reviewed by Geoffrey Garen
Patch by Aaron Colwell

No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.

• WebCore.exp.in: Remove function that no longer need to be exported.

• html/HTMLMediaElement.cpp: Change all float attributes to double.
• html/HTMLMediaElement.h: Ditto.
• html/HTMLMediaElement.idl: Ditto.
• html/MediaController.cpp: Ditto.
• html/MediaController.h: Ditto.
• html/MediaControllerInterface.h: Ditto.
• html/TimeRanges.cpp: Ditto.
• html/TimeRanges.idl: Ditto.
• html/shadow/MediaControlElementTypes.cpp: Ditto.
• html/shadow/MediaControlElementTypes.h: Ditto.
• html/shadow/MediaControlElements.cpp: Ditto.
• html/shadow/MediaControlElements.h: Ditto.
• html/shadow/MediaControls.cpp: Ditto.
• html/shadow/MediaControlsApple.cpp: Ditto.
• html/shadow/MediaControlsBlackBerry.cpp: Ditto.
• html/shadow/MediaControlsBlackBerry.h: Ditto.
• html/shadow/MediaControlsGtk.cpp: Ditto.
• html/track/TextTrackCue.cpp: Ditto.
• html/track/TextTrackCue.h: Ditto.
• platform/Clock.h: Ditto.
• platform/ClockGeneric.cpp: Ditto.
• platform/ClockGeneric.h: Ditto.
• platform/graphics/MediaPlayer.cpp: Ditto.
• platform/graphics/MediaPlayer.h: Ditto.
• platform/graphics/MediaPlayerPrivate.h: Ditto.
• platform/mac/PlatformClockCA.cpp: Ditto.
• platform/mac/PlatformClockCA.h: Ditto.
• platform/mac/PlatformClockCM.h: Ditto.
• platform/mac/PlatformClockCM.mm: Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.exp.in (modified) (2 diffs)
• html/HTMLMediaElement.cpp (modified) (34 diffs)
• html/HTMLMediaElement.h (modified) (12 diffs)
• html/HTMLMediaElement.idl (modified) (2 diffs)
• html/MediaController.cpp (modified) (7 diffs)
• html/MediaController.h (modified) (3 diffs)
• html/MediaControllerInterface.h (modified) (2 diffs)
• html/TimeRanges.cpp (modified) (8 diffs)
• html/TimeRanges.h (modified) (3 diffs)
• html/TimeRanges.idl (modified) (1 diff)
• html/shadow/MediaControlElementTypes.cpp (modified) (7 diffs)
• html/shadow/MediaControlElementTypes.h (modified) (4 diffs)
• html/shadow/MediaControlElements.cpp (modified) (4 diffs)
• html/shadow/MediaControlElements.h (modified) (1 diff)
• html/shadow/MediaControls.cpp (modified) (2 diffs)
• html/shadow/MediaControlsApple.cpp (modified) (2 diffs)
• html/shadow/MediaControlsBlackBerry.cpp (modified) (10 diffs)
• html/shadow/MediaControlsBlackBerry.h (modified) (1 diff)
• html/shadow/MediaControlsGtk.cpp (modified) (2 diffs)
• html/track/TextTrackCue.cpp (modified) (1 diff)
• html/track/TextTrackCue.h (modified) (1 diff)
• platform/Clock.h (modified) (1 diff)
• platform/ClockGeneric.cpp (modified) (4 diffs)
• platform/ClockGeneric.h (modified) (2 diffs)
• platform/graphics/MediaPlayer.cpp (modified) (9 diffs)
• platform/graphics/MediaPlayer.h (modified) (5 diffs)
• platform/graphics/MediaPlayerPrivate.h (modified) (3 diffs)
• platform/mac/PlatformClockCA.cpp (modified) (4 diffs)
• platform/mac/PlatformClockCA.h (modified) (1 diff)
• platform/mac/PlatformClockCM.h (modified) (2 diffs)
• platform/mac/PlatformClockCM.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-10  Eric Carlson  <eric.carlson@apple.com>
+
+        Update all float attributes in HTMLMediaElement to double
+        https://bugs.webkit.org/show_bug.cgi?id=113615
+
+        Reviewed by Geoffrey Garen
+        Patch by Aaron Colwell
+
+        No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
+        All existing LayoutTests/media tests still pass.
+
+        * WebCore.exp.in: Remove function that no longer need to be exported.
+
+        * html/HTMLMediaElement.cpp: Change all float attributes to double.
+        * html/HTMLMediaElement.h: Ditto.
+        * html/HTMLMediaElement.idl: Ditto.
+        * html/MediaController.cpp: Ditto.
+        * html/MediaController.h: Ditto.
+        * html/MediaControllerInterface.h: Ditto.
+        * html/TimeRanges.cpp: Ditto.
+        * html/TimeRanges.idl: Ditto.
+        * html/shadow/MediaControlElementTypes.cpp: Ditto.
+        * html/shadow/MediaControlElementTypes.h: Ditto.
+        * html/shadow/MediaControlElements.cpp: Ditto.
+        * html/shadow/MediaControlElements.h: Ditto.
+        * html/shadow/MediaControls.cpp: Ditto.
+        * html/shadow/MediaControlsApple.cpp: Ditto.
+        * html/shadow/MediaControlsBlackBerry.cpp: Ditto.
+        * html/shadow/MediaControlsBlackBerry.h: Ditto.
+        * html/shadow/MediaControlsGtk.cpp: Ditto.
+        * html/track/TextTrackCue.cpp: Ditto.
+        * html/track/TextTrackCue.h: Ditto.
+        * platform/Clock.h: Ditto.
+        * platform/ClockGeneric.cpp: Ditto.
+        * platform/ClockGeneric.h: Ditto.
+        * platform/graphics/MediaPlayer.cpp: Ditto.
+        * platform/graphics/MediaPlayer.h: Ditto.
+        * platform/graphics/MediaPlayerPrivate.h: Ditto.
+        * platform/mac/PlatformClockCA.cpp: Ditto.
+        * platform/mac/PlatformClockCA.h: Ditto.
+        * platform/mac/PlatformClockCM.h: Ditto.
+        * platform/mac/PlatformClockCM.mm: Ditto.
+
 2013-04-10  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -2668 +2668 @@
 __ZN7WebCore16HTMLMediaElement14beginScrubbingEv
 __ZN7WebCore16HTMLMediaElement14exitFullscreenEv
-__ZN7WebCore16HTMLMediaElement14setCurrentTimeEfRi
 __ZN7WebCore16HTMLMediaElement15clearMediaCacheEv
 __ZN7WebCore16HTMLMediaElement20getSitesInMediaCacheERN3WTF6VectorINS1_6StringELm0ENS1_15CrashOnOverflowEEE
@@ -2674 +2673 @@
 __ZN7WebCore16HTMLMediaElement4playEv
 __ZN7WebCore16HTMLMediaElement5pauseEv
-__ZN7WebCore16HTMLMediaElement6rewindEf
 __ZN7WebCore16HTMLMediaElement8setMutedEb
-__ZN7WebCore16HTMLMediaElement9setVolumeEfRi
 __ZNK7WebCore16HTMLMediaElement11currentTimeEv
 __ZNK7WebCore16HTMLMediaElement13platformMediaEv

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -253 +253 @@
     , m_previousProgressTime(numeric_limits<double>::max())
     , m_lastTimeUpdateEventWallTime(0)
-    , m_lastTimeUpdateEventMovieTime(numeric_limits<float>::max())
+    , m_lastTimeUpdateEventMovieTime(numeric_limits<double>::max())
     , m_loadState(WaitingForSource)
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
@@ -1080 +1080 @@
 
 
-void HTMLMediaElement::updateActiveTextTrackCues(float movieTime)
+void HTMLMediaElement::updateActiveTextTrackCues(double movieTime)
 {
     // 4.8.10.8 Playing the media resource
@@ -1115 +1115 @@
     // algorithm was last run for this media element, if this is not the first
     // time it has run.
-    float lastTime = m_lastTextTrackUpdateTime;
+    double lastTime = m_lastTextTrackUpdateTime;
 
     // 4 - If the current playback position has, since the last time this
@@ -1128 +1128 @@
 
         for (size_t i = 0; i < potentiallySkippedCues.size(); ++i) {
-            float cueStartTime = potentiallySkippedCues[i].low();
-            float cueEndTime = potentiallySkippedCues[i].high();
+            double cueStartTime = potentiallySkippedCues[i].low();
+            double cueEndTime = potentiallySkippedCues[i].high();
 
             // Consider cues that may have been missed since the last seek time.
@@ -2010 +2010 @@
 }
 
-void HTMLMediaElement::rewind(float timeDelta)
+void HTMLMediaElement::rewind(double timeDelta)
 {
     LOG(Media, "HTMLMediaElement::rewind(%f)", timeDelta);
@@ -2022 +2022 @@
 }
 
-void HTMLMediaElement::addPlayedRange(float start, float end)
+void HTMLMediaElement::addPlayedRange(double start, double end)
 {
     LOG(Media, "HTMLMediaElement::addPlayedRange(%f, %f)", start, end);
@@ -2049 +2049 @@
 }
 
-void HTMLMediaElement::seek(float time, ExceptionCode& ec)
+void HTMLMediaElement::seek(double time, ExceptionCode& ec)
 {
     LOG(Media, "HTMLMediaElement::seek(%f)", time);
@@ -2067 +2067 @@
     // Get the current time before setting m_seeking, m_lastSeekTime is returned once it is set.
     refreshCachedTime();
-    float now = currentTime();
+    double now = currentTime();
 
     // 2 - If the element's seeking IDL attribute is true, then another instance of this algorithm is
@@ -2083 +2083 @@
 
     // 6 - If the new playback position is less than the earliest possible position, let it be that position instead.
-    float earliestTime = m_player->startTime();
+    double earliestTime = m_player->startTime();
     time = max(time, earliestTime);
 
@@ -2092 +2092 @@
     // fire a 'seeked' event.
 #if !LOG_DISABLED
-    float mediaTime = m_player->mediaTimeForTimeValue(time);
+    double mediaTime = m_player->mediaTimeForTimeValue(time);
     if (time != mediaTime)
         LOG(Media, "HTMLMediaElement::seek(%f) - media timeline equivalent is %f", time, mediaTime);
@@ -2199 +2199 @@
 
 // playback state
-float HTMLMediaElement::currentTime() const
+double HTMLMediaElement::currentTime() const
 {
 #if LOG_CACHED_TIME_WARNINGS
@@ -2215 +2215 @@
     if (m_cachedTime != MediaPlayer::invalidTime() && m_paused) {
 #if LOG_CACHED_TIME_WARNINGS
-        float delta = m_cachedTime - m_player->currentTime();
+        double delta = m_cachedTime - m_player->currentTime();
         if (delta > minCachedDeltaForWarning)
             LOG(Media, "HTMLMediaElement::currentTime - WARNING, cached time is %f seconds off of media time when paused", delta);
@@ -2231 +2231 @@
         // Not too soon, use the cached time only if it hasn't expired.
         if (wallClockDelta < maximumDurationToCacheMediaTime) {
-            float adjustedCacheTime = static_cast<float>(m_cachedTime + (m_playbackRate * wallClockDelta));
+            double adjustedCacheTime = m_cachedTime + (m_playbackRate * wallClockDelta);
 
 #if LOG_CACHED_TIME_WARNINGS
-            float delta = adjustedCacheTime - m_player->currentTime();
+            double delta = adjustedCacheTime - m_player->currentTime();
             if (delta > minCachedDeltaForWarning)
                 LOG(Media, "HTMLMediaElement::currentTime - WARNING, cached time is %f seconds off of media time when playing", delta);
@@ -2245 +2245 @@
     if (maximumDurationToCacheMediaTime && now > m_minimumWallClockTimeToCacheMediaTime && m_cachedTime != MediaPlayer::invalidTime()) {
         double wallClockDelta = now - m_cachedTimeWallClockUpdateTime;
-        float delta = m_cachedTime + (m_playbackRate * wallClockDelta) - m_player->currentTime();
+        double delta = m_cachedTime + (m_playbackRate * wallClockDelta) - m_player->currentTime();
         LOG(Media, "HTMLMediaElement::currentTime - cached time was %f seconds off of media time when it expired", delta);
     }
@@ -2255 +2255 @@
 }
 
-void HTMLMediaElement::setCurrentTime(float time, ExceptionCode& ec)
+void HTMLMediaElement::setCurrentTime(double time, ExceptionCode& ec)
 {
     if (m_mediaController) {
@@ -2264 +2264 @@
 }
 
-float HTMLMediaElement::startTime() const
+double HTMLMediaElement::startTime() const
 {
     if (!m_player)
@@ -2282 +2282 @@
 }
 
-float HTMLMediaElement::duration() const
+double HTMLMediaElement::duration() const
 {
     if (m_player && m_readyState >= HAVE_METADATA)
         return m_player->duration();
 
-    return numeric_limits<float>::quiet_NaN();
+    return numeric_limits<double>::quiet_NaN();
 }
 
@@ -2295 +2295 @@
 }
 
-float HTMLMediaElement::defaultPlaybackRate() const
+double HTMLMediaElement::defaultPlaybackRate() const
 {
     return m_defaultPlaybackRate;
 }
 
-void HTMLMediaElement::setDefaultPlaybackRate(float rate)
+void HTMLMediaElement::setDefaultPlaybackRate(double rate)
 {
     if (m_defaultPlaybackRate != rate) {
@@ -2308 +2308 @@
 }
 
-float HTMLMediaElement::playbackRate() const
+double HTMLMediaElement::playbackRate() const
 {
     return m_playbackRate;
 }
 
-void HTMLMediaElement::setPlaybackRate(float rate)
+void HTMLMediaElement::setPlaybackRate(double rate)
 {
     LOG(Media, "HTMLMediaElement::setPlaybackRate(%f)", rate);
@@ -2329 +2329 @@
 void HTMLMediaElement::updatePlaybackRate()
 {
-    float effectiveRate = m_mediaController ? m_mediaController->playbackRate() : m_playbackRate;
+    double effectiveRate = m_mediaController ? m_mediaController->playbackRate() : m_playbackRate;
     if (m_player && potentiallyPlaying() && m_player->rate() != effectiveRate)
         m_player->setRate(effectiveRate);
@@ -2625 +2625 @@
 }
 
-float HTMLMediaElement::volume() const
+double HTMLMediaElement::volume() const
 {
     return m_volume;
 }
 
-void HTMLMediaElement::setVolume(float vol, ExceptionCode& ec)
+void HTMLMediaElement::setVolume(double vol, ExceptionCode& ec)
 {
     LOG(Media, "HTMLMediaElement::setVolume(%f)", vol);
@@ -2759 +2759 @@
     // Some media engines make multiple "time changed" callbacks at the same time, but we only want one
     // event at a given time so filter here
-    float movieTime = currentTime();
+    double movieTime = currentTime();
     if (movieTime != m_lastTimeUpdateEventMovieTime) {
         scheduleEvent(eventNames().timeupdateEvent);
@@ -2772 +2772 @@
 }
 
-float HTMLMediaElement::percentLoaded() const
+double HTMLMediaElement::percentLoaded() const
 {
     if (!m_player)
         return 0;
-    float duration = m_player->duration();
+    double duration = m_player->duration();
 
     if (!duration || std::isinf(duration))
         return 0;
 
-    float buffered = 0;
+    double buffered = 0;
     RefPtr<TimeRanges> timeRanges = m_player->buffered();
     for (unsigned i = 0; i < timeRanges->length(); ++i) {
-        float start = timeRanges->start(i, IGNORE_EXCEPTION);
-        float end = timeRanges->end(i, IGNORE_EXCEPTION);
+        double start = timeRanges->start(i, IGNORE_EXCEPTION);
+        double end = timeRanges->end(i, IGNORE_EXCEPTION);
         buffered += end - start;
     }
@@ -3463 +3463 @@
     scheduleTimeupdateEvent(false);
 
-    float now = currentTime();
-    float dur = duration();
+    double now = currentTime();
+    double dur = duration();
     
     // When the current playback position reaches the end of the media resource when the direction of
@@ -3506 +3506 @@
     beginProcessingMediaPlayerCallback();
     if (m_player) {
-        float vol = m_player->volume();
+        double vol = m_player->volume();
         if (vol != m_volume) {
             m_volume = vol;
@@ -3535 +3535 @@
     mediaPlayerCharacteristicChanged(player);
 
-    float now = currentTime();
-    float dur = duration();
+    double now = currentTime();
+    double dur = duration();
     if (now > dur)
         seek(dur, IGNORE_EXCEPTION);
@@ -3691 +3691 @@
 {
     if (m_playing) {
-        float time = currentTime();
+        double time = currentTime();
         if (time > m_lastSeekTime)
             addPlayedRange(m_lastSeekTime, time);
@@ -3723 +3723 @@
 bool HTMLMediaElement::endedPlayback() const
 {
-    float dur = duration();
+    double dur = duration();
     if (!m_player || std::isnan(dur))
         return false;
@@ -3737 +3737 @@
     // of playback is forwards, Either the media element does not have a loop attribute specified,
     // or the media element has a current media controller.
-    float now = currentTime();
+    double now = currentTime();
     if (m_playbackRate > 0)
         return dur > 0 && now >= dur && (!loop() || m_mediaController);
@@ -3766 +3766 @@
 }
 
-float HTMLMediaElement::minTimeSeekable() const
+double HTMLMediaElement::minTimeSeekable() const
 {
     return 0;
 }
 
-float HTMLMediaElement::maxTimeSeekable() const
+double HTMLMediaElement::maxTimeSeekable() const
 {
     return m_player ? m_player->maxTimeSeekable() : 0;
@@ -3784 +3784 @@
     if (!processingMediaPlayerCallback()) {
         Page* page = document()->page();
-        float volumeMultiplier = page ? page->mediaVolume() : 1;
+        double volumeMultiplier = page ? page->mediaVolume() : 1;
         bool shouldMute = m_muted;
 
@@ -3849 +3849 @@
         m_playbackProgressTimer.stop();
         m_playing = false;
-        float time = currentTime();
+        double time = currentTime();
         if (time > m_lastSeekTime)
             addPlayedRange(m_lastSeekTime, time);
@@ -4713 +4713 @@
     // position relative to the MediaController's timeline or after the end of the media resource 
     // relative to the MediaController's timeline.
-    float mediaControllerPosition = m_mediaController->currentTime();
+    double mediaControllerPosition = m_mediaController->currentTime();
     if (mediaControllerPosition < startTime() || mediaControllerPosition > startTime() + duration())
         return true;
@@ -4723 +4723 @@
 {
     MediaFragmentURIParser fragmentParser(m_currentSrc);
-    float dur = duration();
+    double dur = duration();
     
     double start = fragmentParser.startTime();

trunk/Source/WebCore/html/HTMLMediaElement.h

@@ -98 +98 @@
     virtual bool hasAudio() const;
 
-    void rewind(float timeDelta);
+    void rewind(double timeDelta);
     void returnToRealtime();
 
@@ -147 +147 @@
 
 // playback state
-    float currentTime() const;
-    void setCurrentTime(float, ExceptionCode&);
+    double currentTime() const;
+    void setCurrentTime(double, ExceptionCode&);
     double initialTime() const;
-    float startTime() const;
-    float duration() const;
+    double startTime() const;
+    double duration() const;
     bool paused() const;
-    float defaultPlaybackRate() const;
-    void setDefaultPlaybackRate(float);
-    float playbackRate() const;
-    void setPlaybackRate(float);
+    double defaultPlaybackRate() const;
+    void setDefaultPlaybackRate(double);
+    double playbackRate() const;
+    void setPlaybackRate(double);
     void updatePlaybackRate();
     bool webkitPreservesPitch() const;
@@ -209 +209 @@
     bool controls() const;
     void setControls(bool);
-    float volume() const;
-    void setVolume(float, ExceptionCode&);
+    double volume() const;
+    void setVolume(double, ExceptionCode&);
     bool muted() const;
     void setMuted(bool);
@@ -220 +220 @@
     bool canPlay() const;
 
-    float percentLoaded() const;
+    double percentLoaded() const;
 
 #if ENABLE(VIDEO_TRACK)
@@ -496 +496 @@
     void stopPeriodicTimers();
 
-    void seek(float time, ExceptionCode&);
+    void seek(double time, ExceptionCode&);
     void finishSeek();
     void checkIfSeekNeeded();
-    void addPlayedRange(float start, float end);
+    void addPlayedRange(double start, double end);
     
     void scheduleTimeupdateEvent(bool periodicEvent);
@@ -523 +523 @@
 
 #if ENABLE(VIDEO_TRACK)
-    void updateActiveTextTrackCues(float);
+    void updateActiveTextTrackCues(double);
     HTMLTrackElement* showingTrackWithSameKind(HTMLTrackElement*) const;
 
@@ -550 +550 @@
     bool couldPlayIfEnoughData() const;
 
-    float minTimeSeekable() const;
-    float maxTimeSeekable() const;
+    double minTimeSeekable() const;
+    double maxTimeSeekable() const;
 
     // Pauses playback without changing any states or generating events
     void setPausedInternal(bool);
 
-    void setPlaybackRateInternal(float);
+    void setPlaybackRateInternal(double);
 
     virtual void mediaCanStart();
@@ -600 +600 @@
     OwnPtr<GenericEventQueue> m_asyncEventQueue;
 
-    float m_playbackRate;
-    float m_defaultPlaybackRate;
+    double m_playbackRate;
+    double m_defaultPlaybackRate;
     bool m_webkitPreservesPitch;
     NetworkState m_networkState;
@@ -610 +610 @@
     RefPtr<MediaError> m_error;
 
-    float m_volume;
-    float m_lastSeekTime;
+    double m_volume;
+    double m_lastSeekTime;
     
     unsigned m_previousProgress;
@@ -620 +620 @@
 
     // The last time a timeupdate event was sent in movie time.
-    float m_lastTimeUpdateEventMovieTime;
+    double m_lastTimeUpdateEventMovieTime;
     
     // Loading state.
@@ -647 +647 @@
 #endif
 
-    mutable float m_cachedTime;
+    mutable double m_cachedTime;
     mutable double m_cachedTimeWallClockUpdateTime;
     mutable double m_minimumWallClockTimeToCacheMediaTime;
@@ -696 +696 @@
     bool m_haveVisibleTextTrack : 1;
     bool m_processingPreferenceChange : 1;
-
     float m_lastTextTrackUpdateTime;
+
     CaptionUserPreferences::CaptionDisplayMode m_captionDisplayMode;
 

trunk/Source/WebCore/html/HTMLMediaElement.idl

@@ -64 +64 @@
 
 // playback state
-attribute float currentTime
+attribute double currentTime
     setter raises (DOMException);
 readonly attribute double initialTime;
-readonly attribute float startTime;
-readonly attribute float duration;
+readonly attribute double startTime;
+readonly attribute double duration;
 readonly attribute boolean paused;
-attribute float defaultPlaybackRate;
-attribute float playbackRate;
+attribute double defaultPlaybackRate;
+attribute double playbackRate;
 readonly attribute TimeRanges played;
 readonly attribute TimeRanges seekable;
@@ -82 +82 @@
 // controls
 attribute boolean controls;
-attribute float volume 
+attribute double volume 
     setter raises (DOMException);
 attribute boolean muted;

trunk/Source/WebCore/html/MediaController.cpp

@@ -130 +130 @@
 }
 
-float MediaController::duration() const
+double MediaController::duration() const
 {
     // FIXME: Investigate caching the maximum duration and only updating the cached value
     // when the slaved media elements' durations change.
-    float maxDuration = 0;
-    for (size_t index = 0; index < m_mediaElements.size(); ++index) {
-        float duration = m_mediaElements[index]->duration();
+    double maxDuration = 0;
+    for (size_t index = 0; index < m_mediaElements.size(); ++index) {
+        double duration = m_mediaElements[index]->duration();
         if (std::isnan(duration))
             continue;
@@ -144 +144 @@
 }
 
-float MediaController::currentTime() const
+double MediaController::currentTime() const
 {
     if (m_mediaElements.isEmpty())
@@ -151 +151 @@
     if (m_position == MediaPlayer::invalidTime()) {
         // Some clocks may return times outside the range of [0..duration].
-        m_position = max(0.0f, min(duration(), m_clock->currentTime()));
+        m_position = max(0.0, min(duration(), m_clock->currentTime()));
         m_clearPositionTimer.startOneShot(0);
     }
@@ -158 +158 @@
 }
 
-void MediaController::setCurrentTime(float time, ExceptionCode& code)
+void MediaController::setCurrentTime(double time, ExceptionCode& code)
 {
     // When the user agent is to seek the media controller to a particular new playback position, 
     // it must follow these steps:
     // If the new playback position is less than zero, then set it to zero.
-    time = max(0.0f, time);
+    time = max(0.0, time);
     
     // If the new playback position is greater than the media controller duration, then set it 
@@ -218 +218 @@
 }
 
-void MediaController::setDefaultPlaybackRate(float rate)
+void MediaController::setDefaultPlaybackRate(double rate)
 {
     if (m_defaultPlaybackRate == rate)
@@ -231 +231 @@
 }
 
-float MediaController::playbackRate() const
+double MediaController::playbackRate() const
 {
     return m_clock->playRate();
 }
 
-void MediaController::setPlaybackRate(float rate)
+void MediaController::setPlaybackRate(double rate)
 {
     if (m_clock->playRate() == rate)
@@ -252 +252 @@
 }
 
-void MediaController::setVolume(float level, ExceptionCode& code)
+void MediaController::setVolume(double level, ExceptionCode& code)
 {
     if (m_volume == level)

trunk/Source/WebCore/html/MediaController.h

@@ -61 +61 @@
     virtual PassRefPtr<TimeRanges> played();
     
-    virtual float duration() const;
-    virtual float currentTime() const;
-    virtual void setCurrentTime(float, ExceptionCode&);
+    virtual double duration() const;
+    virtual double currentTime() const;
+    virtual void setCurrentTime(double, ExceptionCode&);
     
     virtual bool paused() const { return m_paused; }
@@ -70 +70 @@
     void unpause();
     
-    virtual float defaultPlaybackRate() const { return m_defaultPlaybackRate; }
-    virtual void setDefaultPlaybackRate(float);
+    virtual double defaultPlaybackRate() const { return m_defaultPlaybackRate; }
+    virtual void setDefaultPlaybackRate(double);
     
-    virtual float playbackRate() const;
-    virtual void setPlaybackRate(float);
+    virtual double playbackRate() const;
+    virtual void setPlaybackRate(double);
     
-    virtual float volume() const { return m_volume; }
-    virtual void setVolume(float, ExceptionCode&);
+    virtual double volume() const { return m_volume; }
+    virtual void setVolume(double, ExceptionCode&);
     
     virtual bool muted() const { return m_muted; }
@@ -144 +144 @@
     Vector<HTMLMediaElement*> m_mediaElements;
     bool m_paused;
-    float m_defaultPlaybackRate;
-    float m_volume;
-    mutable float m_position;
+    double m_defaultPlaybackRate;
+    double m_volume;
+    mutable double m_position;
     bool m_muted;
     ReadyState m_readyState;

trunk/Source/WebCore/html/MediaControllerInterface.h

@@ -46 +46 @@
     virtual PassRefPtr<TimeRanges> played() = 0;
     
-    virtual float duration() const = 0;
-    virtual float currentTime() const = 0;
-    virtual void setCurrentTime(float, ExceptionCode&) = 0;
+    virtual double duration() const = 0;
+    virtual double currentTime() const = 0;
+    virtual void setCurrentTime(double, ExceptionCode&) = 0;
     
     virtual bool paused() const = 0;
@@ -54 +54 @@
     virtual void pause() = 0;
     
-    virtual float defaultPlaybackRate() const = 0;
-    virtual void setDefaultPlaybackRate(float) = 0;
+    virtual double defaultPlaybackRate() const = 0;
+    virtual void setDefaultPlaybackRate(double) = 0;
     
-    virtual float playbackRate() const = 0;
-    virtual void setPlaybackRate(float) = 0;
+    virtual double playbackRate() const = 0;
+    virtual void setPlaybackRate(double) = 0;
     
-    virtual float volume() const = 0;
-    virtual void setVolume(float, ExceptionCode&) = 0;
+    virtual double volume() const = 0;
+    virtual void setVolume(double, ExceptionCode&) = 0;
     
     virtual bool muted() const = 0;

trunk/Source/WebCore/html/TimeRanges.cpp

@@ -35 +35 @@
 using namespace std;
 
-TimeRanges::TimeRanges(float start, float end)
+TimeRanges::TimeRanges(double start, double end)
 {
     add(start, end);
@@ -54 +54 @@
 {
     RefPtr<TimeRanges> inverted = TimeRanges::create();
-    float posInf = std::numeric_limits<float>::infinity();
-    float negInf = -std::numeric_limits<float>::infinity();
+    double posInf = std::numeric_limits<double>::infinity();
+    double negInf = -std::numeric_limits<double>::infinity();
 
     if (!m_ranges.size())
         inverted->add(negInf, posInf);
     else {
-        if (float start = m_ranges.first().m_start != negInf)
+        if (double start = m_ranges.first().m_start != negInf)
             inverted->add(negInf, start);
 
@@ -66 +66 @@
             inverted->add(m_ranges[index].m_end, m_ranges[index + 1].m_start);
 
-        if (float end = m_ranges.last().m_end != posInf)
+        if (double end = m_ranges.last().m_end != posInf)
             inverted->add(end, posInf);
     }
@@ -96 +96 @@
 }
 
-float TimeRanges::start(unsigned index, ExceptionCode& ec) const 
+double TimeRanges::start(unsigned index, ExceptionCode& ec) const 
 { 
     if (index >= length()) {
@@ -105 +105 @@
 }
 
-float TimeRanges::end(unsigned index, ExceptionCode& ec) const 
+double TimeRanges::end(unsigned index, ExceptionCode& ec) const 
 { 
     if (index >= length()) {
@@ -114 +114 @@
 }
 
-void TimeRanges::add(float start, float end) 
+void TimeRanges::add(double start, double end) 
 {
     ASSERT(start <= end);
@@ -157 +157 @@
 }
 
-bool TimeRanges::contain(float time) const
+bool TimeRanges::contain(double time) const
 {
     for (unsigned n = 0; n < length(); n++) {
@@ -166 +166 @@
 }
 
-float TimeRanges::nearest(float time) const
+double TimeRanges::nearest(double time) const
 {
-    float closest = 0;
+    double closest = 0;
     unsigned count = length();
     for (unsigned ndx = 0; ndx < count; ndx++) {
-        float startTime = start(ndx, IGNORE_EXCEPTION);
-        float endTime = end(ndx, IGNORE_EXCEPTION);
+        double startTime = start(ndx, IGNORE_EXCEPTION);
+        double endTime = end(ndx, IGNORE_EXCEPTION);
         if (time >= startTime && time <= endTime)
             return time;

trunk/Source/WebCore/html/TimeRanges.h

@@ -42 +42 @@
         return adoptRef(new TimeRanges);
     }
-    static PassRefPtr<TimeRanges> create(float start, float end)
+    static PassRefPtr<TimeRanges> create(double start, double end)
     {
         return adoptRef(new TimeRanges(start, end));
@@ -53 +53 @@
 
     unsigned length() const { return m_ranges.size(); }
-    float start(unsigned index, ExceptionCode&) const;
-    float end(unsigned index, ExceptionCode&) const;
+    double start(unsigned index, ExceptionCode&) const;
+    double end(unsigned index, ExceptionCode&) const;
     
-    void add(float start, float end);
+    void add(double start, double end);
     
-    bool contain(float time) const;
+    bool contain(double time) const;
     
-    float nearest(float time) const;
+    double nearest(double time) const;
 
 private:
     TimeRanges() { }
-    TimeRanges(float start, float end);
+    TimeRanges(double start, double end);
     TimeRanges(const TimeRanges&);
 
@@ -70 +70 @@
     struct Range {
         Range() { }
-        Range(float start, float end)
+        Range(double start, double end)
         {
             m_start = start;
             m_end = end;
         }
-        float m_start;
-        float m_end;
+        double m_start;
+        double m_end;
 
-        inline bool isPointInRange(float point) const
+        inline bool isPointInRange(double point) const
         {
             return m_start <= point && point < m_end;

trunk/Source/WebCore/html/TimeRanges.idl

@@ -29 +29 @@
 ] interface TimeRanges {
     readonly attribute unsigned long length;
-    float start(in unsigned long index)
+    double start(in unsigned long index)
         raises (DOMException);
-    float end(in unsigned long index)
+    double end(in unsigned long index)
         raises (DOMException);
 };

trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp

@@ -35 +35 @@
 #include "CSSValueKeywords.h"
 #include "ExceptionCodePlaceholder.h"
-#include "FloatConversion.h"
 #include "HTMLNames.h"
 #include "MouseEvent.h"
@@ -49 +48 @@
 
 // FIXME: These constants may need to be tweaked to better match the seeking in the QuickTime plug-in.
-static const float cSkipRepeatDelay = 0.1f;
-static const float cSkipTime = 0.2f;
-static const float cScanRepeatDelay = 1.5f;
-static const float cScanMaximumRate = 8;
+static const double cSkipRepeatDelay = 0.1;
+static const double cSkipTime = 0.2;
+static const double cScanRepeatDelay = 1.5;
+static const double cScanMaximumRate = 8;
 
 HTMLMediaElement* toParentMediaElement(Node* node)
@@ -135 +134 @@
 }
 
-void MediaControlTimeDisplayElement::setCurrentValue(float time)
+void MediaControlTimeDisplayElement::setCurrentValue(double time)
 {
     m_currentValue = time;
@@ -230 +229 @@
 }
 
-float MediaControlSeekButtonElement::nextRate() const
-{
-    float rate = std::min(cScanMaximumRate, fabsf(mediaController()->playbackRate() * 2));
+double MediaControlSeekButtonElement::nextRate() const
+{
+    double rate = std::min(cScanMaximumRate, fabs(mediaController()->playbackRate() * 2));
     if (!isForwardButton())
         rate *= -1;
@@ -241 +240 @@
 {
     if (m_seekType == Skip) {
-        float skipTime = isForwardButton() ? cSkipTime : -cSkipTime;
+        double skipTime = isForwardButton() ? cSkipTime : -cSkipTime;
         mediaController()->setCurrentTime(mediaController()->currentTime() + skipTime, IGNORE_EXCEPTION);
     } else
@@ -269 +268 @@
         return;
 
-    float volume = narrowPrecisionToFloat(value().toDouble());
+    double volume = value().toDouble();
     if (volume != mediaController()->volume())
         mediaController()->setVolume(volume, ASSERT_NO_EXCEPTION);
@@ -292 +291 @@
 }
 
-void MediaControlVolumeSliderElement::setVolume(float volume)
-{
-    if (value().toFloat() != volume)
+void MediaControlVolumeSliderElement::setVolume(double volume)
+{
+    if (value().toDouble() != volume)
         setValue(String::number(volume));
 }

trunk/Source/WebCore/html/shadow/MediaControlElementTypes.h

@@ -130 +130 @@
 class MediaControlTimeDisplayElement : public MediaControlDivElement {
 public:
-    void setCurrentValue(float);
-    float currentValue() const { return m_currentValue; }
+    void setCurrentValue(double);
+    double currentValue() const { return m_currentValue; }
 
 protected:
@@ -137 +137 @@
 
 private:
-    float m_currentValue;
+    double m_currentValue;
 };
 
@@ -174 +174 @@
     void startTimer();
     void stopTimer();
-    float nextRate() const;
+    double nextRate() const;
     void seekTimerFired(Timer<MediaControlSeekButtonElement>*);
 
@@ -190 +190 @@
     virtual bool willRespondToMouseMoveEvents() OVERRIDE;
     virtual bool willRespondToMouseClickEvents() OVERRIDE;
-    void setVolume(float);
+    void setVolume(double);
     void setClearMutedOnUserInteraction(bool);
 

trunk/Source/WebCore/html/shadow/MediaControlElements.cpp

@@ -38 +38 @@
 #include "EventTarget.h"
 #include "ExceptionCodePlaceholder.h"
-#include "FloatConversion.h"
 #include "Frame.h"
 #include "GraphicsContext.h"
@@ -630 +629 @@
 {
     if (event->type() == eventNames().clickEvent) {
-        mediaController()->setCurrentTime(max(0.0f, mediaController()->currentTime() - 30), IGNORE_EXCEPTION);
+        mediaController()->setCurrentTime(max(0.0, mediaController()->currentTime() - 30), IGNORE_EXCEPTION);
         event->setDefaultHandled();
     }
@@ -946 +945 @@
         return;
 
-    float time = narrowPrecisionToFloat(value().toDouble());
+    double time = value().toDouble();
     if (event->type() == eventNames().inputEvent && time != mediaController()->currentTime())
         mediaController()->setCurrentTime(time, IGNORE_EXCEPTION);
@@ -963 +962 @@
 }
 
-void MediaControlTimelineElement::setPosition(float currentTime)
+void MediaControlTimelineElement::setPosition(double currentTime)
 {
     setValue(String::number(currentTime));
 }
 
-void MediaControlTimelineElement::setDuration(float duration)
+void MediaControlTimelineElement::setDuration(double duration)
 {
     setAttribute(maxAttr, String::number(std::isfinite(duration) ? duration : 0));

trunk/Source/WebCore/html/shadow/MediaControlElements.h

@@ -334 +334 @@
     virtual bool willRespondToMouseClickEvents() OVERRIDE;
 
-    void setPosition(float);
-    void setDuration(float);
+    void setPosition(double);
+    void setDuration(double);
 
 private:

trunk/Source/WebCore/html/shadow/MediaControls.cpp

@@ -93 +93 @@
     updateCurrentTimeDisplay();
 
-    float duration = m_mediaController->duration();
+    double duration = m_mediaController->duration();
     if (std::isfinite(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) {
         m_timeline->setDuration(duration);
@@ -215 +215 @@
 void MediaControls::updateCurrentTimeDisplay()
 {
-    float now = m_mediaController->currentTime();
+    double now = m_mediaController->currentTime();
 
     Page* page = document()->page();

trunk/Source/WebCore/html/shadow/MediaControlsApple.cpp

@@ -324 +324 @@
         m_fullScreenButton->hide();
 
-    float duration = m_mediaController->duration();
+    double duration = m_mediaController->duration();
     if (std::isfinite(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) {
         m_timeline->setDuration(duration);
@@ -382 +382 @@
 void MediaControlsApple::updateCurrentTimeDisplay()
 {
-    float now = m_mediaController->currentTime();
-    float duration = m_mediaController->duration();
+    double now = m_mediaController->currentTime();
+    double duration = m_mediaController->duration();
 
     Page* page = document()->page();

trunk/Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp

@@ -34 +34 @@
 #include "DOMTokenList.h"
 #include "ExceptionCodePlaceholder.h"
-#include "FloatConversion.h"
 #include "Frame.h"
 #include "HTMLMediaElement.h"
@@ -482 +481 @@
     timeline->ensureUserAgentShadowRoot();
     timeline->setType("range");
-    timeline->setAttribute(precisionAttr, "float");
+    timeline->setAttribute(precisionAttr, "double");
     return timeline.release();
 }
@@ -506 +505 @@
         return;
 
-    float time = narrowPrecisionToFloat(value().toDouble());
+    double time = value().toDouble();
     if (event->type() == eventNames().inputEvent && time != mediaController()->currentTime())
         mediaController()->setCurrentTime(time, IGNORE_EXCEPTION);
@@ -523 +522 @@
 }
 
-void MediaControlFullscreenTimelineElement::setPosition(float currentTime)
+void MediaControlFullscreenTimelineElement::setPosition(double currentTime)
 {
     setValue(String::number(currentTime));
 }
 
-void MediaControlFullscreenTimelineElement::setDuration(float duration)
+void MediaControlFullscreenTimelineElement::setDuration(double duration)
 {
     setAttribute(maxAttr, String::number(std::isfinite(duration) ? duration : 0));
@@ -912 +911 @@
             m_fullscreenFullScreenButton->hide();
     }
-    float duration = m_mediaController->duration();
+    double duration = m_mediaController->duration();
     if (std::isfinite(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) {
-        float now = m_mediaController->currentTime();
+        double now = m_mediaController->currentTime();
         m_timeline->setDuration(duration);
         m_fullscreenTimeline->setDuration(duration);
@@ -956 +955 @@
     // playback playbackProgressed() will take care of it.
     if (m_mediaController->paused()) {
-        float now = m_mediaController->currentTime();
+        double now = m_mediaController->currentTime();
         m_timeline->setPosition(now);
         m_fullscreenTimeline->setPosition(now);
@@ -964 +963 @@
 void MediaControlsBlackBerry::playbackStarted()
 {
-    float now = m_mediaController->currentTime();
+    double now = m_mediaController->currentTime();
     m_playButton->updateDisplayType();
     m_fullscreenPlayButton->updateDisplayType();
@@ -977 +976 @@
 void MediaControlsBlackBerry::playbackProgressed()
 {
-    float now = m_mediaController->currentTime();
+    double now = m_mediaController->currentTime();
     m_timeline->setPosition(now);
     m_fullscreenTimeline->setPosition(now);
@@ -988 +987 @@
 void MediaControlsBlackBerry::playbackStopped()
 {
-    float now = m_mediaController->currentTime();
+    double now = m_mediaController->currentTime();
     m_playButton->updateDisplayType();
     m_fullscreenPlayButton->updateDisplayType();
@@ -1001 +1000 @@
 void MediaControlsBlackBerry::updateCurrentTimeDisplay()
 {
-    float now = m_mediaController->currentTime();
-    float duration = m_mediaController->duration();
+    double now = m_mediaController->currentTime();
+    double duration = m_mediaController->duration();
 
     Page* page = document()->page();

trunk/Source/WebCore/html/shadow/MediaControlsBlackBerry.h

@@ -194 +194 @@
 
     virtual bool willRespondToMouseClickEvents() OVERRIDE;
-    void setPosition(float);
-    void setDuration(float);
+    void setPosition(double);
+    void setDuration(double);
 
 private:

trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp

@@ -156 +156 @@
         return;
 
-    float duration = m_mediaController->duration();
+    double duration = m_mediaController->duration();
     m_durationDisplay->setInnerText(page->theme()->formatMediaControlsTime(duration), ASSERT_NO_EXCEPTION);
     m_durationDisplay->setCurrentValue(duration);
@@ -173 +173 @@
 void MediaControlsGtk::updateCurrentTimeDisplay()
 {
-    float now = m_mediaController->currentTime();
-    float duration = m_mediaController->duration();
+    double now = m_mediaController->currentTime();
+    double duration = m_mediaController->duration();
 
     Page* page = document()->page();

trunk/Source/WebCore/html/track/TextTrackCue.cpp

@@ -765 +765 @@
 }
 
-void TextTrackCue::updateDisplayTree(float movieTime)
+void TextTrackCue::updateDisplayTree(double movieTime)
 {
     // The display tree may contain WebVTT timestamp objects representing

trunk/Source/WebCore/html/track/TextTrackCue.h

@@ -148 +148 @@
     PassRefPtr<HTMLDivElement> element() const { return m_cueBackgroundBox; }
 
-    void updateDisplayTree(float);
+    void updateDisplayTree(double);
     void removeDisplayTree();
     void markFutureAndPastNodes(ContainerNode*, double, double);

trunk/Source/WebCore/platform/Clock.h

@@ -37 +37 @@
     virtual ~Clock() { }
 
-    virtual void setCurrentTime(float) = 0;
-    virtual float currentTime() const = 0;
+    virtual void setCurrentTime(double) = 0;
+    virtual double currentTime() const = 0;
 
-    virtual void setPlayRate(float) = 0;
-    virtual float playRate() const = 0;
+    virtual void setPlayRate(double) = 0;
+    virtual double playRate() const = 0;
 
     virtual void start() = 0;

trunk/Source/WebCore/platform/ClockGeneric.cpp

@@ -27 +27 @@
 #include "ClockGeneric.h"
 
-#include "FloatConversion.h"
 #include <wtf/CurrentTime.h>
 
@@ -40 +39 @@
 }
 
-void ClockGeneric::setCurrentTime(float time)
+void ClockGeneric::setCurrentTime(double time)
 {
     m_startTime = m_lastTime = now();
@@ -46 +45 @@
 }
 
-float ClockGeneric::currentTime() const
+double ClockGeneric::currentTime() const
 {
     if (m_running)
         m_lastTime = now();
-    float time = narrowPrecisionToFloat(((m_lastTime - m_startTime) * m_rate) + m_offset);
-    return time;
+    return ((m_lastTime - m_startTime) * m_rate) + m_offset;
 }
 
-void ClockGeneric::setPlayRate(float rate)
+void ClockGeneric::setPlayRate(double rate)
 {
     m_offset = now();
@@ -84 +82 @@
     return WTF::currentTime();
 }
-

trunk/Source/WebCore/platform/ClockGeneric.h

@@ -36 +36 @@
 
 private:
-    virtual void setCurrentTime(float);
-    virtual float currentTime() const;
+    virtual void setCurrentTime(double);
+    virtual double currentTime() const;
 
-    virtual void setPlayRate(float);
-    virtual float playRate() const { return m_rate; }
+    virtual void setPlayRate(double);
+    virtual double playRate() const { return m_rate; }
 
     virtual void start();
@@ -49 +49 @@
 
     bool m_running;
-    float m_rate;
+    double m_rate;
     double m_offset;
     double m_startTime;

trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp

@@ -114 +114 @@
     virtual void setVisible(bool) { }
 
-    virtual float duration() const { return 0; }
-
-    virtual float currentTime() const { return 0; }
-    virtual void seek(float) { }
+    virtual double durationDouble() const { return 0; }
+
+    virtual double currentTimeDouble() const { return 0; }
+    virtual void seekDouble(double) { }
     virtual bool seeking() const { return false; }
 
-    virtual void setRate(float) { }
+    virtual void setRateDouble(double) { }
     virtual void setPreservesPitch(bool) { }
     virtual bool paused() const { return false; }
 
-    virtual void setVolume(float) { }
+    virtual void setVolumeDouble(double) { }
 
     virtual bool supportsMuting() const { return false; }
@@ -135 +135 @@
     virtual MediaPlayer::ReadyState readyState() const { return MediaPlayer::HaveNothing; }
 
-    virtual float maxTimeSeekable() const { return 0; }
+    virtual double maxTimeSeekableDouble() const { return 0; }
     virtual PassRefPtr<TimeRanges> buffered() const { return TimeRanges::create(); }
 
@@ -512 +512 @@
 #endif
 
-float MediaPlayer::duration() const
-{
-    return m_private->duration();
-}
-
-float MediaPlayer::startTime() const
-{
-    return m_private->startTime();
+double MediaPlayer::duration() const
+{
+    return m_private->durationDouble();
+}
+
+double MediaPlayer::startTime() const
+{
+    return m_private->startTimeDouble();
 }
 
@@ -527 +527 @@
 }
 
-float MediaPlayer::currentTime() const
-{
-    return m_private->currentTime();
-}
-
-void MediaPlayer::seek(float time)
-{
-    m_private->seek(time);
+double MediaPlayer::currentTime() const
+{
+    return m_private->currentTimeDouble();
+}
+
+void MediaPlayer::seek(double time)
+{
+    m_private->seekDouble(time);
 }
 
@@ -607 +607 @@
 }
 
-float MediaPlayer::volume() const
+double MediaPlayer::volume() const
 {
     return m_volume;
 }
 
-void MediaPlayer::setVolume(float volume)
+void MediaPlayer::setVolume(double volume)
 {
     m_volume = volume;
 
     if (m_private->supportsMuting() || !m_muted)
-        m_private->setVolume(volume);
+        m_private->setVolumeDouble(volume);
 }
 
@@ -645 +645 @@
 }
 
-float MediaPlayer::rate() const
+double MediaPlayer::rate() const
 {
     return m_rate;
 }
 
-void MediaPlayer::setRate(float rate)
+void MediaPlayer::setRate(double rate)
 {
     m_rate = rate;
-    m_private->setRate(rate);   
+    m_private->setRateDouble(rate);
 }
 
@@ -677 +677 @@
 }
 
-float MediaPlayer::maxTimeSeekable()
-{
-    return m_private->maxTimeSeekable();
+double MediaPlayer::maxTimeSeekable()
+{
+    return m_private->maxTimeSeekableDouble();
 }
 
@@ -852 +852 @@
 }
 
-float MediaPlayer::mediaTimeForTimeValue(float timeValue) const
-{
-    return m_private->mediaTimeForTimeValue(timeValue);
+double MediaPlayer::mediaTimeForTimeValue(double timeValue) const
+{
+    return m_private->mediaTimeForTimeValueDouble(timeValue);
 }
 
@@ -950 +950 @@
 }
 
-void MediaPlayer::volumeChanged(float newVolume)
+void MediaPlayer::volumeChanged(double newVolume)
 {
     m_volume = newVolume;

trunk/Source/WebCore/platform/graphics/MediaPlayer.h

@@ -299 +299 @@
     bool seeking() const;
 
-    static float invalidTime() { return -1.0f;}
-    float duration() const;
-    float currentTime() const;
-    void seek(float time);
-
-    float startTime() const;
+    static double invalidTime() { return -1.0;}
+    double duration() const;
+    double currentTime() const;
+    void seek(double time);
+
+    double startTime() const;
 
     double initialTime() const;
 
-    float rate() const;
-    void setRate(float);
+    double rate() const;
+    void setRate(double);
 
     bool preservesPitch() const;    
@@ -316 +316 @@
     PassRefPtr<TimeRanges> buffered();
     PassRefPtr<TimeRanges> seekable();
-    float maxTimeSeekable();
+    double maxTimeSeekable();
 
     bool didLoadingProgress();
 
-    float volume() const;
-    void setVolume(float);
+    double volume() const;
+    void setVolume(double);
 
     bool muted() const;
@@ -365 +365 @@
     void networkStateChanged();
     void readyStateChanged();
-    void volumeChanged(float);
+    void volumeChanged(double);
     void muteChanged(bool);
     void timeChanged();
@@ -415 +415 @@
     bool didPassCORSAccessCheck() const;
 
-    float mediaTimeForTimeValue(float) const;
+    double mediaTimeForTimeValue(double) const;
 
     double maximumDurationToCacheMediaTime() const;
@@ -488 +488 @@
     Preload m_preload;
     bool m_visible;
-    float m_rate;
-    float m_volume;
+    double m_rate;
+    double m_volume;
     bool m_muted;
     bool m_preservesPitch;

trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h

@@ -71 +71 @@
     virtual void setVisible(bool) = 0;
 
-    virtual float duration() const = 0;
-
-    virtual float currentTime() const = 0;
-    virtual void seek(float time) = 0;
+    virtual float duration() const { return 0; }
+    virtual double durationDouble() const { return duration(); }
+
+    virtual float currentTime() const { return 0; }
+    virtual double currentTimeDouble() const { return currentTime(); }
+
+    virtual void seek(float) { }
+    virtual void seekDouble(double time) { seek(time); }
+
     virtual bool seeking() const = 0;
 
     virtual float startTime() const { return 0; }
+    virtual double startTimeDouble() const { return startTime(); }
 
     virtual double initialTime() const { return 0; }
 
-    virtual void setRate(float) = 0;
+    virtual void setRate(float) { }
+    virtual void setRateDouble(double rate) { setRate(rate); }
+
     virtual void setPreservesPitch(bool) { }
 
     virtual bool paused() const = 0;
 
-    virtual void setVolume(float) = 0;
+    virtual void setVolume(float) { }
+    virtual void setVolumeDouble(double volume) { return setVolume(volume); }
 
     virtual bool supportsMuting() const { return false; }
@@ -98 +107 @@
 
     virtual PassRefPtr<TimeRanges> seekable() const { return maxTimeSeekable() ? TimeRanges::create(0, maxTimeSeekable()) : TimeRanges::create(); }
-    virtual float maxTimeSeekable() const = 0;
+    virtual float maxTimeSeekable() const { return 0; }
+    virtual double maxTimeSeekableDouble() const { return maxTimeSeekable(); }
     virtual PassRefPtr<TimeRanges> buffered() const = 0;
 
@@ -150 +160 @@
     // engine uses rational numbers to represent media time.
     virtual float mediaTimeForTimeValue(float timeValue) const { return timeValue; }
+    virtual double mediaTimeForTimeValueDouble(double timeValue) const { return timeValue; }
 
     // Overide this if it is safe for HTMLMediaElement to cache movie time and report

trunk/Source/WebCore/platform/mac/PlatformClockCA.cpp

@@ -30 +30 @@
 #include "PlatformClockCA.h"
 
-#include "FloatConversion.h"
 #include <AudioToolbox/CoreAudioClock.h>
 #include <CoreAudio/AudioHardware.h>
@@ -62 +61 @@
 }
 
-void PlatformClockCA::setCurrentTime(float time)
+void PlatformClockCA::setCurrentTime(double time)
 {
     if (m_running)
@@ -74 +73 @@
 }
 
-float PlatformClockCA::currentTime() const
+double PlatformClockCA::currentTime() const
 {
     CAClockTime caTime;
@@ -82 +81 @@
     if (m_running) {
         if (CAClockGetCurrentTime(m_clock, kCAClockTimeFormat_Seconds, &caTime) == noErr)
-            return narrowPrecisionToFloat(caTime.time.seconds);
+            return caTime.time.seconds;
     } else {
         if (CAClockGetStartTime(m_clock, kCAClockTimeFormat_Seconds, &caTime) == noErr)
-            return narrowPrecisionToFloat(caTime.time.seconds);
+            return caTime.time.seconds;
     }
     return 0;
 }
 
-void PlatformClockCA::setPlayRate(float rate)
+void PlatformClockCA::setPlayRate(double rate)
 {
     CAClockSetPlayRate(m_clock, rate);
 }
 
-float PlatformClockCA::PlatformClockCA::playRate() const
+double PlatformClockCA::PlatformClockCA::playRate() const
 {
     double rate = 0;
     if (CAClockGetPlayRate(m_clock, &rate) == noErr)
-        return narrowPrecisionToFloat(rate);
+        return rate;
     return 0;
 }

trunk/Source/WebCore/platform/mac/PlatformClockCA.h

@@ -41 +41 @@
 
 private:
-    virtual void setCurrentTime(float);
-    virtual float currentTime() const;
+    virtual void setCurrentTime(double);
+    virtual double currentTime() const;
 
-    virtual void setPlayRate(float);
-    virtual float playRate() const;
+    virtual void setPlayRate(double);
+    virtual double playRate() const;
 
     virtual void start();

trunk/Source/WebCore/platform/mac/PlatformClockCM.h

@@ -45 +45 @@
     void initializeWithTimingSource(CMClockRef);
 
-    virtual void setCurrentTime(float);
-    virtual float currentTime() const;
+    virtual void setCurrentTime(double);
+    virtual double currentTime() const;
 
-    virtual void setPlayRate(float);
-    virtual float playRate() const { return m_rate; }
+    virtual void setPlayRate(double);
+    virtual double playRate() const { return m_rate; }
 
     virtual void start();
@@ -56 +56 @@
 
     RetainPtr<CMTimebaseRef> m_timebase;
-    float m_rate;
+    double m_rate;
     bool m_running;
 };

trunk/Source/WebCore/platform/mac/PlatformClockCM.mm

@@ -30 +30 @@
 #import "PlatformClockCM.h"
 
-#import "FloatConversion.h"
 #import "SoftLinking.h"
 #import <CoreMedia/CMAudioDeviceClock.h>
@@ -74 +73 @@
 }
 
-void PlatformClockCM::setCurrentTime(float time)
+void PlatformClockCM::setCurrentTime(double time)
 {
     CMTime cmTime = CMTimeMakeWithSeconds(time, DefaultTimeScale);
@@ -80 +79 @@
 }
 
-float PlatformClockCM::currentTime() const
+double PlatformClockCM::currentTime() const
 {
     CMTime cmTime = CMTimebaseGetTime(m_timebase.get());
-    return narrowPrecisionToFloat(CMTimeGetSeconds(cmTime));
+    return CMTimeGetSeconds(cmTime);
 }
 
-void PlatformClockCM::setPlayRate(float rate)
+void PlatformClockCM::setPlayRate(double rate)
 {
     if (m_rate == rate)