Changeset 148153 in webkit

Timestamp:

Apr 10, 2013 5:00:32 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Bugzilla should show bubbles from webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=114391

Reviewed by Benjamin Poulain.

Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.

• code-review.js:
• template/en/custom/attachment/edit.html.tmpl:
• template/en/custom/attachment/list.html.tmpl:
• template/en/custom/attachment/reviewform.html.tmpl:

Location:

trunk/Websites/bugs.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• code-review.js (modified) (2 diffs)
• template/en/custom/attachment/edit.html.tmpl (modified) (1 diff)
• template/en/custom/attachment/list.html.tmpl (modified) (1 diff)
• template/en/custom/attachment/reviewform.html.tmpl (modified) (1 diff)

trunk/Websites/bugs.webkit.org/ChangeLog

@@ +1 @@
+2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Bugzilla should show bubbles from webkit-queues.appspot.com
+        https://bugs.webkit.org/show_bug.cgi?id=114391
+
+        Reviewed by Benjamin Poulain.
+
+        Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
+
+        * code-review.js:
+        * template/en/custom/attachment/edit.html.tmpl:
+        * template/en/custom/attachment/list.html.tmpl:
+        * template/en/custom/attachment/reviewform.html.tmpl:
+
 2013-03-21  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/bugs.webkit.org/code-review.js

@@ -548 +548 @@
   function handleStatusBubbleLoad(e) {
     e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
+    e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.appspot.com');
   }
 
@@ -577 +578 @@
       statusBubble.className = 'statusBubble';
       statusBubble.src  = 'https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id;
+      statusBubble.scrolling = 'no';
+      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
+      statusBubble.onload = handleStatusBubbleLoad;
+      $('#statusBubbleContainer').append(statusBubble);
+
+      statusBubble = document.createElement('iframe');
+      statusBubble.className = 'statusBubble';
+      statusBubble.src  = 'https://webkit-queues.appspot.com/status-bubble/' + attachment_id;
       statusBubble.scrolling = 'no';
       // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.

trunk/Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl

@@ -263 +263 @@
         <div class="statusBubble">
           <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
+                  style="width: 480px; height: 40px; border: none;" scrolling="no">
+          </iframe>
+          <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
                   style="width: 480px; height: 40px; border: none;" scrolling="no">
           </iframe>

trunk/Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl

@@ -157 +157 @@
           <div class="statusBubble">
             <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
-                    style="width: 600px; height: 20px; border: none;" scrolling="no">
+                    style="width: 450px; height: 20px; border: none;" scrolling="no">
+            </iframe>
+            <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
+                    style="width: 450px; height: 20px; border: none;" scrolling="no">
             </iframe>
           </div>

trunk/Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl

@@ -114 +114 @@
                 style="width: 450px; height: 20px; border: none;" scrolling="no">
         </iframe>
+        <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
+                style="width: 450px; height: 20px; border: none;" scrolling="no">
+        </iframe>
       </div>
     </td>