Changeset 148170 in webkit


Ignore:
Timestamp:
Apr 10, 2013 8:53:24 PM (11 years ago)
Author:
Patrick Gansterer
Message:

Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114351

Reviewed by Ryosuke Niwa.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/OscillatorNode.idl:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r148168 r148170  
     12013-04-10  Patrick Gansterer  <paroga@webkit.org>
     2
     3        Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=114351
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
     9
     10        * Modules/webaudio/AudioBufferSourceNode.idl:
     11        * Modules/webaudio/AudioContext.idl:
     12        * Modules/webaudio/AudioParam.idl:
     13        * Modules/webaudio/OscillatorNode.idl:
     14
    1152013-04-10  Patrick Gansterer  <paroga@webkit.org>
    216
  • trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl

    r147857 r148170  
    5151    void stop(in double when);
    5252
    53 #if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
    54     attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
     53    [Conditional=LEGACY_WEB_AUDIO] attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
    5554
    56     void noteOn(in double when);
    57     void noteGrainOn(in double when, in double grainOffset, in double grainDuration);
    58     void noteOff(in double when);
    59 #endif
     55    [Conditional=LEGACY_WEB_AUDIO] void noteOn(in double when);
     56    [Conditional=LEGACY_WEB_AUDIO] void noteGrainOn(in double when, in double grainOffset, in double grainDuration);
     57    [Conditional=LEGACY_WEB_AUDIO] void noteOff(in double when);
    6058};
  • trunk/Source/WebCore/Modules/webaudio/AudioContext.idl

    r147857 r148170  
    9595    void startRendering();
    9696
    97 #if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
    98     [ImplementedAs=createGain] GainNode createGainNode();
    99     [ImplementedAs=createDelay] DelayNode createDelayNode(in [Optional] double maxDelayTime)
     97    [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createGain] GainNode createGainNode();
     98    [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createDelay] DelayNode createDelayNode(in [Optional] double maxDelayTime)
    10099        raises(DOMException);
    101100
    102     [ImplementedAs=createScriptProcessor] ScriptProcessorNode createJavaScriptNode(in unsigned long bufferSize, in [Optional] unsigned long numberOfInputChannels, in [Optional] unsigned long numberOfOutputChannels)
     101    [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=createScriptProcessor] ScriptProcessorNode createJavaScriptNode(in unsigned long bufferSize, in [Optional] unsigned long numberOfInputChannels, in [Optional] unsigned long numberOfOutputChannels)
    103102        raises(DOMException);
    104 #endif
    105103
    106104};
  • trunk/Source/WebCore/Modules/webaudio/AudioParam.idl

    r147857 r148170  
    5555    void cancelScheduledValues(in float startTime);
    5656
    57 #if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
    58     [ImplementedAs=setTargetAtTime] void setTargetValueAtTime(in float targetValue, in float time, in float timeConstant);
    59 #endif
     57    [Conditional=LEGACY_WEB_AUDIO, ImplementedAs=setTargetAtTime] void setTargetValueAtTime(in float targetValue, in float time, in float timeConstant);
    6058
    6159};
  • trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl

    r138631 r148170  
    5252    void stop(in double when);
    5353
    54 #if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
    55     void noteOn(in double when);
    56     void noteOff(in double when);
    57 #endif
     54    [Conditional=LEGACY_WEB_AUDIO] void noteOn(in double when);
     55    [Conditional=LEGACY_WEB_AUDIO] void noteOff(in double when);
    5856
    5957    void setWaveTable(in WaveTable waveTable);
Note: See TracChangeset for help on using the changeset viewer.