Changeset 148251 in webkit

Timestamp:

Apr 11, 2013 5:08:55 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Unable to paste twice in input field when specific CSS present
​https://bugs.webkit.org/show_bug.cgi?id=108675

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Ryosuke Niwa.

Source/WebCore:

When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
whether the content is clipped by its ancestors or not. This bug was caused
by the fact the plainText() method returned an empty string because the text
was fully clipped by its ancestors. Make plainText ignore style visibility.

Test: editing/inserting/insert-text-into-text-field.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

• editing/inserting/insert-text-into-text-field-expected.txt: Added.
• editing/inserting/insert-text-into-text-field.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/inserting/insert-text-into-text-field-expected.txt (added)
• LayoutTests/editing/inserting/insert-text-into-text-field.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/ReplaceSelectionCommand.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-11  Sukolsak Sakshuwong  <sukolsak@gmail.com>
+
+        Unable to paste twice in input field when specific CSS present
+        https://bugs.webkit.org/show_bug.cgi?id=108675
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/inserting/insert-text-into-text-field-expected.txt: Added.
+        * editing/inserting/insert-text-into-text-field.html: Added.
+
 2013-04-11  Brendan Long  <b.long@cablelabs.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-11  Sukolsak Sakshuwong  <sukolsak@gmail.com>
+
+        Unable to paste twice in input field when specific CSS present
+        https://bugs.webkit.org/show_bug.cgi?id=108675
+
+        Reviewed by Ryosuke Niwa.
+
+        When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
+        whether the content is clipped by its ancestors or not. This bug was caused
+        by the fact the plainText() method returned an empty string because the text
+        was fully clipped by its ancestors. Make plainText ignore style visibility.
+
+        Test: editing/inserting/insert-text-into-text-field.html
+
+        * editing/ReplaceSelectionCommand.cpp:
+        (WebCore::ReplacementFragment::ReplacementFragment):
+
 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp

@@ -175 +175 @@
     
     RefPtr<Range> range = VisibleSelection::selectionFromContentsOfNode(holder.get()).toNormalizedRange();
-    String text = plainText(range.get(), TextIteratorEmitsOriginalText);
+    String text = plainText(range.get(), static_cast<TextIteratorBehavior>(TextIteratorEmitsOriginalText | TextIteratorIgnoresStyleVisibility));
 
     removeInterchangeNodes(holder.get());