Changeset 148310 in webkit


Ignore:
Timestamp:
Apr 12, 2013 4:11:29 PM (11 years ago)
Author:
ap@apple.com
Message:

<rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
https://bugs.webkit.org/show_bug.cgi?id=114541

Reviewed by Brady Eidson.

Test: http/tests/ssl/ping-with-unsafe-redirect.html

  • loader/FrameNetworkingContext.h: (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Added a null check. All NetworkingContext functions except for this one had it already.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r148307 r148310  
     12013-04-12  Alexey Proskuryakov  <ap@apple.com>
     2
     3        <rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
     4        https://bugs.webkit.org/show_bug.cgi?id=114541
     5
     6        Reviewed by Brady Eidson.
     7
     8        * http/tests/ssl/ping-with-unsafe-redirect.html: Added.
     9        * http/tests/ssl/resources/ping-with-unsafe-redirect-frame.html: Added.
     10        * http/tests/ssl/resources/redirect-ping-to-http.php: Added.
     11
    1122013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/Source/WebCore/ChangeLog

    r148306 r148310  
     12013-04-12  Alexey Proskuryakov  <ap@apple.com>
     2
     3        <rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
     4        https://bugs.webkit.org/show_bug.cgi?id=114541
     5
     6        Reviewed by Brady Eidson.
     7
     8        Test: http/tests/ssl/ping-with-unsafe-redirect.html
     9
     10        * loader/FrameNetworkingContext.h:
     11        (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect):
     12        Added a null check. All NetworkingContext functions except for this one had it already.
     13
    1142013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
    215
  • trunk/Source/WebCore/loader/FrameNetworkingContext.h

    r141981 r148310  
    3737    virtual bool shouldClearReferrerOnHTTPSToHTTPRedirect() const
    3838    {
     39        // FIXME: PingLoader finishes without a frame, but it should use its document's referrer policy.
     40        if (!m_frame)
     41            return true;
     42
    3943        return m_frame->document()->referrerPolicy() == ReferrerPolicyDefault;
    4044    }
Note: See TracChangeset for help on using the changeset viewer.