Changeset 148404 in webkit

Timestamp:

Apr 14, 2013 10:56:35 AM (11 years ago)

Author:

akling@apple.com

Message:

Specialize propertyCount() in StylePropertySet subclasses.
<​http://webkit.org/b/114590>

Reviewed by Antti Koivisto.

Avoid branching on m_isMutable in code that already knows which type of set it is.

• css/StylePropertySet.h:

(WebCore::ImmutableStylePropertySet::propertyCount):
(ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::propertyCount):
(MutableStylePropertySet):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StylePropertySet.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-14  Andreas Kling  <akling@apple.com>
+
+        Specialize propertyCount() in StylePropertySet subclasses.
+        <http://webkit.org/b/114590>
+
+        Reviewed by Antti Koivisto.
+
+        Avoid branching on m_isMutable in code that already knows which type of set it is.
+
+        * css/StylePropertySet.h:
+        (WebCore::ImmutableStylePropertySet::propertyCount):
+        (ImmutableStylePropertySet):
+        (WebCore::MutableStylePropertySet::propertyCount):
+        (MutableStylePropertySet):
+
 2013-04-14  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/css/StylePropertySet.h

@@ -183 +183 @@
     static PassRefPtr<ImmutableStylePropertySet> create(const CSSProperty* properties, unsigned count, CSSParserMode);
 
+    unsigned propertyCount() const { return m_arraySize; }
+
     void* m_storage;
 
@@ -207 +209 @@
 
     MutableStylePropertySet(const StylePropertySet&);
+
+    unsigned propertyCount() const { return m_propertyVector.size(); }
 
     void addParsedProperties(const Vector<CSSProperty>&);