Changeset 148539 in webkit

Timestamp:

Apr 16, 2013 1:22:17 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

dfn element should be exposed as AXGroup:AXDefinition
​https://bugs.webkit.org/show_bug.cgi?id=108980

Patch by James Craig <​james@cookiecrook.com> on 2013-04-16
Reviewed by Chris Fleizach.

Source/WebCore:

dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

dfn element now exposed as AXGroup:AXDefinition

• platform/mac/accessibility/role-subrole-roledescription-expected.txt:
• platform/mac/accessibility/role-subrole-roledescription.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-04-16  James Craig  <james@cookiecrook.com>
+
+        dfn element should be exposed as AXGroup:AXDefinition
+        https://bugs.webkit.org/show_bug.cgi?id=108980
+
+        Reviewed by Chris Fleizach.
+
+        dfn element now exposed as AXGroup:AXDefinition
+
+        * platform/mac/accessibility/role-subrole-roledescription-expected.txt:
+        * platform/mac/accessibility/role-subrole-roledescription.html:
+
 2013-04-16  Jochen Eisinger  <jochen@chromium.org>
 

trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt

@@ -81 +81 @@
       
 PASS: dfn
-      AXRole: 
-      AXSubrole: 
-      AXRoleDescription: 
+      AXRole: AXGroup
+      AXSubrole: AXDefinition
+      AXRoleDescription: definition
       
 PASS: dl

trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html

@@ -27 +27 @@
 <del data-role="" data-subrole="" data-roledescription="" class="ex">X</del>
 <!-- skipped <details/summary> http://webkit.org/b/108979 -->
-<!-- <dfn> http://webkit.org/b/108980 --><dfn data-role="" data-subrole="" data-roledescription="" class="ex">X</dfn>
+<dfn data-role="AXGroup" data-subrole="AXDefinition" data-roledescription="definition" class="ex">X</dfn>
 <dl data-role="AXList" data-subrole="AXDescriptionList" data-alternatesubrole="AXDefinitionList" data-roledescription="description list" class="ex">
     <dt data-role="AXGroup" data-subrole="AXTerm" data-roledescription="term" class="ex">X</dt>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-16  James Craig  <james@cookiecrook.com>
+
+        dfn element should be exposed as AXGroup:AXDefinition
+        https://bugs.webkit.org/show_bug.cgi?id=108980
+
+        Reviewed by Chris Fleizach.
+
+        dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
+        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+
 2013-04-16  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -1300 +1300 @@
         return false;
 #endif
+
+    // Other non-ignored host language elements
+    if (node && node->hasTagName(dfnTag))
+        return false;
     
     // By default, objects should be ignored so that the AX hierarchy is not 
@@ -2533 +2537 @@
         return LabelRole;
 
+    if (node && node->hasTagName(dfnTag))
+        return DefinitionRole;
+
     if (node && node->hasTagName(divTag))
         return DivRole;