Changeset 148621 in webkit

Timestamp:

Apr 17, 2013 11:38:04 AM (11 years ago)

Author:

leoyang@rim.com

Message:

Lots of unused parameter warnings in filesystem code
​https://bugs.webkit.org/show_bug.cgi?id=114747

Reviewed by Carlos Garcia Campos.

Comment out or remove unused parameter identifiers.

No functionalities changed, no new tests.

• Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because

it is referred in the comments inside the function.
(WebCore):

• Modules/filesystem/DOMFileSystemSync.cpp: Ditto.

(WebCore):

• Modules/filesystem/FileWriter.cpp: Remove unused |ec|.

(WebCore::FileWriter::abort):

• Modules/filesystem/FileWriterSync.cpp:

(WebCore::FileWriterSync::didWrite): Remove unused |bytes|.

• platform/AsyncFileSystemCallbacks.h:

(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
because the function is inlined.
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
(WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:

(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/filesystem/DOMFileSystem.cpp (modified) (1 diff)
• Modules/filesystem/DOMFileSystemSync.cpp (modified) (1 diff)
• Modules/filesystem/FileWriter.cpp (modified) (1 diff)
• Modules/filesystem/FileWriterSync.cpp (modified) (1 diff)
• platform/AsyncFileSystemCallbacks.h (modified) (2 diffs)
• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-17  Leo Yang  <leoyang@rim.com>
+
+        Lots of unused parameter warnings in filesystem code
+        https://bugs.webkit.org/show_bug.cgi?id=114747
+
+        Reviewed by Carlos Garcia Campos.
+
+        Comment out or remove unused parameter identifiers.
+
+        No functionalities changed, no new tests.
+
+        * Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because
+        it is referred in the comments inside the function.
+        (WebCore):
+        * Modules/filesystem/DOMFileSystemSync.cpp: Ditto.
+        (WebCore):
+        * Modules/filesystem/FileWriter.cpp: Remove unused |ec|.
+        (WebCore::FileWriter::abort):
+        * Modules/filesystem/FileWriterSync.cpp:
+        (WebCore::FileWriterSync::didWrite): Remove unused |bytes|.
+        * platform/AsyncFileSystemCallbacks.h:
+        (WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
+        because the function is inlined.
+        (WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
+        (WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
+        (WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
+        (WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.
+        * platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
+        (WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.
+
 2013-04-17  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebCore/Modules/filesystem/DOMFileSystem.cpp

@@ -156 +156 @@
     }
 
-    virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot)
+    virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> /* snapshot */)
     {
         ASSERT(!metadata.platformPath.isEmpty());

trunk/Source/WebCore/Modules/filesystem/DOMFileSystemSync.cpp

@@ -114 +114 @@
     }
 
-    virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot)
+    virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> /* snapshot */)
     {
         // We can't directly use the snapshot blob data handle because the content type on it hasn't been set.

trunk/Source/WebCore/Modules/filesystem/FileWriter.cpp

@@ -169 +169 @@
 }
 
-void FileWriter::abort(ExceptionCode& ec)
+void FileWriter::abort(ExceptionCode&)
 {
     ASSERT(writer());

trunk/Source/WebCore/Modules/filesystem/FileWriterSync.cpp

@@ -92 +92 @@
 }
 
-void FileWriterSync::didWrite(long long bytes, bool complete)
+void FileWriterSync::didWrite(long long, bool complete)
 {
     ASSERT(m_error == FileError::OK);

trunk/Source/WebCore/platform/AsyncFileSystemCallbacks.h

@@ -51 +51 @@
 
     // Called when a requested file system is opened.
-    virtual void didOpenFileSystem(const String& name, const KURL& rootURL, PassOwnPtr<AsyncFileSystem>) { ASSERT_NOT_REACHED(); }
+    virtual void didOpenFileSystem(const String& /* name */, const KURL& /* rootURL */, PassOwnPtr<AsyncFileSystem>) { ASSERT_NOT_REACHED(); }
 
     // Called when a file metadata is read successfully.
@@ -57 +57 @@
 
     // Called when a snapshot file is created successfully.
-    virtual void didCreateSnapshotFile(const FileMetadata&, PassRefPtr<BlobDataHandle> snapshot) { ASSERT_NOT_REACHED(); }
+    virtual void didCreateSnapshotFile(const FileMetadata&, PassRefPtr<BlobDataHandle> /* snapshot */) { ASSERT_NOT_REACHED(); }
 
     // Called when a directory entry is read.
-    virtual void didReadDirectoryEntry(const String& name, bool isDirectory) { ASSERT_NOT_REACHED(); }
+    virtual void didReadDirectoryEntry(const String& /* name */, bool /* isDirectory */) { ASSERT_NOT_REACHED(); }
 
     // Called after a chunk of directory entries have been read (i.e. indicates it's good time to call back to the application). If hasMore is true there can be more chunks.
-    virtual void didReadDirectoryEntries(bool hasMore) { ASSERT_NOT_REACHED(); }
+    virtual void didReadDirectoryEntries(bool /* hasMore */) { ASSERT_NOT_REACHED(); }
 
     // Called when an AsyncFileWrter has been created successfully.
-    virtual void didCreateFileWriter(PassOwnPtr<AsyncFileWriter>, long long length) { ASSERT_NOT_REACHED(); }
+    virtual void didCreateFileWriter(PassOwnPtr<AsyncFileWriter>, long long /* length */) { ASSERT_NOT_REACHED(); }
 
     // Called when there was an error.

trunk/Source/WebCore/platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp

@@ -120 +120 @@
 }
 
-void WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread(ScriptExecutionContext*, WebFileSystem* platformFileSystem, AsyncFileWriterClient* client, const KURL& path, WorkerPlatformAsyncFileSystemCallbacks* callbacks)
+void WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread(ScriptExecutionContext*, WebFileSystem* platformFileSystem, AsyncFileWriterClient*, const KURL& path, WorkerPlatformAsyncFileSystemCallbacks* callbacks)
 {
     WebFileWriter::createWriter(platformFileSystem, fileSystemURLToPath(path).utf8().data(), callbacks);