Changeset 148676 in webkit

Timestamp:

Apr 18, 2013 7:30:25 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

remove build warning(unused parameter)
​https://bugs.webkit.org/show_bug.cgi?id=114670

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.

remove build warning in Source/WebKit/blackberry/Api

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):

• Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::clearAppCache):
(BlackBerry::WebKit::clearDatabase):

• Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setCaretHighlightStyle):

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::cleanup):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/BackingStore.cpp (modified) (5 diffs)
• Api/BlackBerryGlobal.cpp (modified) (1 diff)
• Api/WebOverlay.cpp (modified) (4 diffs)
• Api/WebPage.cpp (modified) (1 diff)
• Api/WebPageCompositor.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/BackingStore.cpp

@@ -494 +494 @@
 }
 
-void BackingStorePrivate::scroll(const Platform::IntSize& delta,
-                                 const Platform::IntRect& scrollViewRect,
-                                 const Platform::IntRect& clipRect)
+void BackingStorePrivate::scroll(const Platform::IntSize& delta, const Platform::IntRect&, const Platform::IntRect&)
 {
     ASSERT(BlackBerry::Platform::webKitThreadMessageClient()->isCurrentThread());
@@ -886 +884 @@
 }
 
-void BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion(const TileIndex& index, TileBuffer* tileBuffer,
+void BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion(const TileIndex&, TileBuffer* tileBuffer,
                                                                 const Platform::IntRectRegion& tileNotRenderedRegion,
-                                                                BackingStoreGeometry* geometry,
+                                                                BackingStoreGeometry*,
                                                                 bool update)
 {
@@ -1124 +1122 @@
 }
 
-void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool flush)
+void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool)
 {
     Platform::IntRect clippedDstRect = dstRect;
@@ -1480 +1478 @@
     const Platform::IntPoint& origin,
     const WebCore::TransformationMatrix& matrix,
-    BackingStoreGeometry* geometry)
+    BackingStoreGeometry*)
 {
     if (!m_webPage->isVisible() || !isActive() || !tileBuffer)
@@ -1733 +1731 @@
 }
 
-void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize& size)
+void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize&)
 {
 }

trunk/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp

@@ -138 +138 @@
 }
 
-void clearAppCache(const BlackBerry::Platform::String& pageGroupName)
+void clearAppCache(const BlackBerry::Platform::String&)
 {
     cacheStorage().empty();
 }
 
-void clearDatabase(const BlackBerry::Platform::String& pageGroupName)
+void clearDatabase(const BlackBerry::Platform::String&)
 {
 }

trunk/Source/WebKit/blackberry/Api/WebOverlay.cpp

@@ -341 +341 @@
 }
 
-void WebOverlayPrivateWebKitThread::setContentsToImage(const unsigned char* data, const WebCore::IntSize& imageSize, WebOverlay::ImageDataAdoptionType adoptionType)
+void WebOverlayPrivateWebKitThread::setContentsToImage(const unsigned char*, const WebCore::IntSize&, WebOverlay::ImageDataAdoptionType)
 {
     notImplemented();
@@ -430 +430 @@
 }
 
-void WebOverlayLayerCompositingThreadClient::layerVisibilityChanged(LayerCompositingThread*, bool visible)
+void WebOverlayLayerCompositingThreadClient::layerVisibilityChanged(LayerCompositingThread*, bool)
 {
 }
@@ -502 +502 @@
 }
 
-void WebOverlayLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program& program)
+void WebOverlayLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program&)
 {
     if (!m_texture || !m_texture->buffer())
@@ -654 +654 @@
 }
 
-void WebOverlayPrivateCompositingThread::setContentsToImage(const unsigned char* data, const IntSize& imageSize, WebOverlay::ImageDataAdoptionType adoptionType)
+void WebOverlayPrivateCompositingThread::setContentsToImage(const unsigned char* data, const IntSize& imageSize, WebOverlay::ImageDataAdoptionType)
 {
     if (!m_layerCompositingThreadClient)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -3265 +3265 @@
 }
 
-void WebPage::setCaretHighlightStyle(Platform::CaretHighlightStyle style)
+void WebPage::setCaretHighlightStyle(Platform::CaretHighlightStyle)
 {
 }

trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp

@@ -335 +335 @@
 }
 
-void WebPageCompositor::cleanup(Platform::Graphics::GLES2Context* context)
+void WebPageCompositor::cleanup(Platform::Graphics::GLES2Context*)
 {
     d->setContext(0);

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-04-18  Xuefei Ren  <xren@blackberry.com>
+
+        remove build warning(unused parameter)
+        https://bugs.webkit.org/show_bug.cgi?id=114670
+
+        Reviewed by Rob Buis.
+
+        remove build warning in Source/WebKit/blackberry/Api
+
+        * Api/BackingStore.cpp:
+        (BlackBerry::WebKit::BackingStorePrivate::scroll):
+        (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
+        (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
+        (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
+        (BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
+        * Api/BlackBerryGlobal.cpp:
+        (BlackBerry::WebKit::clearAppCache):
+        (BlackBerry::WebKit::clearDatabase):
+        * Api/WebOverlay.cpp:
+        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
+        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
+        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
+        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
+        * Api/WebPageCompositor.cpp:
+        (BlackBerry::WebKit::WebPageCompositor::cleanup):
+
 2013-04-18  Xuefei Ren  <xren@blackberry.com>