Changeset 148678 in webkit


Ignore:
Timestamp:
Apr 18, 2013 8:01:32 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

remove build warning(unused parameter)
​https://bugs.webkit.org/show_bug.cgi?id=114670

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.

Source/JavaScriptCore:

remove warning in Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp

  • runtime/GCActivityCallbackBlackBerry.cpp:

(JSC::DefaultGCActivityCallback::didAllocate):

Source/WebCore:

remove warning(unused parameter) in
Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp
Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp
Source/WebCore/platform/blackberry/AuthenticationChallengeManager.cpp
Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp
Source/WebCore/platform/network/blackberry/ResourceResponseBlackBerry.cpp
Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp
Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp

  • html/shadow/MediaControlsBlackBerry.cpp:

(WebCore::MediaControlFullscreenFullscreenButtonElement::setIsFullscreen):

  • loader/blackberry/CookieJarBlackBerry.cpp:

(WebCore::getRawCookies):
(WebCore::deleteCookie):

  • platform/blackberry/AuthenticationChallengeManager.cpp:

(WebCore::AuthenticationChallengeManager::notifyChallengeResult):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderTheme::themeForPage):

  • platform/network/blackberry/ResourceResponseBlackBerry.cpp:

(WebCore::ResourceResponse::doPlatformAdopt):

  • platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::notifyStatusReceived):

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::invalidateRegion):

Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r148663 r148678  
     12013-04-18  Xuefei Ren  <xren@blackberry.com>
     2
     3        remove build warning(unused parameter)
     4        https://bugs.webkit.org/show_bug.cgi?id=114670
     5
     6        Reviewed by Rob Buis.
     7
     8        remove warning in Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp
     9
     10        * runtime/GCActivityCallbackBlackBerry.cpp:
     11        (JSC::DefaultGCActivityCallback::didAllocate):
     12
    1132013-04-18  Jonathan Liu  <net147@gmail.com>
    214

  • trunk/Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp

    r146502 r148678  
    3737}
    3838
    39 void DefaultGCActivityCallback::didAllocate(size_t bytesAllocated)
     39void DefaultGCActivityCallback::didAllocate(size_t)
    4040{
    4141    if (m_timer.started())

  • trunk/Source/WebCore/ChangeLog

    r148677 r148678  
     12013-04-18  Xuefei Ren  <xren@blackberry.com>
     2
     3        remove build warning(unused parameter)
     4        https://bugs.webkit.org/show_bug.cgi?id=114670
     5
     6        Reviewed by Rob Buis.
     7
     8        remove warning(unused parameter) in
     9        Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp
     10        Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp
     11        Source/WebCore/platform/blackberry/AuthenticationChallengeManager.cpp
     12        Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp
     13        Source/WebCore/platform/network/blackberry/ResourceResponseBlackBerry.cpp
     14        Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp
     15        Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp
     16
     17
     18        * html/shadow/MediaControlsBlackBerry.cpp:
     19        (WebCore::MediaControlFullscreenFullscreenButtonElement::setIsFullscreen):
     20        * loader/blackberry/CookieJarBlackBerry.cpp:
     21        (WebCore::getRawCookies):
     22        (WebCore::deleteCookie):
     23        * platform/blackberry/AuthenticationChallengeManager.cpp:
     24        (WebCore::AuthenticationChallengeManager::notifyChallengeResult):
     25        * platform/blackberry/RenderThemeBlackBerry.cpp:
     26        (WebCore::RenderTheme::themeForPage):
     27        * platform/network/blackberry/ResourceResponseBlackBerry.cpp:
     28        (WebCore::ResourceResponse::doPlatformAdopt):
     29        * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
     30        (WebCore::SocketStreamHandle::notifyStatusReceived):
     31        * plugins/blackberry/PluginViewBlackBerry.cpp:
     32        (WebCore::PluginView::invalidateRegion):
     33
    1342013-04-18  Xuefei Ren  <xren@blackberry.com>
    235

  • trunk/Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp

    r148099 r148678  
    445445}
    446446
    447 void MediaControlFullscreenFullscreenButtonElement::setIsFullscreen(bool isFullscreen)
     447void MediaControlFullscreenFullscreenButtonElement::setIsFullscreen(bool)
    448448{
    449449    setDisplayType(MediaExitFullscreenButton);

  • trunk/Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp

    r145163 r148678  
    5858}
    5959
    60 bool getRawCookies(const Document* document, const KURL& url, Vector<Cookie>& rawCookies)
     60bool getRawCookies(const Document*, const KURL& url, Vector<Cookie>& rawCookies)
    6161{
    6262    // Note: this method is called by inspector only. No need to check if cookie is enabled.
    … …  
    6868}
    6969
    70 void deleteCookie(const Document* document, const KURL& url, const String& cookieName)
     70void deleteCookie(const Document*, const KURL& url, const String& cookieName)
    7171{
    7272    // Cookies are not bound to the document. Therefore, we don't need to pass

  • trunk/Source/WebCore/platform/blackberry/AuthenticationChallengeManager.cpp

    r143740 r148678  
    197197}
    198198
    199 void AuthenticationChallengeManager::notifyChallengeResult(const KURL& url, const ProtectionSpace& space,
     199void AuthenticationChallengeManager::notifyChallengeResult(const KURL&, const ProtectionSpace& space,
    200200    AuthenticationChallengeResult result, const Credential& credential)
    201201{

  • trunk/Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp

    r148189 r148678  
    215215}
    216216
    217 PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page* page)
     217PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*)
    218218{
    219219    static RenderTheme* theme = RenderThemeBlackBerry::create().leakRef();

  • trunk/Source/WebCore/platform/network/blackberry/ResourceResponseBlackBerry.cpp

    r112092 r148678  
    2727}
    2828
    29 void ResourceResponse::doPlatformAdopt(PassOwnPtr<CrossThreadResourceResponseData> data)
     29void ResourceResponse::doPlatformAdopt(PassOwnPtr<CrossThreadResourceResponseData>)
    3030{
    3131}

  • trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp

    r147915 r148678  
    9898// FilterStream interface
    9999
    100 void SocketStreamHandle::notifyStatusReceived(int status, const BlackBerry::Platform::String& message)
     100void SocketStreamHandle::notifyStatusReceived(int status, const BlackBerry::Platform::String&)
    101101{
    102102    ASSERT(m_client);

  • trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp

    r147654 r148678  
    10471047}
    10481048
    1049 void PluginView::invalidateRegion(NPRegion region)
     1049void PluginView::invalidateRegion(NPRegion)
    10501050{
    10511051    invalidate();
Note: See TracChangeset for help on using the changeset viewer.