Changeset 148712 in webkit
- Timestamp:
- Apr 18, 2013 4:32:20 PM (11 years ago)
- Location:
- trunk/Source
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r148708 r148712 1 2013-04-18 Andy Estes <aestes@apple.com> 2 3 REGRESSION (r116645): Versions app's UI is munged in HiDPI due to background-size being reset to 'auto' when background short-hand is also specified 4 https://bugs.webkit.org/show_bug.cgi?id=114833 5 6 Reviewed by David Kilzer. 7 8 Added applicationIsVersions() to RuntimeApplicationChecks. 9 10 * WebCore.exp.in: 11 * platform/RuntimeApplicationChecks.cpp: 12 (WebCore::applicationIsVersions): 13 (WebCore): 14 * platform/RuntimeApplicationChecks.h: 15 (WebCore): 16 1 17 2013-04-18 Sam Weinig <sam@webkit.org> 2 18 -
trunk/Source/WebCore/WebCore.exp.in
r148696 r148712 1800 1800 __ZN7WebCore21DeviceOrientationData6createEbdbdbdbb 1801 1801 __ZN7WebCore21applicationIsApertureEv 1802 __ZN7WebCore21applicationIsVersionsEv 1802 1803 __ZN7WebCore21reportThreadViolationEPKcNS_20ThreadViolationRoundE 1803 1804 __ZN7WebCore22applicationIsAppleMailEv -
trunk/Source/WebCore/platform/RuntimeApplicationChecks.cpp
r132916 r148712 103 103 } 104 104 105 bool applicationIsVersions() 106 { 107 static bool isVersions = mainBundleIsEqualTo("com.blackpixel.versions"); 108 return isVersions; 109 } 110 105 111 } // namespace WebCore -
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
r96205 r148712 37 37 bool applicationIsMicrosoftOutlook(); 38 38 bool applicationIsSafari(); 39 bool applicationIsVersions(); 39 40 40 41 } // namespace WebCore -
trunk/Source/WebKit/mac/ChangeLog
r148708 r148712 1 2013-04-18 Andy Estes <aestes@apple.com> 2 3 REGRESSION (r116645): Versions app's UI is munged in HiDPI due to background-size being reset to 'auto' when background short-hand is also specified 4 https://bugs.webkit.org/show_bug.cgi?id=114833 5 6 Reviewed by David Kilzer. 7 8 The Versions app specifies both a background-size and a background 9 shorthand CSS property, and its UI is broken after r116645 which resets 10 background-size to 'auto' if the background shorthand property is 11 specified. 12 13 This patch enables the useLegacyBackgroundSizeShorthandBehavior setting 14 added in r147034 to restore the expected behavior if the embedder is 15 Versions.app and it was linked against a version of WebKit that had the 16 legacy behavior. 17 18 * Misc/WebKitVersionChecks.h: 19 * WebView/WebView.mm: 20 (shouldUseLegacyBackgroundSizeShorthandBehavior): 21 (-[WebView _commonInitializationWithFrameName:groupName:]): 22 1 23 2013-04-18 Sam Weinig <sam@webkit.org> 2 24 -
trunk/Source/WebKit/mac/Misc/WebKitVersionChecks.h
r118086 r148712 59 59 #define WEBKIT_FIRST_VERSION_WITH_CORRECT_DID_FINISH_LOAD_ORDER 0x02170304 // 535.3.4 60 60 #define WEBKIT_FIRST_VERSION_WITH_CSS_ATTRIBUTE_SETTERS_IGNORING_PRIORITY 0x02170D00 // 535.13.0 61 #define WEBKIT_FIRST_VERSION_WITHOUT_LEGACY_BACKGROUNDSIZE_SHORTHAND_BEHAVIOR 0x02190100 // 537.1.0 61 62 62 63 #ifdef __cplusplus -
trunk/Source/WebKit/mac/WebView/WebView.mm
r148590 r148712 674 674 } 675 675 676 static bool shouldUseLegacyBackgroundSizeShorthandBehavior() 677 { 678 static bool shouldUseLegacyBackgroundSizeShorthandBehavior = applicationIsVersions() 679 && !WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITHOUT_LEGACY_BACKGROUNDSIZE_SHORTHAND_BEHAVIOR); 680 return shouldUseLegacyBackgroundSizeShorthandBehavior; 681 } 682 676 683 - (void)_commonInitializationWithFrameName:(NSString *)frameName groupName:(NSString *)groupName 677 684 { … … 744 751 _private->page->setCanStartMedia([self window]); 745 752 _private->page->settings()->setLocalStorageDatabasePath([[self preferences] _localStorageDatabasePath]); 753 _private->page->settings()->setUseLegacyBackgroundSizeShorthandBehavior(shouldUseLegacyBackgroundSizeShorthandBehavior()); 746 754 747 755 if (needsOutlookQuirksScript()) {
Note: See TracChangeset
for help on using the changeset viewer.