Changeset 148731 in webkit


Ignore:
Timestamp:
Apr 19, 2013 1:40:55 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Remove unmaintained feature REQUEST_AUTOCOMPLETE
https://bugs.webkit.org/show_bug.cgi?id=114846

Patch by Dan Beam <dbeam@chromium.org> on 2013-04-19
Reviewed by Kent Tamura.

Source/WebCore:

  • GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include.
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore): Remove requestAutocomplete() runtime feature.

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature.

  • dom/AutocompleteErrorEvent.h: Removed.
  • dom/AutocompleteErrorEvent.idl: Removed.
  • dom/EventNames.h: Remove autocomplete and autocompleteerror event names.

(WebCore):

  • dom/EventNames.in: Remove autocomplete and autocompleteerror event names.
  • html/HTMLAttributeNames.in: Remove onautocomplete and onautocompleteerror form attributes.
  • html/HTMLFormElement.cpp: Remove requestAutocomplete() related code.

(WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events.
(WebCore::HTMLFormElement::parseAttribute): Remove parsing of onautocomplete and onautocompleterror.

  • html/HTMLFormElement.h: Remove requestAutocomplete() related members.

(HTMLFormElement):

  • html/HTMLFormElement.idl: Remove public requestAutocomplete() API method.
  • loader/EmptyClients.cpp: Remove stub implementation.

(WebCore):

  • loader/EmptyClients.h: Remove stub interface.

(EmptyFrameLoaderClient):

  • loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface.

(FrameLoaderClient):

  • page/DOMWindow.idl: Remove AutocompleteErrorEvent from window DOM interface.

Source/WTF:

  • wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition.

LayoutTests:

  • fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed.
  • fast/events/constructors/autocomplete-error-event-constructor.html: Removed.
  • fast/events/event-creation.html: Remove AutocompleteErrorEvent test code.
  • fast/forms/form-request-autocomplete-expected.txt: Removed.
  • fast/forms/form-request-autocomplete.html: Removed.
  • fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code.
  • fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor.
  • platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations.
  • platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations.
  • platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations.
  • platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations.
Location:
trunk
Files:
6 deleted
24 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r148723 r148731  
     12013-04-19  Dan Beam  <dbeam@chromium.org>
     2
     3        Remove unmaintained feature REQUEST_AUTOCOMPLETE
     4        https://bugs.webkit.org/show_bug.cgi?id=114846
     5
     6        Reviewed by Kent Tamura.
     7
     8        * fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed.
     9        * fast/events/constructors/autocomplete-error-event-constructor.html: Removed.
     10        * fast/events/event-creation.html: Remove AutocompleteErrorEvent test code.
     11        * fast/forms/form-request-autocomplete-expected.txt: Removed.
     12        * fast/forms/form-request-autocomplete.html: Removed.
     13        * fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code.
     14        * fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor.
     15        * platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations.
     16        * platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations.
     17        * platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations.
     18        * platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations.
     19
    1202013-04-18  Timothy Hatcher  <timothy@apple.com>
    221
  • trunk/LayoutTests/fast/events/event-creation.html

    r141578 r148731  
    228228    // shouldBeTrue("document.createEvent('OrientationEvent') instanceof window.Event");
    229229    // shouldBeTrue("document.createEvent('OrientationEvent').constructor === window.Event");
    230 
    231     // #if ENABLE(REQUEST_AUTOCOMPLETE)
    232     // AutocompleteErrorEvent
    233     // shouldBeTrue("document.createEvent('AutocompleteErrorEvent') instanceof window.AutocompleteErrorEvent");
    234     // shouldBeTrue("document.createEvent('AutocompleteErrorEvent') instanceof window.Event");
    235     // shouldBeTrue("document.createEvent('AutocompleteErrorEvent').constructor === window.AutocompleteErrorEvent");
    236230
    237231    // We test both a hard coded set and the automated set below (using enumeration) to ensure that a constructor being removed
  • trunk/LayoutTests/fast/js/constructor-length.html

    r139372 r148731  
    1010shouldBe('ArrayBuffer.length', '1');
    1111shouldBe('AudioContext.length', '0');
    12 shouldBe('AutocompleteErrorEvent.length', '2');
    1312shouldBe('BeforeLoadEvent.length', '2');
    1413shouldBe('Blob.length', '2');
  • trunk/LayoutTests/fast/js/script-tests/global-constructors.js

    r139372 r148731  
    4040        name == "Float64Array" ||
    4141        name == "FileError" ||
    42         name == "FileReader" ||
    43         name == "AutocompleteErrorEvent")
     42        name == "FileReader")
    4443        continue;
    4544
  • trunk/LayoutTests/platform/blackberry/fast/js/constructor-length-expected.txt

    r139372 r148731  
    66PASS ArrayBuffer.length is 1
    77FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext
    8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent
    98PASS BeforeLoadEvent.length is 2
    109PASS Blob.length is 2
  • trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt

    r139372 r148731  
    66PASS ArrayBuffer.length is 1
    77FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext
    8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent
    98PASS BeforeLoadEvent.length is 2
    109PASS Blob.length is 2
  • trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt

    r139372 r148731  
    66PASS ArrayBuffer.length is 1
    77FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext
    8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent
    98PASS BeforeLoadEvent.length is 2
    109PASS Blob.length is 2
  • trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt

    r139372 r148731  
    66PASS ArrayBuffer.length is 1
    77FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext
    8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent
    98PASS BeforeLoadEvent.length is 2
    109PASS Blob.length is 2
  • trunk/Source/WTF/ChangeLog

    r148684 r148731  
     12013-04-19  Dan Beam  <dbeam@chromium.org>
     2
     3        Remove unmaintained feature REQUEST_AUTOCOMPLETE
     4        https://bugs.webkit.org/show_bug.cgi?id=114846
     5
     6        Reviewed by Kent Tamura.
     7
     8        * wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition.
     9
    1102013-04-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
    211
  • trunk/Source/WTF/wtf/FeatureDefines.h

    r148093 r148731  
    716716#endif
    717717
    718 #if !defined(ENABLE_REQUEST_AUTOCOMPLETE)
    719 #define ENABLE_REQUEST_AUTOCOMPLETE 0
    720 #endif
    721 
    722718#if !defined(ENABLE_RUBBER_BANDING)
    723719#define ENABLE_RUBBER_BANDING 0
  • trunk/Source/WebCore/ChangeLog

    r148723 r148731  
     12013-04-19  Dan Beam  <dbeam@chromium.org>
     2
     3        Remove unmaintained feature REQUEST_AUTOCOMPLETE
     4        https://bugs.webkit.org/show_bug.cgi?id=114846
     5
     6        Reviewed by Kent Tamura.
     7
     8        * GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include.
     9        * bindings/generic/RuntimeEnabledFeatures.cpp:
     10        (WebCore): Remove requestAutocomplete() runtime feature.
     11        * bindings/generic/RuntimeEnabledFeatures.h:
     12        (RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature.
     13        * dom/AutocompleteErrorEvent.h: Removed.
     14        * dom/AutocompleteErrorEvent.idl: Removed.
     15        * dom/EventNames.h: Remove `autocomplete` and `autocompleteerror` event names.
     16        (WebCore):
     17        * dom/EventNames.in: Remove `autocomplete` and `autocompleteerror` event names.
     18        * html/HTMLAttributeNames.in: Remove `onautocomplete` and `onautocompleteerror` form attributes.
     19        * html/HTMLFormElement.cpp: Remove requestAutocomplete() related code.
     20        (WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events.
     21        (WebCore::HTMLFormElement::parseAttribute): Remove parsing of `onautocomplete` and `onautocompleterror`.
     22        * html/HTMLFormElement.h: Remove requestAutocomplete() related members.
     23        (HTMLFormElement):
     24        * html/HTMLFormElement.idl: Remove public requestAutocomplete() API method.
     25        * loader/EmptyClients.cpp: Remove stub implementation.
     26        (WebCore):
     27        * loader/EmptyClients.h: Remove stub interface.
     28        (EmptyFrameLoaderClient):
     29        * loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface.
     30        (FrameLoaderClient):
     31        * page/DOMWindow.idl: Remove `AutocompleteErrorEvent` from window DOM interface.
     32
    1332013-04-18  Timothy Hatcher  <timothy@apple.com>
    234
  • trunk/Source/WebCore/GNUmakefile.list.am

    r148569 r148731  
    27832783        Source/WebCore/dom/Attr.h \
    27842784        Source/WebCore/dom/Attribute.h \
    2785         Source/WebCore/dom/AutocompleteErrorEvent.h \
    27862785        Source/WebCore/dom/BeforeLoadEvent.h \
    27872786        Source/WebCore/dom/BeforeTextInsertedEvent.cpp \
  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r147917 r148731  
    232232#endif
    233233
    234 #if ENABLE(REQUEST_AUTOCOMPLETE)
    235 bool RuntimeEnabledFeatures::isRequestAutocompleteEnabled = false;
    236 #endif
    237 
    238234#if ENABLE(CSP_NEXT)
    239235bool RuntimeEnabledFeatures::areExperimentalContentSecurityPolicyFeaturesEnabled = false;
  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r146847 r148731  
    299299    static void setLangAttributeAwareFormControlUIEnabled(bool isEnabled) { isLangAttributeAwareFormControlUIEnabled = isEnabled; }
    300300
    301 #if ENABLE(REQUEST_AUTOCOMPLETE)
    302     static bool requestAutocompleteEnabled() { return isRequestAutocompleteEnabled; }
    303     static void setRequestAutocompleteEnabled(bool isEnabled) { isRequestAutocompleteEnabled = isEnabled; }
    304 #endif
    305 
    306301private:
    307302    // Never instantiate.
     
    411406#endif
    412407
    413 #if ENABLE(REQUEST_AUTOCOMPLETE)
    414     static bool isRequestAutocompleteEnabled;
    415 #endif
    416 
    417408#if ENABLE(CSP_NEXT)
    418409    static bool areExperimentalContentSecurityPolicyFeaturesEnabled;
  • trunk/Source/WebCore/dom/EventNames.h

    r146582 r148731  
    251251    macro(webkitdeviceproximity) \
    252252    \
    253     macro(autocomplete) \
    254     macro(autocompleteerror) \
    255     \
    256253    macro(webkitprerenderstart) \
    257254    macro(webkitprerenderstop) \
  • trunk/Source/WebCore/dom/EventNames.in

    r147857 r148731  
    5656MediaKeyNeededEvent conditional=ENCRYPTED_MEDIA_V2
    5757TrackEvent conditional=VIDEO_TRACK
    58 AutocompleteErrorEvent conditional=REQUEST_AUTOCOMPLETE
    5958CSSFontFaceLoadEvent conditional=FONT_LOAD_EVENTS
    6059SecurityPolicyViolationEvent conditional=CSP_NEXT
  • trunk/Source/WebCore/html/HTMLAttributeNames.in

    r145932 r148731  
    170170object
    171171onabort
    172 onautocomplete
    173 onautocompleteerror
    174172onbeforecopy
    175173onbeforecut
  • trunk/Source/WebCore/html/HTMLFormElement.cpp

    r148373 r148731  
    2727
    2828#include "Attribute.h"
    29 #include "AutocompleteErrorEvent.h"
    3029#include "DOMFormData.h"
    3130#include "DOMWindow.h"
     
    7877    , m_isInResetFunction(false)
    7978    , m_wasDemoted(false)
    80 #if ENABLE(REQUEST_AUTOCOMPLETE)
    81     , m_requestAutocompleteTimer(this, &HTMLFormElement::requestAutocompleteTimerFired)
    82 #endif
    8379{
    8480    ASSERT(hasTagName(formTag));
     
    393389    m_isInResetFunction = false;
    394390}
    395 
    396 #if ENABLE(REQUEST_AUTOCOMPLETE)
    397 void HTMLFormElement::requestAutocomplete()
    398 {
    399     Frame* frame = document()->frame();
    400     if (!frame)
    401         return;
    402 
    403     if (!shouldAutocomplete() || !ScriptController::processingUserGesture()) {
    404         finishRequestAutocomplete(AutocompleteResultErrorDisabled);
    405         return;
    406     }
    407 
    408     StringPairVector controlNamesAndValues;
    409     getTextFieldValues(controlNamesAndValues);
    410     RefPtr<FormState> formState = FormState::create(this, controlNamesAndValues, document(), SubmittedByJavaScript);
    411     frame->loader()->client()->didRequestAutocomplete(formState.release());
    412 }
    413 
    414 void HTMLFormElement::finishRequestAutocomplete(AutocompleteResult result)
    415 {
    416     RefPtr<Event> event;
    417     if (result == AutocompleteResultSuccess)
    418         event = Event::create(eventNames().autocompleteEvent, false, false);
    419     else if (result == AutocompleteResultErrorDisabled)
    420         event = AutocompleteErrorEvent::create("disabled");
    421     else if (result == AutocompleteResultErrorCancel)
    422         event = AutocompleteErrorEvent::create("cancel");
    423     else if (result == AutocompleteResultErrorInvalid)
    424         event = AutocompleteErrorEvent::create("invalid");
    425 
    426     event->setTarget(this);
    427     m_pendingAutocompleteEvents.append(event.release());
    428 
    429     // Dispatch events later as this API is meant to work asynchronously in all situations and implementations.
    430     if (!m_requestAutocompleteTimer.isActive())
    431         m_requestAutocompleteTimer.startOneShot(0);
    432 }
    433 
    434 void HTMLFormElement::requestAutocompleteTimerFired(Timer<HTMLFormElement>*)
    435 {
    436     Vector<RefPtr<Event> > pendingEvents;
    437     m_pendingAutocompleteEvents.swap(pendingEvents);
    438     for (size_t i = 0; i < pendingEvents.size(); ++i)
    439         dispatchEvent(pendingEvents[i].release());
    440 }
    441 #endif
    442391
    443392void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
     
    459408            document()->unregisterForPageCacheSuspensionCallbacks(this);
    460409    }
    461 #if ENABLE(REQUEST_AUTOCOMPLETE)
    462     else if (name == onautocompleteAttr)
    463         setAttributeEventListener(eventNames().autocompleteEvent, createAttributeEventListener(this, name, value));
    464     else if (name == onautocompleteerrorAttr)
    465         setAttributeEventListener(eventNames().autocompleteerrorEvent, createAttributeEventListener(this, name, value));
    466 #endif
    467410    else
    468411        HTMLElement::parseAttribute(name, value);
  • trunk/Source/WebCore/html/HTMLFormElement.h

    r139545 r148731  
    9999    bool checkValidity();
    100100
    101 #if ENABLE(REQUEST_AUTOCOMPLETE)
    102     enum AutocompleteResult {
    103         AutocompleteResultSuccess,
    104         AutocompleteResultErrorDisabled,
    105         AutocompleteResultErrorCancel,
    106         AutocompleteResultErrorInvalid,
    107     };
    108 
    109     void requestAutocomplete();
    110     void finishRequestAutocomplete(AutocompleteResult);
    111 
    112     DEFINE_ATTRIBUTE_EVENT_LISTENER(autocomplete);
    113     DEFINE_ATTRIBUTE_EVENT_LISTENER(autocompleteerror);
    114 #endif
    115 
    116101    HTMLFormControlElement* elementForAlias(const AtomicString&);
    117102    void addElementAlias(HTMLFormControlElement*, const AtomicString& alias);
     
    177162
    178163    bool m_wasDemoted;
    179 
    180 #if ENABLE(REQUEST_AUTOCOMPLETE)
    181     void requestAutocompleteTimerFired(Timer<HTMLFormElement>*);
    182 
    183     Vector<RefPtr<Event> > m_pendingAutocompleteEvents;
    184     Timer<HTMLFormElement> m_requestAutocompleteTimer;
    185 #endif
    186164};
    187165
  • trunk/Source/WebCore/html/HTMLFormElement.idl

    r147857 r148731  
    4343    void reset();
    4444    boolean checkValidity();
    45 
    46 #if defined(ENABLE_REQUEST_AUTOCOMPLETE) && ENABLE_REQUEST_AUTOCOMPLETE
    47     void requestAutocomplete();
    48     [NotEnumerable] attribute EventListener onautocomplete;
    49     [NotEnumerable] attribute EventListener onautocompleteerror;
    50 #endif
    5145};
  • trunk/Source/WebCore/loader/EmptyClients.cpp

    r142549 r148731  
    185185#endif
    186186
    187 #if ENABLE(REQUEST_AUTOCOMPLETE)
    188 void EmptyFrameLoaderClient::didRequestAutocomplete(PassRefPtr<FormState>)
    189 {
    190187}
    191 #endif
    192 
    193 }
  • trunk/Source/WebCore/loader/EmptyClients.h

    r147857 r148731  
    374374
    375375    virtual PassRefPtr<FrameNetworkingContext> createNetworkingContext() OVERRIDE;
    376 
    377 #if ENABLE(REQUEST_AUTOCOMPLETE)
    378     virtual void didRequestAutocomplete(PassRefPtr<FormState>) OVERRIDE;
    379 #endif
    380376};
    381377
  • trunk/Source/WebCore/loader/FrameLoaderClient.h

    r147857 r148731  
    338338#endif
    339339
    340 #if ENABLE(REQUEST_AUTOCOMPLETE)
    341         virtual void didRequestAutocomplete(PassRefPtr<FormState>) = 0;
    342 #endif
    343 
    344340#if ENABLE(WEBGL)
    345341        virtual bool allowWebGL(bool enabledPerSettings) { return enabledPerSettings; }
  • trunk/Source/WebCore/page/DOMWindow.idl

    r148593 r148731  
    567567    [Conditional=WEBGL] attribute WebGLContextEventConstructor WebGLContextEvent;
    568568    [Conditional=PROXIMITY_EVENTS] attribute DeviceProximityEventConstructor DeviceProximityEvent;
    569     [Conditional=REQUEST_AUTOCOMPLETE] attribute AutocompleteErrorEventConstructor AutocompleteErrorEvent;
    570569    [Conditional=CSP_NEXT] attribute SecurityPolicyViolationEventConstructor SecurityPolicyViolationEvent;
    571570
Note: See TracChangeset for help on using the changeset viewer.