Changeset 148731 in webkit
- Timestamp:
- Apr 19, 2013 1:40:55 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 6 deleted
- 24 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r148723 r148731 1 2013-04-19 Dan Beam <dbeam@chromium.org> 2 3 Remove unmaintained feature REQUEST_AUTOCOMPLETE 4 https://bugs.webkit.org/show_bug.cgi?id=114846 5 6 Reviewed by Kent Tamura. 7 8 * fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Removed. 9 * fast/events/constructors/autocomplete-error-event-constructor.html: Removed. 10 * fast/events/event-creation.html: Remove AutocompleteErrorEvent test code. 11 * fast/forms/form-request-autocomplete-expected.txt: Removed. 12 * fast/forms/form-request-autocomplete.html: Removed. 13 * fast/js/constructor-length.html: Remove AutocompleteErrorEvent test code. 14 * fast/js/script-tests/global-constructors.js: Remove AutocompleteErrorEvent constructor. 15 * platform/blackberry/fast/js/constructor-length-expected.txt: Remove test expectations. 16 * platform/gtk/fast/js/constructor-length-expected.txt: Remove test expectations. 17 * platform/mac/fast/js/constructor-length-expected.txt: Remove test expectations. 18 * platform/qt/fast/js/constructor-length-expected.txt: Remove test expectations. 19 1 20 2013-04-18 Timothy Hatcher <timothy@apple.com> 2 21 -
trunk/LayoutTests/fast/events/event-creation.html
r141578 r148731 228 228 // shouldBeTrue("document.createEvent('OrientationEvent') instanceof window.Event"); 229 229 // shouldBeTrue("document.createEvent('OrientationEvent').constructor === window.Event"); 230 231 // #if ENABLE(REQUEST_AUTOCOMPLETE)232 // AutocompleteErrorEvent233 // shouldBeTrue("document.createEvent('AutocompleteErrorEvent') instanceof window.AutocompleteErrorEvent");234 // shouldBeTrue("document.createEvent('AutocompleteErrorEvent') instanceof window.Event");235 // shouldBeTrue("document.createEvent('AutocompleteErrorEvent').constructor === window.AutocompleteErrorEvent");236 230 237 231 // We test both a hard coded set and the automated set below (using enumeration) to ensure that a constructor being removed -
trunk/LayoutTests/fast/js/constructor-length.html
r139372 r148731 10 10 shouldBe('ArrayBuffer.length', '1'); 11 11 shouldBe('AudioContext.length', '0'); 12 shouldBe('AutocompleteErrorEvent.length', '2');13 12 shouldBe('BeforeLoadEvent.length', '2'); 14 13 shouldBe('Blob.length', '2'); -
trunk/LayoutTests/fast/js/script-tests/global-constructors.js
r139372 r148731 40 40 name == "Float64Array" || 41 41 name == "FileError" || 42 name == "FileReader" || 43 name == "AutocompleteErrorEvent") 42 name == "FileReader") 44 43 continue; 45 44 -
trunk/LayoutTests/platform/blackberry/fast/js/constructor-length-expected.txt
r139372 r148731 6 6 PASS ArrayBuffer.length is 1 7 7 FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext 8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent9 8 PASS BeforeLoadEvent.length is 2 10 9 PASS Blob.length is 2 -
trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt
r139372 r148731 6 6 PASS ArrayBuffer.length is 1 7 7 FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext 8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent9 8 PASS BeforeLoadEvent.length is 2 10 9 PASS Blob.length is 2 -
trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt
r139372 r148731 6 6 PASS ArrayBuffer.length is 1 7 7 FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext 8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent9 8 PASS BeforeLoadEvent.length is 2 10 9 PASS Blob.length is 2 -
trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt
r139372 r148731 6 6 PASS ArrayBuffer.length is 1 7 7 FAIL AudioContext.length should be 0. Threw exception ReferenceError: Can't find variable: AudioContext 8 FAIL AutocompleteErrorEvent.length should be 2. Threw exception ReferenceError: Can't find variable: AutocompleteErrorEvent9 8 PASS BeforeLoadEvent.length is 2 10 9 PASS Blob.length is 2 -
trunk/Source/WTF/ChangeLog
r148684 r148731 1 2013-04-19 Dan Beam <dbeam@chromium.org> 2 3 Remove unmaintained feature REQUEST_AUTOCOMPLETE 4 https://bugs.webkit.org/show_bug.cgi?id=114846 5 6 Reviewed by Kent Tamura. 7 8 * wtf/FeatureDefines.h: Remove REQUEST_AUTOCOMPLETE as a feature definition. 9 1 10 2013-04-18 Zoltan Arvai <zarvai@inf.u-szeged.hu> 2 11 -
trunk/Source/WTF/wtf/FeatureDefines.h
r148093 r148731 716 716 #endif 717 717 718 #if !defined(ENABLE_REQUEST_AUTOCOMPLETE)719 #define ENABLE_REQUEST_AUTOCOMPLETE 0720 #endif721 722 718 #if !defined(ENABLE_RUBBER_BANDING) 723 719 #define ENABLE_RUBBER_BANDING 0 -
trunk/Source/WebCore/ChangeLog
r148723 r148731 1 2013-04-19 Dan Beam <dbeam@chromium.org> 2 3 Remove unmaintained feature REQUEST_AUTOCOMPLETE 4 https://bugs.webkit.org/show_bug.cgi?id=114846 5 6 Reviewed by Kent Tamura. 7 8 * GNUmakefile.list.am: Remove AutocompleteErrorEvent.h include. 9 * bindings/generic/RuntimeEnabledFeatures.cpp: 10 (WebCore): Remove requestAutocomplete() runtime feature. 11 * bindings/generic/RuntimeEnabledFeatures.h: 12 (RuntimeEnabledFeatures): Remove requestAutocomplete() runtime feature. 13 * dom/AutocompleteErrorEvent.h: Removed. 14 * dom/AutocompleteErrorEvent.idl: Removed. 15 * dom/EventNames.h: Remove `autocomplete` and `autocompleteerror` event names. 16 (WebCore): 17 * dom/EventNames.in: Remove `autocomplete` and `autocompleteerror` event names. 18 * html/HTMLAttributeNames.in: Remove `onautocomplete` and `onautocompleteerror` form attributes. 19 * html/HTMLFormElement.cpp: Remove requestAutocomplete() related code. 20 (WebCore::HTMLFormElement::HTMLFormElement): Remove timer and event queue for requestAutocomplete() related events. 21 (WebCore::HTMLFormElement::parseAttribute): Remove parsing of `onautocomplete` and `onautocompleterror`. 22 * html/HTMLFormElement.h: Remove requestAutocomplete() related members. 23 (HTMLFormElement): 24 * html/HTMLFormElement.idl: Remove public requestAutocomplete() API method. 25 * loader/EmptyClients.cpp: Remove stub implementation. 26 (WebCore): 27 * loader/EmptyClients.h: Remove stub interface. 28 (EmptyFrameLoaderClient): 29 * loader/FrameLoaderClient.h: Remove didRequestAutocomplete() from interface. 30 (FrameLoaderClient): 31 * page/DOMWindow.idl: Remove `AutocompleteErrorEvent` from window DOM interface. 32 1 33 2013-04-18 Timothy Hatcher <timothy@apple.com> 2 34 -
trunk/Source/WebCore/GNUmakefile.list.am
r148569 r148731 2783 2783 Source/WebCore/dom/Attr.h \ 2784 2784 Source/WebCore/dom/Attribute.h \ 2785 Source/WebCore/dom/AutocompleteErrorEvent.h \2786 2785 Source/WebCore/dom/BeforeLoadEvent.h \ 2787 2786 Source/WebCore/dom/BeforeTextInsertedEvent.cpp \ -
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
r147917 r148731 232 232 #endif 233 233 234 #if ENABLE(REQUEST_AUTOCOMPLETE)235 bool RuntimeEnabledFeatures::isRequestAutocompleteEnabled = false;236 #endif237 238 234 #if ENABLE(CSP_NEXT) 239 235 bool RuntimeEnabledFeatures::areExperimentalContentSecurityPolicyFeaturesEnabled = false; -
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
r146847 r148731 299 299 static void setLangAttributeAwareFormControlUIEnabled(bool isEnabled) { isLangAttributeAwareFormControlUIEnabled = isEnabled; } 300 300 301 #if ENABLE(REQUEST_AUTOCOMPLETE)302 static bool requestAutocompleteEnabled() { return isRequestAutocompleteEnabled; }303 static void setRequestAutocompleteEnabled(bool isEnabled) { isRequestAutocompleteEnabled = isEnabled; }304 #endif305 306 301 private: 307 302 // Never instantiate. … … 411 406 #endif 412 407 413 #if ENABLE(REQUEST_AUTOCOMPLETE)414 static bool isRequestAutocompleteEnabled;415 #endif416 417 408 #if ENABLE(CSP_NEXT) 418 409 static bool areExperimentalContentSecurityPolicyFeaturesEnabled; -
trunk/Source/WebCore/dom/EventNames.h
r146582 r148731 251 251 macro(webkitdeviceproximity) \ 252 252 \ 253 macro(autocomplete) \254 macro(autocompleteerror) \255 \256 253 macro(webkitprerenderstart) \ 257 254 macro(webkitprerenderstop) \ -
trunk/Source/WebCore/dom/EventNames.in
r147857 r148731 56 56 MediaKeyNeededEvent conditional=ENCRYPTED_MEDIA_V2 57 57 TrackEvent conditional=VIDEO_TRACK 58 AutocompleteErrorEvent conditional=REQUEST_AUTOCOMPLETE59 58 CSSFontFaceLoadEvent conditional=FONT_LOAD_EVENTS 60 59 SecurityPolicyViolationEvent conditional=CSP_NEXT -
trunk/Source/WebCore/html/HTMLAttributeNames.in
r145932 r148731 170 170 object 171 171 onabort 172 onautocomplete173 onautocompleteerror174 172 onbeforecopy 175 173 onbeforecut -
trunk/Source/WebCore/html/HTMLFormElement.cpp
r148373 r148731 27 27 28 28 #include "Attribute.h" 29 #include "AutocompleteErrorEvent.h"30 29 #include "DOMFormData.h" 31 30 #include "DOMWindow.h" … … 78 77 , m_isInResetFunction(false) 79 78 , m_wasDemoted(false) 80 #if ENABLE(REQUEST_AUTOCOMPLETE)81 , m_requestAutocompleteTimer(this, &HTMLFormElement::requestAutocompleteTimerFired)82 #endif83 79 { 84 80 ASSERT(hasTagName(formTag)); … … 393 389 m_isInResetFunction = false; 394 390 } 395 396 #if ENABLE(REQUEST_AUTOCOMPLETE)397 void HTMLFormElement::requestAutocomplete()398 {399 Frame* frame = document()->frame();400 if (!frame)401 return;402 403 if (!shouldAutocomplete() || !ScriptController::processingUserGesture()) {404 finishRequestAutocomplete(AutocompleteResultErrorDisabled);405 return;406 }407 408 StringPairVector controlNamesAndValues;409 getTextFieldValues(controlNamesAndValues);410 RefPtr<FormState> formState = FormState::create(this, controlNamesAndValues, document(), SubmittedByJavaScript);411 frame->loader()->client()->didRequestAutocomplete(formState.release());412 }413 414 void HTMLFormElement::finishRequestAutocomplete(AutocompleteResult result)415 {416 RefPtr<Event> event;417 if (result == AutocompleteResultSuccess)418 event = Event::create(eventNames().autocompleteEvent, false, false);419 else if (result == AutocompleteResultErrorDisabled)420 event = AutocompleteErrorEvent::create("disabled");421 else if (result == AutocompleteResultErrorCancel)422 event = AutocompleteErrorEvent::create("cancel");423 else if (result == AutocompleteResultErrorInvalid)424 event = AutocompleteErrorEvent::create("invalid");425 426 event->setTarget(this);427 m_pendingAutocompleteEvents.append(event.release());428 429 // Dispatch events later as this API is meant to work asynchronously in all situations and implementations.430 if (!m_requestAutocompleteTimer.isActive())431 m_requestAutocompleteTimer.startOneShot(0);432 }433 434 void HTMLFormElement::requestAutocompleteTimerFired(Timer<HTMLFormElement>*)435 {436 Vector<RefPtr<Event> > pendingEvents;437 m_pendingAutocompleteEvents.swap(pendingEvents);438 for (size_t i = 0; i < pendingEvents.size(); ++i)439 dispatchEvent(pendingEvents[i].release());440 }441 #endif442 391 443 392 void HTMLFormElement::parseAttribute(const QualifiedName& name, const AtomicString& value) … … 459 408 document()->unregisterForPageCacheSuspensionCallbacks(this); 460 409 } 461 #if ENABLE(REQUEST_AUTOCOMPLETE)462 else if (name == onautocompleteAttr)463 setAttributeEventListener(eventNames().autocompleteEvent, createAttributeEventListener(this, name, value));464 else if (name == onautocompleteerrorAttr)465 setAttributeEventListener(eventNames().autocompleteerrorEvent, createAttributeEventListener(this, name, value));466 #endif467 410 else 468 411 HTMLElement::parseAttribute(name, value); -
trunk/Source/WebCore/html/HTMLFormElement.h
r139545 r148731 99 99 bool checkValidity(); 100 100 101 #if ENABLE(REQUEST_AUTOCOMPLETE)102 enum AutocompleteResult {103 AutocompleteResultSuccess,104 AutocompleteResultErrorDisabled,105 AutocompleteResultErrorCancel,106 AutocompleteResultErrorInvalid,107 };108 109 void requestAutocomplete();110 void finishRequestAutocomplete(AutocompleteResult);111 112 DEFINE_ATTRIBUTE_EVENT_LISTENER(autocomplete);113 DEFINE_ATTRIBUTE_EVENT_LISTENER(autocompleteerror);114 #endif115 116 101 HTMLFormControlElement* elementForAlias(const AtomicString&); 117 102 void addElementAlias(HTMLFormControlElement*, const AtomicString& alias); … … 177 162 178 163 bool m_wasDemoted; 179 180 #if ENABLE(REQUEST_AUTOCOMPLETE)181 void requestAutocompleteTimerFired(Timer<HTMLFormElement>*);182 183 Vector<RefPtr<Event> > m_pendingAutocompleteEvents;184 Timer<HTMLFormElement> m_requestAutocompleteTimer;185 #endif186 164 }; 187 165 -
trunk/Source/WebCore/html/HTMLFormElement.idl
r147857 r148731 43 43 void reset(); 44 44 boolean checkValidity(); 45 46 #if defined(ENABLE_REQUEST_AUTOCOMPLETE) && ENABLE_REQUEST_AUTOCOMPLETE47 void requestAutocomplete();48 [NotEnumerable] attribute EventListener onautocomplete;49 [NotEnumerable] attribute EventListener onautocompleteerror;50 #endif51 45 }; -
trunk/Source/WebCore/loader/EmptyClients.cpp
r142549 r148731 185 185 #endif 186 186 187 #if ENABLE(REQUEST_AUTOCOMPLETE)188 void EmptyFrameLoaderClient::didRequestAutocomplete(PassRefPtr<FormState>)189 {190 187 } 191 #endif192 193 } -
trunk/Source/WebCore/loader/EmptyClients.h
r147857 r148731 374 374 375 375 virtual PassRefPtr<FrameNetworkingContext> createNetworkingContext() OVERRIDE; 376 377 #if ENABLE(REQUEST_AUTOCOMPLETE)378 virtual void didRequestAutocomplete(PassRefPtr<FormState>) OVERRIDE;379 #endif380 376 }; 381 377 -
trunk/Source/WebCore/loader/FrameLoaderClient.h
r147857 r148731 338 338 #endif 339 339 340 #if ENABLE(REQUEST_AUTOCOMPLETE)341 virtual void didRequestAutocomplete(PassRefPtr<FormState>) = 0;342 #endif343 344 340 #if ENABLE(WEBGL) 345 341 virtual bool allowWebGL(bool enabledPerSettings) { return enabledPerSettings; } -
trunk/Source/WebCore/page/DOMWindow.idl
r148593 r148731 567 567 [Conditional=WEBGL] attribute WebGLContextEventConstructor WebGLContextEvent; 568 568 [Conditional=PROXIMITY_EVENTS] attribute DeviceProximityEventConstructor DeviceProximityEvent; 569 [Conditional=REQUEST_AUTOCOMPLETE] attribute AutocompleteErrorEventConstructor AutocompleteErrorEvent;570 569 [Conditional=CSP_NEXT] attribute SecurityPolicyViolationEventConstructor SecurityPolicyViolationEvent; 571 570
Note: See TracChangeset
for help on using the changeset viewer.