Changeset 148915 in webkit


Ignore:
Timestamp:
Apr 22, 2013 3:07:05 PM (11 years ago)
Author:
betravis@adobe.com
Message:

[css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
​https://bugs.webkit.org/show_bug.cgi?id=114986

Reviewed by Dirk Schulze.

Because the inline-grid value is not yet supported, the test case is falling back to
display: block. This causes an incorrect layout, as block and inline content react to
shape-inside differently.

  • fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
  • fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r148907 r148915  
     12013-04-22  Bear Travis  <betravis@adobe.com>
     2
     3        [css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
     4        https://bugs.webkit.org/show_bug.cgi?id=114986
     5
     6        Reviewed by Dirk Schulze.
     7
     8        Because the inline-grid value is not yet supported, the test case is falling back to
     9        display: block. This causes an incorrect layout, as block and inline content react to
     10        shape-inside differently.
     11
     12        * fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
     13        * fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
     14
    1152013-04-22  Eric Carlson  <eric.carlson@apple.com>
    216

  • trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html

    r148786 r148915  
    3939    display: -webkit-inline-flex;
    4040}
    41 #grid * {
    42     display: -webkit-inline-grid;
    43     -webkit-grid-rows: 100px;
    44     -webkit-grid-columns: 100px;
    45 }
    4641</style>
    4742<script>
    … …  
    5550    createRectangleTestResult('old-flexbox', 'stylesheet', elementBounds, shapeBounds, 'px');
    5651    createRectangleTestResult('new-flexbox', 'stylesheet', elementBounds, shapeBounds, 'px');
    57     createRectangleTestResult('grid', 'stylesheet', elementBounds, shapeBounds, 'px');
    5852}
    5953</script>
    … …  
    9993    <div class='content'>xxxx</div>
    10094</div>
    101 
    102 <p>Grid</p>
    103 <div id='grid'>
    104     <div class='content'>xxxx</div>
    105 </div>
    10695</body>
    10796</html>

  • trunk/LayoutTests/fast/exclusions/shape-inside/shape-inside-recursive-layout.html

    r148786 r148915  
    3939    display: -webkit-inline-flex;
    4040}
    41 #grid * {
    42     display: -webkit-inline-grid;
    43     -webkit-grid-rows: 100px;
    44     -webkit-grid-columns: 100px;
    45 }
    4641</style>
    4742<script>
    … …  
    5550    createRectangleTest('old-flexbox', 'stylesheet', elementBounds, shapeBounds, 'px');
    5651    createRectangleTest('new-flexbox', 'stylesheet', elementBounds, shapeBounds, 'px');
    57     createRectangleTest('grid', 'stylesheet', elementBounds, shapeBounds, 'px');
    5852}
    5953</script>
    … …  
    9993    <div class='content'>xxxx</div>
    10094</div>
    101 
    102 <p>Grid</p>
    103 <div id='grid'>
    104     <div class='content'>xxxx</div>
    105 </div>
    10695</body>
    10796</html>
Note: See TracChangeset for help on using the changeset viewer.