Changeset 149207 in webkit

Timestamp:

Apr 26, 2013 2:13:19 PM (11 years ago)

Author:

Simon Fraser

Message:

Layer-backed WebViews don't repaint content outside the visible area
​https://bugs.webkit.org/show_bug.cgi?id=115275

Reviewed by Beth Dakin.

Source/WebCore:

Export ScrollView::setPaintsEntireContents(bool).

• WebCore.exp.in:

Source/WebKit/mac:

When a client of WebView makes the WebView be layer-backed, then
AppKit propagaes the layer-backing down to the WebHTMLView (but
no further).

In this situation, we had a bug where content that was not
in the visible content rect would not get repainted, because
WebCore clips repaints to the visible rect.

Fix by calling ScrollView::setPaintsEntireContents(bool) from
-[WebHTMLView setLayer:], saying that we need
to paint the entire contents if we have a layer.

• WebView/WebHTMLView.mm:

(-[WebHTMLView setLayer:]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebHTMLView.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Layer-backed WebViews don't repaint content outside the visible area
+        https://bugs.webkit.org/show_bug.cgi?id=115275
+
+        Reviewed by Beth Dakin.
+
+        Export ScrollView::setPaintsEntireContents(bool).
+
+        * WebCore.exp.in:
+
 2013-04-26  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -81 +81 @@
 __ZN7WebCore10ScrollView17setUseFixedLayoutEb
 __ZN7WebCore10ScrollView18setFixedLayoutSizeERKNS_7IntSizeE
+__ZN7WebCore10ScrollView23setPaintsEntireContentsEb
 __ZN7WebCore10ScrollView20setCanHaveScrollbarsEb
 __ZN7WebCore10ScrollView21setDelegatesScrollingEb

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2013-04-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Layer-backed WebViews don't repaint content outside the visible area
+        https://bugs.webkit.org/show_bug.cgi?id=115275
+
+        Reviewed by Beth Dakin.
+
+        When a client of WebView makes the WebView be layer-backed, then
+        AppKit propagaes the layer-backing down to the WebHTMLView (but
+        no further).
+        
+        In this situation, we had a bug where content that was not
+        in the visible content rect would not get repainted, because
+        WebCore clips repaints to the visible rect.
+        
+        Fix by calling ScrollView::setPaintsEntireContents(bool) from
+        -[WebHTMLView setLayer:], saying that we need
+        to paint the entire contents if we have a layer.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView setLayer:]):
+
 2013-04-25  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

@@ -3154 +3154 @@
 }
 
+- (void)setLayer:(CALayer *)layer
+{
+    if (Frame* frame = core([self _frame])) {
+        if (FrameView* view = frame->view())
+            view->setPaintsEntireContents(layer);
+    }
+
+    [super setLayer:layer];
+}
+
 #if !LOG_DISABLED
 - (void)setNeedsDisplay:(BOOL)flag