Changeset 149343 in webkit

Timestamp:

Apr 29, 2013, 6:03:52 PM (13 years ago)

Author:

Simon Fraser

Message:

Don't do CGContext flipping when painting subframes in WebKit1 on post-MountainLion OSes
​https://bugs.webkit.org/show_bug.cgi?id=115392
<rdar://problem/13421519>

Reviewed by Beth Dakin.

Sync up with AppKit behavior changes that could cause subviews to be flipped when
painted.

• platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/WidgetMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Don't do CGContext flipping when painting subframes in WebKit1 on post-MountainLion OSes
+        https://bugs.webkit.org/show_bug.cgi?id=115392
+        <rdar://problem/13421519>
+
+        Reviewed by Beth Dakin.
+
+        Sync up with AppKit behavior changes that could cause subviews to be flipped when
+        painted.
+
+        * platform/mac/WidgetMac.mm:
+        (WebCore::Widget::paint):
+
 2013-04-29  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/platform/mac/WidgetMac.mm

@@ -242 +242 @@
         // Set up the translation and (flipped) orientation of the graphics context. In normal drawing, AppKit does it as it descends down
         // the view hierarchy.
-        CGContextTranslateCTM(cgContext, viewFrame.origin.x - viewBounds.origin.x, viewFrame.origin.y + viewFrame.size.height + viewBounds.origin.y);
-        CGContextScaleCTM(cgContext, 1, -1);
+        bool shouldFlipContext = true;
+#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+        shouldFlipContext = false;
+#endif
+        if (shouldFlipContext) {
+            CGContextTranslateCTM(cgContext, viewFrame.origin.x - viewBounds.origin.x, viewFrame.origin.y + viewFrame.size.height + viewBounds.origin.y);
+            CGContextScaleCTM(cgContext, 1, -1);
+        } else
+            CGContextTranslateCTM(cgContext, viewFrame.origin.x - viewBounds.origin.x, viewFrame.origin.y + viewBounds.origin.y);
 
         BEGIN_BLOCK_OBJC_EXCEPTIONS;