Changeset 149548 in webkit

Timestamp:

May 3, 2013 7:11:49 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

SunSpider 1.0: 3d-morph: use epsilon to check result
​https://bugs.webkit.org/show_bug.cgi?id=115553

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-05-03
Reviewed by George Staikos.

SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.

• tests/sunspider-1.0/3d-morph.js:

Location:

trunk/PerformanceTests/SunSpider

Files:

• ChangeLog (modified) (1 diff)
• tests/sunspider-1.0/3d-morph.js (modified) (1 diff)

trunk/PerformanceTests/SunSpider/ChangeLog

@@ +1 @@
+2013-05-03  Cosmin Truta  <ctruta@blackberry.com>
+
+        SunSpider 1.0: 3d-morph: use epsilon to check result
+        https://bugs.webkit.org/show_bug.cgi?id=115553
+
+        Reviewed by George Staikos.
+
+        SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.
+
+        * tests/sunspider-1.0/3d-morph.js:
+
 2013-04-19  Filip Pizlo  <fpizlo@apple.com>
 

trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/3d-morph.js

@@ -59 +59 @@
 // would not be able to do an exact test here since that would allow for just enough
 // low-bit slop to create possibly big errors due to testOutput being a sum.
-var expected = 6;
-if (("" + testOutput)[0] != expected)
-    throw "Error: bad test output: expected leading digit to be " + expected + " but got " + testOutput;
+var epsilon = 1e-13;
+if (Math.abs(testOutput) >= epsilon)
+    throw "Error: bad test output: expected magnitude below " + epsilon + " but got " + testOutput;