Changeset 149697 in webkit

Timestamp:

May 7, 2013 3:26:16 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

fixed a memory leak introduced by bug 42324 by using a RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=115760

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-05-07  Alex Christensen  <achristensen@apple.com>
+
+        fixed a memory leak introduced by bug 42324 by using a RetainPtr
+        https://bugs.webkit.org/show_bug.cgi?id=115760
+
+        Reviewed by Tim Horton.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
+        fixed memory leak, added UNUSED_PARAM macros
+
 2013-05-07  Alex Christensen  <achristensen@apple.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

@@ -846 +846 @@
 {
 #if USE(CF)
-    WKDataRef wkData = WKBundleFrameCopyWebArchive(frame);
-    RetainPtr<CFDataRef> cfData = adoptCF(CFDataCreate(0, WKDataGetBytes(wkData), WKDataGetSize(wkData)));
+    RetainPtr<WKDataRef> wkData = WKBundleFrameCopyWebArchive(frame);
+    RetainPtr<CFDataRef> cfData = adoptCF(CFDataCreate(0, WKDataGetBytes(wkData.get()), WKDataGetSize(wkData.get())));
     RetainPtr<CFStringRef> cfString = adoptCF(createXMLStringFromWebArchiveData(cfData.get()));
     stringBuilder.append(cfString.get());
+#else
+    UNUSED_PARAM(frame);
+    UNUSED_PARAM(stringBuilder);
 #endif
 }