Changeset 149740 in webkit

Timestamp:

May 8, 2013 8:19:15 AM (11 years ago)

Author:

sergio@webkit.org

Message:

Allow blank spaces before colon (:) on CSS variable definition
​https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

• css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

• css3/css-variable-definition-expected.html: Added.
• css3/css-variable-definition.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/css-variable-definition-expected.html (added)
• LayoutTests/css3/css-variable-definition.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSGrammar.y.in (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-05-08  Sergio Villar Senin  <svillar@igalia.com>
+
+        Allow blank spaces before colon (:) on CSS variable definition
+        https://bugs.webkit.org/show_bug.cgi?id=115802
+
+        Reviewed by Darin Adler.
+
+        New test to check that spaces are allowed before the color on CSS
+        variable definitions.
+
+        * css3/css-variable-definition-expected.html: Added.
+        * css3/css-variable-definition.html: Added.
+
 2013-05-08  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-08  Sergio Villar Senin  <svillar@igalia.com>
+
+        Allow blank spaces before colon (:) on CSS variable definition
+        https://bugs.webkit.org/show_bug.cgi?id=115802
+
+        Reviewed by Darin Adler.
+
+        Test: css3/css-variable-definition.html
+
+        Modified the grammar to allow blank spaces before the colon on CSS
+        variable definitions.
+
+        * css/CSSGrammar.y.in:
+
 2013-05-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 

trunk/Source/WebCore/css/CSSGrammar.y.in

@@ -1616 +1616 @@
 
 declaration:
-    VAR_DEFINITION ':' maybe_space expr prio {
+    VAR_DEFINITION maybe_space ':' maybe_space expr prio {
 #if ENABLE_CSS_VARIABLES
-        parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5);
+        parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($5), $6);
         $$ = true;
-        parser->markPropertyEnd($5, true);
+        parser->markPropertyEnd($6, true);
 #else
         $$ = false;