Changeset 149757 in webkit

Timestamp:

May 8, 2013 12:26:16 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

new-run-webkit-websocketserver doesn't work after Chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

• Scripts/new-run-webkit-websocketserver:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/new-run-webkit-websocketserver (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        new-run-webkit-websocketserver doesn't work after Chromium removal
+        https://bugs.webkit.org/show_bug.cgi?id=115816
+
+        Reviewed by Joseph Pecoraro.
+
+        Fix the bug by instantiating the correct port object.
+
+        * Scripts/new-run-webkit-websocketserver:
+        (main):
+
 2013-05-07  Lucas Forschler  <lforschler@apple.com>
 

trunk/Tools/Scripts/new-run-webkit-websocketserver

@@ -37 +37 @@
 from webkitpy.common.host import Host
 from webkitpy.layout_tests.servers import websocket_server
+from webkitpy.port import platform_options
 
 
@@ -72 +73 @@
                              default=False,
                              help='Include debug-level logging.')
+
+    option_group = optparse.OptionGroup(option_parser, "Platform options")
+    option_group.add_options(platform_options())
+    option_parser.add_option_group(option_group)
+
     options, args = option_parser.parse_args()
 
@@ -98 +104 @@
 
     host = Host()
-    # FIXME: Make this work with other ports as well.
-    port_obj = host.port_factory.get(port_name='chromium', options=options)
+    port_obj = host.port_factory.get(options.platform, options=options)
     pywebsocket = websocket_server.PyWebSocket(port_obj, options.output_dir, **kwds)