Changeset 149807 in webkit

Timestamp:

May 9, 2013 8:16:58 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
​https://bugs.webkit.org/show_bug.cgi?id=115850

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.

Removed the Memory Instrumentation Code after r148921.

No new tests, no behavior change.

• inspector/compile-front-end.py:
• inspector/front-end/NativeMemorySnapshotView.js: Removed.
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

• inspector/front-end/SettingsScreen.js:
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.css:
• inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

• inspector/front-end/nativeMemoryProfiler.css: Removed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/compile-front-end.py (modified) (1 diff)
• inspector/front-end/NativeMemorySnapshotView.js (deleted)
• inspector/front-end/ProfilesPanel.js (modified) (3 diffs)
• inspector/front-end/Settings.js (modified) (2 diffs)
• inspector/front-end/SettingsScreen.js (modified) (1 diff)
• inspector/front-end/WebKit.qrc (modified) (2 diffs)
• inspector/front-end/inspector.css (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)
• inspector/front-end/nativeMemoryProfiler.css (deleted)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-09  Seokju Kwon  <seokju.kwon@gmail.com>
+
+        Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
+        https://bugs.webkit.org/show_bug.cgi?id=115850
+
+        Reviewed by Andreas Kling.
+
+        Removed the Memory Instrumentation Code after r148921.
+
+        No new tests, no behavior change.
+
+        * inspector/compile-front-end.py:
+        * inspector/front-end/NativeMemorySnapshotView.js: Removed.
+        * inspector/front-end/ProfilesPanel.js:
+        (WebInspector.ProfilesPanel):
+        * inspector/front-end/Settings.js:
+        (WebInspector.Settings):
+        (WebInspector.ExperimentsSettings):
+        * inspector/front-end/SettingsScreen.js:
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.css:
+        * inspector/front-end/inspector.js:
+        (WebInspector._panelDescriptors):
+        * inspector/front-end/nativeMemoryProfiler.css: Removed.
+
 2013-05-09  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/inspector/compile-front-end.py

@@ -352 +352 @@
             "JSHeapSnapshot.js",
             "NativeHeapSnapshot.js",
-            "NativeMemorySnapshotView.js",
             "ProfileDataGridTree.js",
             "ProfilesPanel.js",

trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js

@@ -409 +409 @@
         if (Capabilities.heapProfilerPresent)
             this._registerProfileType(new WebInspector.HeapSnapshotProfileType());
-        if (!WebInspector.WorkerManager.isWorkerFrontend() && WebInspector.experimentsSettings.nativeMemorySnapshots.isEnabled()) {
-            this._registerProfileType(new WebInspector.NativeSnapshotProfileType());
-            this._registerProfileType(new WebInspector.NativeMemoryProfileType());
-        }
         if (!WebInspector.WorkerManager.isWorkerFrontend() && WebInspector.experimentsSettings.canvasInspection.isEnabled())
             this._registerProfileType(new WebInspector.CanvasProfileType());
@@ -1420 +1416 @@
 
 
-/**
- * @constructor
- * @extends {WebInspector.ProfilesPanel}
- */
-WebInspector.MemoryChartProfilerPanel = function()
-{
-    WebInspector.ProfilesPanel.call(this, "memory-chart-profiler", new WebInspector.NativeMemoryProfileType());
-}
-
-WebInspector.MemoryChartProfilerPanel.prototype = {
-    __proto__: WebInspector.ProfilesPanel.prototype
-}
-
-
-/**
- * @constructor
- * @extends {WebInspector.ProfilesPanel}
- */
-WebInspector.NativeMemoryProfilerPanel = function()
-{
-    WebInspector.ProfilesPanel.call(this, "memory-snapshot-profiler", new WebInspector.NativeSnapshotProfileType());
-}
-
-WebInspector.NativeMemoryProfilerPanel.prototype = {
-    __proto__: WebInspector.ProfilesPanel.prototype
-}
-
-
 importScript("ProfileDataGridTree.js");
 importScript("BottomUpProfileDataGridTree.js");
@@ -1462 +1430 @@
 importScript("JSHeapSnapshot.js");
 importScript("NativeHeapSnapshot.js");
-importScript("NativeMemorySnapshotView.js");
 importScript("ProfileLauncherView.js");
 importScript("TopDownProfileDataGridTree.js");

trunk/Source/WebCore/inspector/front-end/Settings.js

@@ -113 +113 @@
     this.deviceOrientationOverride = this.createSetting("deviceOrientationOverride", "");
     this.showHeapSnapshotObjectsHiddenProperties = this.createSetting("showHeapSnapshotObjectsHiddenProperties", false);
-    this.showNativeSnapshotUninstrumentedSize = this.createSetting("showNativeSnapshotUninstrumentedSize", false);
     this.searchInContentScripts = this.createSetting("searchInContentScripts", false);
     this.textEditorIndent = this.createSetting("textEditorIndent", "    ");
@@ -218 +217 @@
     // Add currently running experiments here.
     this.snippetsSupport = this._createExperiment("snippetsSupport", "Snippets support");
-    this.nativeMemorySnapshots = this._createExperiment("nativeMemorySnapshots", "Native memory profiling");
     this.nativeMemoryTimeline = this._createExperiment("nativeMemoryTimeline", "Native memory timeline");
     this.fileSystemInspection = this._createExperiment("fileSystemInspection", "FileSystem inspection");

trunk/Source/WebCore/inspector/front-end/SettingsScreen.js

@@ -359 +359 @@
     p = this._appendSection(WebInspector.UIString("Profiler"));
     p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show objects' hidden properties"), WebInspector.settings.showHeapSnapshotObjectsHiddenProperties));
-    if (WebInspector.experimentsSettings.nativeMemorySnapshots.isEnabled())
-        p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show uninstrumented native memory"), WebInspector.settings.showNativeSnapshotUninstrumentedSize));
 
     p = this._appendSection(WebInspector.UIString("Timeline"));

trunk/Source/WebCore/inspector/front-end/WebKit.qrc

@@ -123 +123 @@
     <file>NativeHeapSnapshot.js</file>
     <file>NativeMemoryGraph.js</file>
-    <file>NativeMemorySnapshotView.js</file>
     <file>NavigatorOverlayController.js</file>
     <file>NavigatorView.js</file>
@@ -259 +258 @@
     <file>inspectorCommon.css</file>
     <file>inspectorSyntaxHighlight.css</file>
-    <file>nativeMemoryProfiler.css</file>
     <file>navigatorView.css</file>
     <file>networkLogView.css</file>

trunk/Source/WebCore/inspector/front-end/inspector.css

@@ -547 +547 @@
 }
 
-.toolbar-item.memory-chart-profiler .toolbar-icon {
-    background-position-x: -160px;
-}
-
-body.dock-to-bottom .toolbar-item.memory-chart-profiler .toolbar-icon {
-    background-position-x: -120px;
-}
-
-.toolbar-item.memory-snapshot-profiler .toolbar-icon {
-    background-position-x: -160px;
-}
-
-body.dock-to-bottom .toolbar-item.memory-snapshot-profiler .toolbar-icon {
-    background-position-x: -120px;
-}
-
 .toolbar-item.audits .toolbar-icon {
     background-position-x: -192px;

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -57 +57 @@
             if (!WebInspector.WorkerManager.isWorkerFrontend() && WebInspector.experimentsSettings.canvasInspection.isEnabled())
                 allProfilers.push(new WebInspector.PanelDescriptor("canvas-profiler", WebInspector.UIString("Canvas Profiler"), "CanvasProfilerPanel", "ProfilesPanel.js"));
-            if (!WebInspector.WorkerManager.isWorkerFrontend() && WebInspector.experimentsSettings.nativeMemorySnapshots.isEnabled()) {
-                allProfilers.push(new WebInspector.PanelDescriptor("memory-chart-profiler", WebInspector.UIString("Memory Distribution"), "MemoryChartProfilerPanel", "ProfilesPanel.js"));
-                allProfilers.push(new WebInspector.PanelDescriptor("memory-snapshot-profiler", WebInspector.UIString("Memory Snapshots"), "NativeMemoryProfilerPanel", "ProfilesPanel.js"));
-            }
             Array.prototype.splice.bind(allDescriptors, allDescriptors.indexOf(profiles), 1).apply(null, allProfilers);
         }