Changeset 149845 in webkit
- Timestamp:
- May 9, 2013 2:47:37 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 17 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r149844 r149845 1 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com> 2 3 [NoInterfaceObject] extended attribute should be removed for several interfaces 4 https://bugs.webkit.org/show_bug.cgi?id=115852 5 6 Reviewed by Benjamin Poulain. 7 8 Rebaseline several layout tests whose output has changed now that a few more 9 global constructors are exposed. 10 11 * fast/dom/dom-constructors-expected.txt: 12 * fast/js/global-constructors-attributes-expected.txt: 13 * platform/efl/fast/js/global-constructors-attributes-expected.txt: 14 1 15 2013-05-09 Robert Hogan <robert@webkit.org> 2 16 -
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
r141346 r149845 114 114 PASS TryAllocate('Selection') is 'exception' 115 115 PASS TryAllocate('Window') is 'exception' 116 FAIL TryAllocate('History') should be exception. Was no constructor. 116 PASS TryAllocate('History') is 'exception' 117 117 PASS TryAllocate('HTMLOptionsCollection') is 'exception' 118 FAIL TryAllocate('Location') should be exception. Was no constructor. 119 FAIL TryAllocate('Navigator') should be exception. Was no constructor. 118 PASS TryAllocate('Location') is 'exception' 119 PASS TryAllocate('Navigator') is 'exception' 120 120 FAIL TryAllocate('NodeIterator') should be exception. Was no constructor. 121 121 PASS TryAllocate('RGBColor') is 'exception' 122 FAIL TryAllocate('Screen') should be exception. Was no constructor. 122 PASS TryAllocate('Screen') is 'exception' 123 123 FAIL TryAllocate('TreeWalker') should be exception. Was no constructor. 124 124 FAIL TryAllocate('XPathExpression') should be exception. Was no constructor. -
trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt
r149758 r149845 659 659 PASS Object.getOwnPropertyDescriptor(global, 'HashChangeEvent').enumerable is false 660 660 PASS Object.getOwnPropertyDescriptor(global, 'HashChangeEvent').configurable is true 661 PASS Object.getOwnPropertyDescriptor(global, 'History').value is History 662 PASS Object.getOwnPropertyDescriptor(global, 'History').hasOwnProperty('get') is false 663 PASS Object.getOwnPropertyDescriptor(global, 'History').hasOwnProperty('set') is false 664 PASS Object.getOwnPropertyDescriptor(global, 'History').enumerable is false 665 PASS Object.getOwnPropertyDescriptor(global, 'History').configurable is true 661 666 PASS Object.getOwnPropertyDescriptor(global, 'Image').value is Image 662 667 PASS Object.getOwnPropertyDescriptor(global, 'Image').hasOwnProperty('get') is false … … 689 694 PASS Object.getOwnPropertyDescriptor(global, 'KeyboardEvent').enumerable is false 690 695 PASS Object.getOwnPropertyDescriptor(global, 'KeyboardEvent').configurable is true 696 PASS Object.getOwnPropertyDescriptor(global, 'Location').value is Location 697 PASS Object.getOwnPropertyDescriptor(global, 'Location').hasOwnProperty('get') is false 698 PASS Object.getOwnPropertyDescriptor(global, 'Location').hasOwnProperty('set') is false 699 PASS Object.getOwnPropertyDescriptor(global, 'Location').enumerable is false 700 PASS Object.getOwnPropertyDescriptor(global, 'Location').configurable is true 691 701 PASS Object.getOwnPropertyDescriptor(global, 'MediaController').value is MediaController 692 702 PASS Object.getOwnPropertyDescriptor(global, 'MediaController').hasOwnProperty('get') is false … … 754 764 PASS Object.getOwnPropertyDescriptor(global, 'NamedNodeMap').enumerable is false 755 765 PASS Object.getOwnPropertyDescriptor(global, 'NamedNodeMap').configurable is true 766 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').value is Navigator 767 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').hasOwnProperty('get') is false 768 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').hasOwnProperty('set') is false 769 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').enumerable is false 770 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').configurable is true 756 771 PASS Object.getOwnPropertyDescriptor(global, 'Node').value is Node 757 772 PASS Object.getOwnPropertyDescriptor(global, 'Node').hasOwnProperty('get') is false … … 804 819 PASS Object.getOwnPropertyDescriptor(global, 'Path').enumerable is false 805 820 PASS Object.getOwnPropertyDescriptor(global, 'Path').configurable is true 821 PASS Object.getOwnPropertyDescriptor(global, 'Performance').value is Performance 822 PASS Object.getOwnPropertyDescriptor(global, 'Performance').hasOwnProperty('get') is false 823 PASS Object.getOwnPropertyDescriptor(global, 'Performance').hasOwnProperty('set') is false 824 PASS Object.getOwnPropertyDescriptor(global, 'Performance').enumerable is false 825 PASS Object.getOwnPropertyDescriptor(global, 'Performance').configurable is true 806 826 PASS Object.getOwnPropertyDescriptor(global, 'Plugin').value is Plugin 807 827 PASS Object.getOwnPropertyDescriptor(global, 'Plugin').hasOwnProperty('get') is false … … 1564 1584 PASS Object.getOwnPropertyDescriptor(global, 'SVGZoomEvent').enumerable is false 1565 1585 PASS Object.getOwnPropertyDescriptor(global, 'SVGZoomEvent').configurable is true 1586 PASS Object.getOwnPropertyDescriptor(global, 'Screen').value is Screen 1587 PASS Object.getOwnPropertyDescriptor(global, 'Screen').hasOwnProperty('get') is false 1588 PASS Object.getOwnPropertyDescriptor(global, 'Screen').hasOwnProperty('set') is false 1589 PASS Object.getOwnPropertyDescriptor(global, 'Screen').enumerable is false 1590 PASS Object.getOwnPropertyDescriptor(global, 'Screen').configurable is true 1566 1591 PASS Object.getOwnPropertyDescriptor(global, 'Selection').value is Selection 1567 1592 PASS Object.getOwnPropertyDescriptor(global, 'Selection').hasOwnProperty('get') is false -
trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt
r149758 r149845 674 674 PASS Object.getOwnPropertyDescriptor(global, 'HashChangeEvent').enumerable is false 675 675 PASS Object.getOwnPropertyDescriptor(global, 'HashChangeEvent').configurable is true 676 PASS Object.getOwnPropertyDescriptor(global, 'History').value is History 677 PASS Object.getOwnPropertyDescriptor(global, 'History').hasOwnProperty('get') is false 678 PASS Object.getOwnPropertyDescriptor(global, 'History').hasOwnProperty('set') is false 679 PASS Object.getOwnPropertyDescriptor(global, 'History').enumerable is false 680 PASS Object.getOwnPropertyDescriptor(global, 'History').configurable is true 676 681 PASS Object.getOwnPropertyDescriptor(global, 'IDBCursor').value is IDBCursor 677 682 PASS Object.getOwnPropertyDescriptor(global, 'IDBCursor').hasOwnProperty('get') is false … … 759 764 PASS Object.getOwnPropertyDescriptor(global, 'KeyboardEvent').enumerable is false 760 765 PASS Object.getOwnPropertyDescriptor(global, 'KeyboardEvent').configurable is true 766 PASS Object.getOwnPropertyDescriptor(global, 'Location').value is Location 767 PASS Object.getOwnPropertyDescriptor(global, 'Location').hasOwnProperty('get') is false 768 PASS Object.getOwnPropertyDescriptor(global, 'Location').hasOwnProperty('set') is false 769 PASS Object.getOwnPropertyDescriptor(global, 'Location').enumerable is false 770 PASS Object.getOwnPropertyDescriptor(global, 'Location').configurable is true 761 771 PASS Object.getOwnPropertyDescriptor(global, 'MediaController').value is MediaController 762 772 PASS Object.getOwnPropertyDescriptor(global, 'MediaController').hasOwnProperty('get') is false … … 824 834 PASS Object.getOwnPropertyDescriptor(global, 'NamedNodeMap').enumerable is false 825 835 PASS Object.getOwnPropertyDescriptor(global, 'NamedNodeMap').configurable is true 836 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').value is Navigator 837 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').hasOwnProperty('get') is false 838 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').hasOwnProperty('set') is false 839 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').enumerable is false 840 PASS Object.getOwnPropertyDescriptor(global, 'Navigator').configurable is true 826 841 PASS Object.getOwnPropertyDescriptor(global, 'Node').value is Node 827 842 PASS Object.getOwnPropertyDescriptor(global, 'Node').hasOwnProperty('get') is false … … 869 884 PASS Object.getOwnPropertyDescriptor(global, 'Path').enumerable is false 870 885 PASS Object.getOwnPropertyDescriptor(global, 'Path').configurable is true 886 PASS Object.getOwnPropertyDescriptor(global, 'Performance').value is Performance 887 PASS Object.getOwnPropertyDescriptor(global, 'Performance').hasOwnProperty('get') is false 888 PASS Object.getOwnPropertyDescriptor(global, 'Performance').hasOwnProperty('set') is false 889 PASS Object.getOwnPropertyDescriptor(global, 'Performance').enumerable is false 890 PASS Object.getOwnPropertyDescriptor(global, 'Performance').configurable is true 891 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceNavigation').value is PerformanceNavigation 892 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceNavigation').hasOwnProperty('get') is false 893 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceNavigation').hasOwnProperty('set') is false 894 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceNavigation').enumerable is false 895 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceNavigation').configurable is true 896 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').value is PerformanceTiming 897 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('get') is false 898 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').hasOwnProperty('set') is false 899 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').enumerable is false 900 PASS Object.getOwnPropertyDescriptor(global, 'PerformanceTiming').configurable is true 871 901 PASS Object.getOwnPropertyDescriptor(global, 'Plugin').value is Plugin 872 902 PASS Object.getOwnPropertyDescriptor(global, 'Plugin').hasOwnProperty('get') is false … … 1634 1664 PASS Object.getOwnPropertyDescriptor(global, 'SVGZoomEvent').enumerable is false 1635 1665 PASS Object.getOwnPropertyDescriptor(global, 'SVGZoomEvent').configurable is true 1666 PASS Object.getOwnPropertyDescriptor(global, 'Screen').value is Screen 1667 PASS Object.getOwnPropertyDescriptor(global, 'Screen').hasOwnProperty('get') is false 1668 PASS Object.getOwnPropertyDescriptor(global, 'Screen').hasOwnProperty('set') is false 1669 PASS Object.getOwnPropertyDescriptor(global, 'Screen').enumerable is false 1670 PASS Object.getOwnPropertyDescriptor(global, 'Screen').configurable is true 1636 1671 PASS Object.getOwnPropertyDescriptor(global, 'Selection').value is Selection 1637 1672 PASS Object.getOwnPropertyDescriptor(global, 'Selection').hasOwnProperty('get') is false -
trunk/Source/WebCore/ChangeLog
r149844 r149845 1 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com> 2 3 [NoInterfaceObject] extended attribute should be removed for several interfaces 4 https://bugs.webkit.org/show_bug.cgi?id=115852 5 6 Reviewed by Benjamin Poulain. 7 8 Remove [NoInterfaceObject] extended attribute from the following Web IDL 9 interfaces: SecurityPolicy, History, Location, Navigator, Performance, 10 PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation, 11 PerformanceResourceTiming, PerformanceTiming and Screen. 12 13 These interfaces should not have the [NoInterfaceObject] extended attribute 14 according to their respective specifications: 15 - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface 16 - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface 17 - https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy 18 - http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object 19 - http://www.w3.org/TR/navigation-timing/#performance 20 - https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface 21 - http://www.w3.org/TR/navigation-timing/#performancenavigation 22 - http://www.w3.org/TR/navigation-timing/#performancetiming 23 - http://www.w3.org/TR/user-timing/#performancemark 24 - http://www.w3.org/TR/user-timing/#performancemeasure 25 - http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming 26 - http://dev.w3.org/csswg/cssom-view/#the-screen-interface 27 28 The new behavior is consistent with the specifications, Firefox and soon Blink. 29 30 No new tests, already covered by existing tests. 31 32 * page/DOMSecurityPolicy.idl: 33 * page/History.idl: 34 * page/Location.idl: 35 * page/Navigator.idl: 36 * page/Performance.idl: 37 * page/PerformanceEntry.idl: 38 * page/PerformanceMark.idl: 39 * page/PerformanceMeasure.idl: 40 * page/PerformanceNavigation.idl: 41 * page/PerformanceResourceTiming.idl: 42 * page/PerformanceTiming.idl: 43 * page/Screen.idl: 44 1 45 2013-05-09 Robert Hogan <robert@webkit.org> 2 46 -
trunk/Source/WebCore/page/DOMSecurityPolicy.idl
r149796 r149845 24 24 25 25 [ 26 NoInterfaceObject,27 26 Conditional=CSP_NEXT, 28 OmitConstructor,29 27 InterfaceName=SecurityPolicy 30 28 ] interface DOMSecurityPolicy { -
trunk/Source/WebCore/page/History.idl
r149796 r149845 25 25 26 26 [ 27 NoInterfaceObject,28 27 JSCustomGetOwnPropertySlotAndDescriptor, 29 28 CustomNamedSetter, … … 31 30 CustomDeleteProperty, 32 31 CustomEnumerateProperty, 33 OmitConstructor34 32 ] interface History { 35 33 readonly attribute unsigned long length; -
trunk/Source/WebCore/page/Location.idl
r149796 r149845 28 28 29 29 [ 30 NoInterfaceObject,31 30 JSCustomGetOwnPropertySlotAndDescriptor, 32 31 CustomNamedSetter, … … 37 36 JSCustomNamedGetterOnPrototype, 38 37 JSCustomDefineOwnPropertyOnPrototype, 39 OmitConstructor40 38 ] interface Location { 41 39 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP -
trunk/Source/WebCore/page/Navigator.idl
r149796 r149845 19 19 20 20 [ 21 NoInterfaceObject,22 21 GenerateIsReachable=ImplFrame, 23 OmitConstructor24 22 ] interface Navigator { 25 23 readonly attribute DOMString appCodeName; -
trunk/Source/WebCore/page/Performance.idl
r149796 r149845 32 32 // See: http://dev.w3.org/2006/webapi/WebTiming/ 33 33 [ 34 NoInterfaceObject,35 34 Conditional=WEB_TIMING|WEB_TIMING_MINIMAL, 36 35 EventTarget, 37 OmitConstructor38 36 ] interface Performance { 39 37 #if !defined(ENABLE_WEB_TIMING_MINIMAL) -
trunk/Source/WebCore/page/PerformanceEntry.idl
r149796 r149845 31 31 // See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html 32 32 [ 33 NoInterfaceObject,34 33 Conditional=WEB_TIMING, 35 34 Conditional=PERFORMANCE_TIMELINE, 36 35 CustomToJSObject, 37 OmitConstructor38 36 ] interface PerformanceEntry { 39 37 readonly attribute DOMString name; -
trunk/Source/WebCore/page/PerformanceMark.idl
r149796 r149845 25 25 26 26 [ 27 NoInterfaceObject,28 27 Conditional=USER_TIMING, 29 OmitConstructor30 28 ] interface PerformanceMark : PerformanceEntry { 31 29 }; -
trunk/Source/WebCore/page/PerformanceMeasure.idl
r149796 r149845 25 25 26 26 [ 27 NoInterfaceObject,28 27 Conditional=USER_TIMING, 29 OmitConstructor30 28 ] interface PerformanceMeasure : PerformanceEntry { 31 29 }; -
trunk/Source/WebCore/page/PerformanceNavigation.idl
r149796 r149845 31 31 // See: http://www.w3.org/TR/navigation-timing/ 32 32 [ 33 NoInterfaceObject,34 33 Conditional=WEB_TIMING, 35 OmitConstructor36 34 ] interface PerformanceNavigation { 37 35 const unsigned short TYPE_NAVIGATE = 0; -
trunk/Source/WebCore/page/PerformanceResourceTiming.idl
r149796 r149845 31 31 // See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/ResourceTiming/Overview.html 32 32 [ 33 NoInterfaceObject,34 33 Conditional=RESOURCE_TIMING, 35 OmitConstructor36 34 ] interface PerformanceResourceTiming : PerformanceEntry { 37 35 readonly attribute DOMString initiatorType; -
trunk/Source/WebCore/page/PerformanceTiming.idl
r149796 r149845 31 31 // See: http://dev.w3.org/2006/webapi/WebTiming/ 32 32 [ 33 NoInterfaceObject,34 33 Conditional=WEB_TIMING, 35 OmitConstructor36 34 ] interface PerformanceTiming { 37 35 readonly attribute unsigned long long navigationStart; -
trunk/Source/WebCore/page/Screen.idl
r149796 r149845 29 29 30 30 [ 31 NoInterfaceObject,32 31 GenerateIsReachable=ImplFrame, 33 OmitConstructor34 32 ] interface Screen { 35 33 readonly attribute unsigned long height;
Note: See TracChangeset
for help on using the changeset viewer.