Changeset 150069 in webkit

Timestamp:

May 14, 2013 7:29:57 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Remove RenderTheme::supportsCalendarPicker
​https://bugs.webkit.org/show_bug.cgi?id=116068

Patch by Daker Fernandes Pinheiro <​daker.pinheiro@openbossa.org> on 2013-05-14
Reviewed by Benjamin Poulain.

No new tests needed because it doesn't affect behaviour.

This method was never overrided by any platform
and always leaded to the same behaviour.
The code which depended on it was also removed.

• html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):

• html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):

• page/ChromeClient.h:

(ChromeClient):

• rendering/RenderTheme.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/BaseMultipleFieldsDateAndTimeInputType.cpp (modified) (2 diffs)
• html/BaseMultipleFieldsDateAndTimeInputType.h (modified) (1 diff)
• page/ChromeClient.h (modified) (1 diff)
• rendering/RenderTheme.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-14  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
+
+        Remove RenderTheme::supportsCalendarPicker
+        https://bugs.webkit.org/show_bug.cgi?id=116068
+
+        Reviewed by Benjamin Poulain.
+
+        No new tests needed because it doesn't affect behaviour.
+
+        This method was never overrided by any platform
+        and always leaded to the same behaviour.
+        The code which depended on it was also removed.
+
+        * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+        (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
+        (WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
+        * html/BaseMultipleFieldsDateAndTimeInputType.h:
+        (BaseMultipleFieldsDateAndTimeInputType):
+        * page/ChromeClient.h:
+        (ChromeClient):
+        * rendering/RenderTheme.h:
+
 2013-04-30  Balazs Kelemen  <b.kelemen@sisa.samsung.com>
 

trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -312 +312 @@
         shouldAddPickerIndicator = true;
 #endif
-    RefPtr<RenderTheme> theme = document->page() ? document->page()->theme() : RenderTheme::defaultTheme();
-    if (theme->supportsCalendarPicker(formControlType())) {
-        shouldAddPickerIndicator = true;
-        m_pickerIndicatorIsAlwaysVisible = true;
-    }
     if (shouldAddPickerIndicator) {
         RefPtr<PickerIndicatorElement> pickerElement = PickerIndicatorElement::create(document, *this);
@@ -512 +507 @@
 void BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility()
 {
-    if (m_pickerIndicatorIsAlwaysVisible) {
-        showPickerIndicator();
-        return;
-    }
 #if ENABLE(DATALIST_ELEMENT)
     if (HTMLDataListElement* dataList = element()->dataList()) {

trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h

@@ -122 +122 @@
     PickerIndicatorElement* m_pickerIndicatorElement;
     bool m_pickerIndicatorIsVisible;
-    bool m_pickerIndicatorIsAlwaysVisible;
 };
 

trunk/Source/WebCore/page/ChromeClient.h

@@ -229 +229 @@
     // This function is used for:
     //  - Mandatory date/time choosers if !ENABLE(INPUT_MULTIPLE_FIELDS_UI)
-    //  - Date/time choosers for types for which RenderTheme::supportsCalendarPicker
-    //    returns true, if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
     //  - <datalist> UI for date/time input types regardless of
     //    ENABLE(INPUT_MULTIPLE_FIELDS_UI)

trunk/Source/WebCore/rendering/RenderTheme.h

@@ -136 +136 @@
     // A method asking if the platform is able to show datalist suggestions for a given input type.
     virtual bool supportsDataListUI(const AtomicString&) const { return false; }
-
-#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
-    // A method asking if the platform is able to show a calendar picker for a given input type.
-    virtual bool supportsCalendarPicker(const AtomicString&) const { return false; }
-#endif
 
     // Text selection colors.