Changeset 150213 in webkit

Timestamp:

May 16, 2013 4:57:46 PM (11 years ago)

Author:

Simon Fraser

Message:

Source/WebCore: Content disappears when scrolling ​http://www.childrenscancer.org/zach/
​https://bugs.webkit.org/show_bug.cgi?id=116206

Reviewed by Darin Adler.

When a RenderLayerBacking gains or loses a foregroundLayer or backgroundLayer,
we need to repaint the primary layer, since what paints into that primary
layer will change.

On the page in question, we gained/lost a foreground layer when scrolling because
the page popped an element into position:fixed.

Test: compositing/repaint/foreground-layer-change.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateBackgroundLayer):

LayoutTests: Content disappears when scrolling ​http://www.childrenscancer.org/zach/
​https://bugs.webkit.org/show_bug.cgi?id=116206

Reviewed by Darin Adler.

Ref test for foreground layer removal.

• compositing/repaint/foreground-layer-change-expected.html: Added.
• compositing/repaint/foreground-layer-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/repaint/foreground-layer-change-expected.html (added)
• LayoutTests/compositing/repaint/foreground-layer-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-05-16  Simon Fraser  <simon.fraser@apple.com>
+
+        Content disappears when scrolling  http://www.childrenscancer.org/zach/
+        https://bugs.webkit.org/show_bug.cgi?id=116206
+
+        Reviewed by Darin Adler.
+        
+        Ref test for foreground layer removal.
+
+        * compositing/repaint/foreground-layer-change-expected.html: Added.
+        * compositing/repaint/foreground-layer-change.html: Added.
+
 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-16  Simon Fraser  <simon.fraser@apple.com>
+
+        Content disappears when scrolling http://www.childrenscancer.org/zach/
+        https://bugs.webkit.org/show_bug.cgi?id=116206
+
+        Reviewed by Darin Adler.
+        
+        When a RenderLayerBacking gains or loses a foregroundLayer or backgroundLayer,
+        we need to repaint the primary layer, since what paints into that primary
+        layer will change.
+        
+        On the page in question, we gained/lost a foreground layer when scrolling because
+        the page popped an element into position:fixed.
+
+        Test: compositing/repaint/foreground-layer-change.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateForegroundLayer):
+        (WebCore::RenderLayerBacking::updateBackgroundLayer):
+
 2013-05-16  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1166 +1166 @@
     }
 
-    if (layerChanged)
+    if (layerChanged) {
+        m_graphicsLayer->setNeedsDisplay();
         m_graphicsLayer->setPaintingPhase(paintingPhaseForPrimaryLayer());
+    }
 
     return layerChanged;
@@ -1215 +1217 @@
     
     if (layerChanged) {
+        m_graphicsLayer->setNeedsDisplay();
         // This assumes that the background layer is only used for fixed backgrounds, which is currently a correct assumption.
         if (renderer()->view())