Changeset 150372 in webkit

Timestamp:

May 20, 2013, 10:21:02 AM (12 years ago)

Author:

eric.carlson@apple.com

Message:

[iOS] media/event-queue-crash.html ASSERTs in notifyChildInserted
​https://bugs.webkit.org/show_bug.cgi?id=116444

Reviewed by Jer Noble.

No new tests, covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureMediaControls): Only create media controls when the

element is in a Document.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-20  Eric Carlson  <eric.carlson@apple.com>
+
+        [iOS] media/event-queue-crash.html ASSERTs in notifyChildInserted
+        https://bugs.webkit.org/show_bug.cgi?id=116444
+
+        Reviewed by Jer Noble.
+
+        No new tests, covered by existing tests.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::configureMediaControls): Only create media controls when the
+            element is in a Document.
+
 2013-05-20  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -4618 +4618 @@
     mediaControls()->show();
 #else
-    if (!hasMediaControls())
-        createMediaControls();
-
     if (m_player)
         m_player->setControls(controls());
+
+    if (!hasMediaControls() && inDocument())
+        createMediaControls();
 #endif
 }