Changeset 150449 in webkit


Ignore:
Timestamp:
May 21, 2013 9:44:01 AM (11 years ago)
Author:
mark.lam@apple.com
Message:

Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.

Reviewed by Geoffrey Garen.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchAdd32):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r150401 r150449  
     12013-05-21  Mark Lam  <mark.lam@apple.com>
     2
     3        Added missing assert condition for PositiveOrZero in ARM branch32().
     4        https://bugs.webkit.org/show_bug.cgi?id=116538.
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * assembler/MacroAssemblerARM.h:
     9        (JSC::MacroAssemblerARM::branchAdd32):
     10
    1112013-05-20  Mark Hahnenberg  <mhahnenberg@apple.com>
    212
  • trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

    r149152 r150449  
    688688    Jump branchAdd32(ResultCondition cond, RegisterID src, RegisterID dest)
    689689    {
    690         ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
     690        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
     691            || (cond == NonZero) || (cond == PositiveOrZero));
    691692        add32(src, dest);
    692693        return Jump(m_assembler.jmp(ARMCondition(cond)));
     
    695696    Jump branchAdd32(ResultCondition cond, RegisterID op1, RegisterID op2, RegisterID dest)
    696697    {
    697         ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
     698        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
     699            || (cond == NonZero) || (cond == PositiveOrZero));
    698700        add32(op1, op2, dest);
    699701        return Jump(m_assembler.jmp(ARMCondition(cond)));
     
    702704    Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, RegisterID dest)
    703705    {
    704         ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
     706        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
     707            || (cond == NonZero) || (cond == PositiveOrZero));
    705708        add32(imm, dest);
    706709        return Jump(m_assembler.jmp(ARMCondition(cond)));
     
    709712    Jump branchAdd32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
    710713    {
    711         ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
     714        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
     715            || (cond == NonZero) || (cond == PositiveOrZero));
    712716        add32(src, imm, dest);
    713717        return Jump(m_assembler.jmp(ARMCondition(cond)));
     
    716720    Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, AbsoluteAddress dest)
    717721    {
    718         ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
     722        ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero)
     723            || (cond == NonZero) || (cond == PositiveOrZero));
    719724        add32(imm, dest);
    720725        return Jump(m_assembler.jmp(ARMCondition(cond)));
Note: See TracChangeset for help on using the changeset viewer.