Changeset 150629 in webkit

Timestamp:

May 23, 2013 11:26:26 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
​https://bugs.webkit.org/show_bug.cgi?id=115245

Patch by Xiaobo Wang <​xiaobwang@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.

PR 330917.
Internally reviewed by Arvid Nilsson.

1. Suspend/resumeRootLayerCommit when notified app activation state

change.

2. Schedule root layer commit in resumeRootLayerCommit() to explicitly

start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -5025 +5025 @@
     m_activationState = activationState;
 
+#if USE(ACCELERATED_COMPOSITING)
+    if (activationState == ActivationActive)
+        resumeRootLayerCommit();
+    else
+        suspendRootLayerCommit();
+#endif
+
 #if ENABLE(PAGE_VISIBILITY_API)
     setPageVisibilityState();
@@ -5674 +5681 @@
     m_suspendRootLayerCommit = false;
     m_needsCommit = true;
+    // PR 330917, explicitly start root layer commit timer, so that there's a commit
+    // even if BackingStore got disabled/removed.
+    scheduleRootLayerCommit();
 }
 

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-05-23  Xiaobo Wang  <xiaobwang@blackberry.com>
+
+        [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
+        https://bugs.webkit.org/show_bug.cgi?id=115245
+
+        Reviewed by Rob Buis.
+
+        PR 330917.
+        Internally reviewed by Arvid Nilsson.
+
+        1. Suspend/resumeRootLayerCommit when notified app activation state
+        change.
+        2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
+        start root layer commit timer, so that there's a commit even if
+        BackingStore got disabled/removed.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
+        (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
+
 2013-05-23  Andy Chen  <andchen@blackberry.com>