Changeset 150666 in webkit

Timestamp:

May 24, 2013, 4:37:12 PM (13 years ago)

Author:

timothy_horton@apple.com

Message:

Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
​https://bugs.webkit.org/show_bug.cgi?id=116744
<rdar://problem/13973514>

Reviewed by Simon Fraser.

• WebCore.exp.in: Export FrameView::resumeAnimatingImages.
• page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
(WebCore::FrameView::resumeAnimatingImages):
Factor the code to restart animated images out of frameView::setIsInWindow.

• page/FrameView.h:

(FrameView):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
Force WebCore to repaint animated images when painting is resumed.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (1 diff)
• WebCore/page/FrameView.cpp (modified) (1 diff)
• WebCore/page/FrameView.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-24  Tim Horton  <timothy_horton@apple.com>
+
+        Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
+        https://bugs.webkit.org/show_bug.cgi?id=116744
+        <rdar://problem/13973514>
+
+        Reviewed by Simon Fraser.
+
+        * WebCore.exp.in: Export FrameView::resumeAnimatingImages.
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setIsInWindow):
+        (WebCore::FrameView::resumeAnimatingImages):
+        Factor the code to restart animated images out of frameView::setIsInWindow.
+
+        * page/FrameView.h:
+        (FrameView):
+
 2013-05-24  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -1154 +1154 @@
 __ZN7WebCore9FrameView20resetTrackedRepaintsEv
 __ZN7WebCore9FrameView21flushDeferredRepaintsEv
+__ZN7WebCore9FrameView21resumeAnimatingImagesEv
 __ZN7WebCore9FrameView22setBaseBackgroundColorERKNS_5ColorE
 __ZN7WebCore9FrameView23updateCanHaveScrollbarsEv

trunk/Source/WebCore/page/FrameView.cpp

@@ -1070 +1070 @@
         renderView->setIsInWindow(isInWindow);
 
-    if (isInWindow) {
-        // Drawing models which cache painted content while out-of-window (WebKit2's composited drawing areas, etc.)
-        // require that we repaint animated images to kickstart the animation loop.
-
-        CachedImage::resumeAnimatingImagesForLoader(frame()->document()->cachedResourceLoader());
-    }
+    if (isInWindow)
+        resumeAnimatingImages();
+}
+
+void FrameView::resumeAnimatingImages()
+{
+    // Drawing models which cache painted content while out-of-window (WebKit2's composited drawing areas, etc.)
+    // require that we repaint animated images to kickstart the animation loop.
+
+    CachedImage::resumeAnimatingImagesForLoader(frame()->document()->cachedResourceLoader());
 }
 

trunk/Source/WebCore/page/FrameView.h

@@ -431 +431 @@
     void setVisualUpdatesAllowedByClient(bool);
 
+    void resumeAnimatingImages();
+
 protected:
     virtual bool scrollContentsFastPath(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect);

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-05-24  Tim Horton  <timothy_horton@apple.com>
+
+        Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
+        https://bugs.webkit.org/show_bug.cgi?id=116744
+        <rdar://problem/13973514>
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+        (WebKit::TiledCoreAnimationDrawingArea::resumePainting):
+        Force WebCore to repaint animated images when painting is resumed.
+
 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm

@@ -386 +386 @@
     [[NSNotificationCenter defaultCenter] postNotificationName:@"NSCAViewRenderDidResumeNotification" object:nil userInfo:[NSDictionary dictionaryWithObject:m_rootLayer.get() forKey:@"layer"]];
 
-    if (m_webPage->windowIsVisible())
+    if (m_webPage->windowIsVisible()) {
         m_webPage->corePage()->resumeScriptedAnimations();
+
+        Frame* frame = m_webPage->corePage()->mainFrame();
+        if (!frame)
+            return;
+
+        FrameView* frameView = frame->view();
+        if (!frameView)
+            return;
+
+        frameView->resumeAnimatingImages();
+    }
 }