Changeset 150699 in webkit

Timestamp:

May 25, 2013 7:27:32 PM (11 years ago)

Author:

akling@apple.com

Message:

Remove Document::getFocusableNodes().
<​http://webkit.org/b/116773>

Reviewed by Joseph Pecoraro.

Source/WebCore:

This was added in r42191 and there are no remaining clients of the API.

• dom/Document.cpp:
• dom/Document.h:
• WebCore.exp.in:

Source/WebKit/mac:

Remove the private _focusableNodes API on DOMDocument, it has no clients.

• DOM/WebDOMOperations.mm:
• DOM/WebDOMOperationsPrivate.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (1 diff)
• WebCore/dom/Document.cpp (modified) (1 diff)
• WebCore/dom/Document.h (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/DOM/WebDOMOperations.mm (modified) (1 diff)
• WebKit/mac/DOM/WebDOMOperationsPrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-25  Andreas Kling  <akling@apple.com>
+
+        Remove Document::getFocusableNodes().
+        <http://webkit.org/b/116773>
+
+        Reviewed by Joseph Pecoraro.
+
+        This was added in r42191 and there are no remaining clients of the API.
+
+        * dom/Document.cpp:
+        * dom/Document.h:
+        * WebCore.exp.in:
+
 2013-05-25  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -1052 +1052 @@
 __ZN7WebCore8Document16isPageBoxVisibleEi
 __ZN7WebCore8Document16shortcutIconURLsEv
-__ZN7WebCore8Document17getFocusableNodesERN3WTF6VectorINS1_6RefPtrINS_4NodeEEELm0ENS1_15CrashOnOverflowEEE
 __ZN7WebCore8Document20styleResolverChangedENS_23StyleResolverUpdateFlagE
 __ZN7WebCore8Document22createDocumentFragmentEv

trunk/Source/WebCore/dom/Document.cpp

@@ -3460 +3460 @@
     return !focusChangeBlocked;
 }
-    
-void Document::getFocusableNodes(Vector<RefPtr<Node> >& nodes)
-{
-    updateLayout();
-
-    for (Node* node = firstChild(); node; node = NodeTraversal::next(node)) {
-        if (node->isFocusable())
-            nodes.append(node);
-    }
-}
-  
+
 void Document::setCSSTarget(Element* n)
 {

trunk/Source/WebCore/dom/Document.h

@@ -676 +676 @@
     const UserActionElementSet& userActionElements() const { return m_userActionElements; }
 
-    void getFocusableNodes(Vector<RefPtr<Node> >&);
-    
     // The m_ignoreAutofocus flag specifies whether or not the document has been changed by the user enough 
     // for WebCore to ignore the autofocus attribute on any form controls

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2013-05-25  Andreas Kling  <akling@apple.com>
+
+        Remove Document::getFocusableNodes().
+        <http://webkit.org/b/116773>
+
+        Reviewed by Joseph Pecoraro.
+
+        Remove the private _focusableNodes API on DOMDocument, it has no clients.
+
+        * DOM/WebDOMOperations.mm:
+        * DOM/WebDOMOperationsPrivate.h:
+
 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm

@@ -184 +184 @@
 @end
 
-@implementation DOMDocument (WebDOMDocumentOperationsPrivate)
-
-- (NSArray *)_focusableNodes
-{
-    Vector<RefPtr<Node> > nodes;
-    core(self)->getFocusableNodes(nodes);
-    NSMutableArray *array = [NSMutableArray arrayWithCapacity:nodes.size()];
-    for (unsigned i = 0; i < nodes.size(); ++i)
-        [array addObject:kit(nodes[i].get())];
-    return array;
-}
-
-@end
-
 @implementation DOMRange (WebDOMRangeOperations)
 

trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h

@@ -34 +34 @@
 @end
 
-@interface DOMDocument (WebDOMDocumentOperationsPrivate)
-- (NSArray *)_focusableNodes;
-@end
-
 @interface DOMHTMLInputElement (WebDOMHTMLInputElementOperationsPrivate)
 - (void)_setAutofilled:(BOOL)autofilled;