Changeset 150775 in webkit

Timestamp:

May 27, 2013 1:07:40 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

drop-shadow filter with overflow:hidden child misbehaves.
​https://bugs.webkit.org/show_bug.cgi?id=109783

Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-27
Reviewed by Simon Fraser.

Applying CSS filters only to the scrollbar rect leaves rendering
artefacts. Filters should skip such partial repaints.

Tests: Test framework uses mock theme for scrollbars. Such scrollbars do not
initiate partial repaints.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):

• rendering/RenderLayer.h:

(RenderLayer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (2 diffs)
• rendering/RenderLayer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-27  Zalan Bujtas  <zalan@apple.com>
+
+        drop-shadow filter with overflow:hidden child misbehaves.
+        https://bugs.webkit.org/show_bug.cgi?id=109783
+
+        Reviewed by Simon Fraser.
+
+        Applying CSS filters only to the scrollbar rect leaves rendering
+        artefacts. Filters should skip such partial repaints.
+
+        Tests: Test framework uses mock theme for scrollbars. Such scrollbars do not
+        initiate partial repaints.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::setupFilters):
+        (WebCore::RenderLayer::paintLayerContents):
+        * rendering/RenderLayer.h:
+        (RenderLayer):
+
 2013-05-27  Xueqing Huang  <huangxueqing@baidu.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -3771 +3771 @@
 
 #if ENABLE(CSS_FILTERS)
-PassOwnPtr<FilterEffectRendererHelper> RenderLayer::setupFilters(GraphicsContext* context, LayerPaintingInfo& paintingInfo, const LayoutPoint& offsetFromRoot, IntRect& rootRelativeBounds, bool& rootRelativeBoundsComputed)
+PassOwnPtr<FilterEffectRendererHelper> RenderLayer::setupFilters(GraphicsContext* context, LayerPaintingInfo& paintingInfo, PaintLayerFlags paintFlags, const LayoutPoint& offsetFromRoot, IntRect& rootRelativeBounds, bool& rootRelativeBoundsComputed)
 {
     if (context->paintingDisabled())
+        return nullptr;
+
+    if (paintFlags & PaintLayerPaintingOverlayScrollbars)
         return nullptr;
 
@@ -3874 +3877 @@
     GraphicsContext* transparencyLayerContext = context;
 #if ENABLE(CSS_FILTERS)
-    OwnPtr<FilterEffectRendererHelper> filterPainter = setupFilters(context, localPaintingInfo, offsetFromRoot, rootRelativeBounds, rootRelativeBoundsComputed);
+    OwnPtr<FilterEffectRendererHelper> filterPainter = setupFilters(context, localPaintingInfo, paintFlags, offsetFromRoot, rootRelativeBounds, rootRelativeBoundsComputed);
     if (filterPainter) {
         context = filterPainter->filterContext();

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -943 +943 @@
     bool setupClipPath(GraphicsContext*, const LayerPaintingInfo&, const LayoutPoint& offsetFromRoot, IntRect& rootRelativeBounds, bool& rootRelativeBoundsComputed);
 #if ENABLE(CSS_FILTERS)
-    PassOwnPtr<FilterEffectRendererHelper> setupFilters(GraphicsContext*, LayerPaintingInfo&, const LayoutPoint& offsetFromRoot, IntRect& rootRelativeBounds, bool& rootRelativeBoundsComputed);
+    PassOwnPtr<FilterEffectRendererHelper> setupFilters(GraphicsContext*, LayerPaintingInfo&, PaintLayerFlags, const LayoutPoint& offsetFromRoot, IntRect& rootRelativeBounds, bool& rootRelativeBoundsComputed);
     GraphicsContext* applyFilters(FilterEffectRendererHelper*, GraphicsContext* originalContext, LayerPaintingInfo&, LayerFragments&);
 #endif