Changeset 150779 in webkit

Timestamp:

May 27, 2013 2:59:52 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Clear supression flag when caret changes aren't propogated through
​https://bugs.webkit.org/show_bug.cgi?id=116840

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-27
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR339965
We set and clear the flag upon every use. This leaves us vulnerable if

1. midway through processing the selection change event is dismissed and
2. we don't receive a TouchRelease event

One example of this is while dragging the FCC handle we start typing. To
safeguard against this, if the process change guard is set during a
selection change event, we send out to clear the flag status before returning.

• Api/WebPageClient.h:
• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::selectionChanged):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPageClient.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• WebKitSupport/InputHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPageClient.h

@@ -277 +277 @@
     virtual void startSelectionScroll() = 0;
     virtual void stopExpandingSelection() = 0;
+    virtual void suppressCaretChangeNotification(bool shouldClearState) = 0;
 };
 } // namespace WebKit

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-05-27  Nima Ghanavatian  <nghanavatian@blackberry.com>
+
+        [BlackBerry] Clear supression flag when caret changes aren't propogated through
+        https://bugs.webkit.org/show_bug.cgi?id=116840
+
+        Reviewed by Rob Buis.
+
+        Internally reviewed by Mike Fenton.
+
+        PR339965
+        We set and clear the flag upon every use. This leaves us vulnerable if
+        1. midway through processing the selection change event is dismissed and
+        2. we don't receive a TouchRelease event
+        One example of this is while dragging the FCC handle we start typing. To
+        safeguard against this, if the process change guard is set during a
+        selection change event, we send out to clear the flag status before returning.
+
+        * Api/WebPageClient.h:
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::selectionChanged):
+
 2013-05-27  Andy Chen  <andchen@blackberry.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

@@ -1704 +1704 @@
         return;
 
-    if (processingChange())
-        return;
+    if (processingChange()) {
+        m_webPage->m_client->suppressCaretChangeNotification(true /*shouldClearState*/);
+        return;
+    }
 
     // Scroll the field if necessary. This must be done even if we are processing