Changeset 150805 in webkit


Ignore:
Timestamp:
May 28, 2013 7:41:11 AM (11 years ago)
Author:
akling@apple.com
Message:

Move Node::dispatchChangeEvent() to HTMLFormControlElement.
<​http://webkit.org/b/116866>

Reviewed by Anders Carlsson.

...and devirtualize it, since it had no overrides.

  • dom/Node.h:
  • dom/Node.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):

Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r150804 r150805  
     12013-05-28  Andreas Kling  <akling@apple.com>
     2
     3        Move Node::dispatchChangeEvent() to HTMLFormControlElement.
     4        <http://webkit.org/b/116866>
     5
     6        Reviewed by Anders Carlsson.
     7
     8        ...and devirtualize it, since it had no overrides.
     9
     10        * dom/Node.h:
     11        * dom/Node.cpp:
     12        * html/HTMLFormControlElement.h:
     13        * html/HTMLFormControlElement.cpp:
     14        (WebCore::HTMLFormControlElement::dispatchChangeEvent):
     15        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
     16        * html/FileInputType.cpp:
     17        (WebCore::FileInputType::setFiles):
     18        * html/HTMLTextFormControlElement.cpp:
     19        (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
     20
    1212013-05-28  Sergio Villar Senin  <svillar@igalia.com>
    222

  • trunk/Source/WebCore/dom/Node.cpp

    r150801 r150805  
    23512351}
    23522352
    2353 void Node::dispatchChangeEvent()
    2354 {
    2355     dispatchScopedEvent(Event::create(eventNames().changeEvent, true, false));
    2356 }
    2357 
    23582353void Node::dispatchInputEvent()
    23592354{

  • trunk/Source/WebCore/dom/Node.h

    r150801 r150805  
    616616    bool dispatchBeforeLoadEvent(const String& sourceURL);
    617617
    618     virtual void dispatchChangeEvent();
    619618    virtual void dispatchInputEvent();
    620619

  • trunk/Source/WebCore/html/FileInputType.cpp

    r150177 r150805  
    395395        // This call may cause destruction of this instance.
    396396        // input instance is safe since it is ref-counted.
    397         input->HTMLElement::dispatchChangeEvent();
     397        input->dispatchChangeEvent();
    398398    }
    399399    input->setChangedSinceLastFormControlChangeEvent(false);

  • trunk/Source/WebCore/html/HTMLFormControlElement.cpp

    r150801 r150805  
    258258}
    259259
     260void HTMLFormControlElement::dispatchChangeEvent()
     261{
     262    dispatchScopedEvent(Event::create(eventNames().changeEvent, true, false));
     263}
     264
    260265void HTMLFormControlElement::dispatchFormControlChangeEvent()
    261266{
    262     HTMLElement::dispatchChangeEvent();
     267    dispatchChangeEvent();
    263268    setChangedSinceLastFormControlChangeEvent(false);
    264269}

  • trunk/Source/WebCore/html/HTMLFormControlElement.h

    r150801 r150805  
    6363
    6464    virtual void dispatchFormControlChangeEvent();
     65    void dispatchChangeEvent();
    6566    void dispatchFormControlInputEvent();
    6667

  • trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp

    r150801 r150805  
    226226{
    227227    if (m_textAsOfLastFormControlChangeEvent != value()) {
    228         HTMLElement::dispatchChangeEvent();
     228        dispatchChangeEvent();
    229229        setTextAsOfLastFormControlChangeEvent(value());
    230230    }
Note: See TracChangeset for help on using the changeset viewer.