Changeset 15093 in webkit

Timestamp:

Jun 29, 2006, 11:18:42 AM (19 years ago)

Author:

thatcher

Message:

Reviewed by Harrison.

Smart insert and delete, continuous spell checking and autoscroll
can now be used for any WebView, not just editable ones. All of
these make sense for documents that might contain content editable
areas or our new text fields. Autoscroll is usefull for dragging
for file input controls also.

Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
WebHTMLView's _interceptEditingKeyEvent now uses WebView's
tabKeyCyclesThroughElements state to determine whether or not
to process tab key events. The idea here is that tabKeyCyclesThroughElements
will be YES when this WebView is being used in a browser, and we
desire the behavior where tab moves to the next element in tab order.
If tabKeyCyclesThroughElements is NO, it is likely that the WebView
is being embedded as the whole view, as in Mail, and tabs should input
tabs as expected in a text editor. Using Option-Tab always cycles
through elements.

• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
• WebView/WebHTMLView.m: (-[NSArray _interceptEditingKeyEvent:]):
• WebView/WebView.m: (-[WebViewPrivate init]): (-[WebView _autoscrollForDraggingInfo:timeDelta:]): (-[WebView _shouldAutoscrollForDraggingInfo:]): (-[WebView validateUserInterfaceItem:]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]):
• WebView/WebViewPrivate.h:

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebKit.xcodeproj/project.pbxproj (modified) (2 diffs)
• WebView/WebHTMLRepresentation.m (modified) (1 diff)
• WebView/WebHTMLView.m (modified) (1 diff)
• WebView/WebView.m (modified) (7 diffs)
• WebView/WebViewPrivate.h (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2006-06-29  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Harrison.
+
+        Smart insert and delete, continuous spell checking and autoscroll
+        can now be used for any WebView, not just editable ones. All of
+        these make sense for documents that might contain content editable 
+        areas or our new text fields. Autoscroll is usefull for dragging
+        for file input controls also.
+
+        Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
+        WebHTMLView's _interceptEditingKeyEvent now uses WebView's
+        tabKeyCyclesThroughElements state to determine whether or not
+        to process tab key events. The idea here is that tabKeyCyclesThroughElements
+        will be YES when this WebView is being used in a browser, and we
+        desire the behavior where tab moves to the next element in tab order.
+        If tabKeyCyclesThroughElements is NO, it is likely that the WebView
+        is being embedded as the whole view, as in Mail, and tabs should input
+        tabs as expected in a text editor. Using Option-Tab always cycles
+        through elements.
+
+        * WebView/WebHTMLRepresentation.m:
+        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
+        * WebView/WebHTMLView.m:
+        (-[NSArray _interceptEditingKeyEvent:]):
+        * WebView/WebView.m:
+        (-[WebViewPrivate init]):
+        (-[WebView _autoscrollForDraggingInfo:timeDelta:]):
+        (-[WebView _shouldAutoscrollForDraggingInfo:]):
+        (-[WebView validateUserInterfaceItem:]):
+        (-[WebView toggleSmartInsertDelete:]):
+        (-[WebView toggleContinuousSpellChecking:]):
+        (-[WebView setTabKeyCyclesThroughElements:]):
+        (-[WebView tabKeyCyclesThroughElements]):
+        * WebView/WebViewPrivate.h:
+
 2006-06-29  Anders Carlsson  <acarlsson@apple.com>
 

trunk/WebKit/WebKit.xcodeproj/project.pbxproj

@@ -279 +279 @@
 /* End PBXBuildFile section */
 
-/* Begin PBXBuildStyle section */
-                BCEED1470A53334500443D9A /* Development */ = {
-                        isa = PBXBuildStyle;
-                        buildSettings = {
-                                COPY_PHASE_STRIP = NO;
-                        };
-                        name = Development;
-                };
-                BCEED1480A53334500443D9A /* Deployment */ = {
-                        isa = PBXBuildStyle;
-                        buildSettings = {
-                                COPY_PHASE_STRIP = YES;
-                        };
-                        name = Deployment;
-                };
-/* End PBXBuildStyle section */
-
 /* Begin PBXFileReference section */
                 1C0706620A431E01001078F6 /* WebScriptDebugServer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebScriptDebugServer.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
@@ -1248 +1231 @@
                         isa = PBXProject;
                         buildConfigurationList = 149C283208902B0F008A9EFC /* Build configuration list for PBXProject "WebKit" */;
-                        buildSettings = {
-                        };
-                        buildStyles = (
-                                BCEED1470A53334500443D9A /* Development */,
-                                BCEED1480A53334500443D9A /* Deployment */,
-                        );
                         hasScannedForEncodings = 1;
                         knownRegions = (

trunk/WebKit/WebView/WebHTMLRepresentation.m

@@ -193 +193 @@
         
         WebView *webView = [frame webView];
-        if ([webView isEditable]) {
+        if ([webView isEditable])
             [_private->bridge applyEditingStyleToBodyElement];
-        }
     }
 }

trunk/WebKit/WebView/WebHTMLView.m

@@ -3473 +3473 @@
 - (BOOL)_interceptEditingKeyEvent:(NSEvent *)event
 {   
-    // Use the isEditable state to determine whether or not to process tab key events.
-    // The idea here is that isEditable will be NO when this WebView is being used
-    // in a browser, and we desire the behavior where tab moves to the next element
-    // in tab order. If isEditable is YES, it is likely that the WebView is being
-    // embedded as the whole view, as in Mail, and tabs should input tabs as expected
-    // in a text editor.
-    if (![[self _webView] isEditable] && [event _web_isTabKeyEvent]) 
+    // Use WebView's tabKeyCyclesThroughElements state to determine whether or not
+    // to process tab key events. The idea here is that tabKeyCyclesThroughElements
+    // will be YES when this WebView is being used in a browser, and we desire the
+    // behavior where tab moves to the next element in tab order. If tabKeyCyclesThroughElements
+    // is NO, it is likely that the WebView is being embedded as the whole view, as in Mail,
+    // and tabs should input tabs as expected in a text editor. Using Option-Tab always cycles
+    // through elements.
+
+    if ([[self _webView] tabKeyCyclesThroughElements] && [event _web_isTabKeyEvent]) 
         return NO;
-    
+
+    if (![[self _webView] tabKeyCyclesThroughElements] && [event _web_isOptionTabKeyEvent])
+        return NO;
+
     // Now process the key normally
     [self interpretKeyEvents:[NSArray arrayWithObject:event]];

trunk/WebKit/WebView/WebView.m

@@ -276 +276 @@
     BOOL editable;
     BOOL initiatedDrag;
-        
+    BOOL tabKeyCyclesThroughElements;
+
     NSString *mediaStyle;
     
@@ -375 +376 @@
     settings = [[WebCoreSettings alloc] init];
     dashboardBehaviorAllowWheelScrolling = YES;
+    tabKeyCyclesThroughElements = YES;
 
     return self;
@@ -2231 +2233 @@
 - (void)_autoscrollForDraggingInfo:(id)draggingInfo timeDelta:(NSTimeInterval)repeatDelta
 {
-    if (![self isEditable])
-        return;
-    
     NSView <WebDocumentView> *documentView = [self documentViewAtWindowPoint:[draggingInfo draggingLocation]];
     [documentView _autoscrollForDraggingInfo:draggingInfo timeDelta:repeatDelta];
@@ -2240 +2239 @@
 - (BOOL)_shouldAutoscrollForDraggingInfo:(id)draggingInfo
 {
-    if (![self isEditable])
-        return NO;
-    
     NSView <WebDocumentView> *documentView = [self documentViewAtWindowPoint:[draggingInfo draggingLocation]];
     return [documentView _shouldAutoscrollForDraggingInfo:draggingInfo];
@@ -2609 +2605 @@
         BOOL checkMark = NO;
         BOOL retVal = NO;
-        if ([self isEditable] && [self _continuousCheckingAllowed]) {
+        if ([self _continuousCheckingAllowed]) {
             checkMark = [self isContinuousSpellCheckingEnabled];
             retVal = YES;
@@ -2696 +2692 @@
 - (void)toggleSmartInsertDelete:(id)sender
 {
-    if ([self isEditable]) {
-        [self setSmartInsertDeleteEnabled:![self smartInsertDeleteEnabled]];
-    }
+    [self setSmartInsertDeleteEnabled:![self smartInsertDeleteEnabled]];
 }
 
 - (IBAction)toggleContinuousSpellChecking:(id)sender
 {
-    if ([self isEditable]) {
-        [self setContinuousSpellCheckingEnabled:![self isContinuousSpellCheckingEnabled]];
-    }
+    [self setContinuousSpellCheckingEnabled:![self isContinuousSpellCheckingEnabled]];
 }
 
@@ -2746 +2738 @@
     BOOL notAlreadyStandard = _private->textSizeMultiplier != 1.0;
     [self _performTextSizingSelector:@selector(_makeTextStandardSize:) withObject:sender onTrackingDocs:notAlreadyStandard selForNonTrackingDocs:@selector(_canMakeTextStandardSize) newScaleFactor:1.0];
+}
+
+- (void)setTabKeyCyclesThroughElements:(BOOL)cyclesElements
+{
+    _private->tabKeyCyclesThroughElements = cyclesElements;
+}
+
+- (BOOL)tabKeyCyclesThroughElements
+{
+    return _private->tabKeyCyclesThroughElements;
 }
 

trunk/WebKit/WebView/WebViewPrivate.h

@@ -93 +93 @@
 - (IBAction)makeTextStandardSize:(id)sender;
 
+- (void)setTabKeyCyclesThroughElements:(BOOL)cyclesElements;
+- (BOOL)tabKeyCyclesThroughElements;
+
 // If true, the selection will be maintained even when the first responder is outside
 // of the webview. Returns true only if self is editable at this level. Subclasses can