Changeset 150930 in webkit

Timestamp:

May 29, 2013 2:28:28 PM (11 years ago)

Author:

Brent Fulgham

Message:

[Windows] Be consistent with allocation/deallocation behavior
​https://bugs.webkit.org/show_bug.cgi?id=116998

Reviewed by Anders Carlsson.

• WebPreferences.cpp:

(WebPreferences::setStringValue): Switch from using _wcsdup and
CFStringCreateWithCharactersNoCopy to just use the standard
CFStringCreateWithCharacters call.

Location:

trunk/Source/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebPreferences.cpp (modified) (1 diff)

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2013-05-29  Brent Fulgham  <bfulgham@apple.com>
+
+        [Windows] Be consistent with allocation/deallocation behavior
+        https://bugs.webkit.org/show_bug.cgi?id=116998
+
+        Reviewed by Anders Carlsson.
+
+        * WebPreferences.cpp:
+        (WebPreferences::setStringValue): Switch from using _wcsdup and
+        CFStringCreateWithCharactersNoCopy to just use the standard
+        CFStringCreateWithCharacters call.
+
 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/win/WebPreferences.cpp

@@ -355 +355 @@
         return;
     
-    RetainPtr<CFStringRef> valueRef = adoptCF(CFStringCreateWithCharactersNoCopy(0, (UniChar*)_wcsdup(value), (CFIndex)wcslen(value), kCFAllocatorMalloc));
+    RetainPtr<CFStringRef> valueRef = adoptCF(CFStringCreateWithCharacters(0, reinterpret_cast<const UniChar*>(value), static_cast<CFIndex>(wcslen(value))));
     setValueForKey(key, valueRef.get());