Changeset 151080 in webkit
- Timestamp:
- Jun 2, 2013 1:14:48 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 deleted
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r151079 r151080 1 2013-06-02 Alexey Proskuryakov <ap@apple.com> 2 3 Unstyled XML viewer crashes when XML contains an element with id="tree" 4 https://bugs.webkit.org/show_bug.cgi?id=117117 5 <rdar://problem/13727267> 6 7 Reviewed by Darin Adler. 8 9 * http/tests/xmlviewer/dumpAsText/existing-tree-element-crash-expected.txt: Added. 10 * http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml: Added. 11 12 * xmlviewer: Removed. 13 * xmlviewer/extensions-api-expected.txt: Removed. 14 * xmlviewer/extensions-api.html: Removed. 15 * xmlviewer/resources: Removed. 16 * xmlviewer/resources/sample.xml: Removed. 17 The "API" no longer exists. 18 1 19 2013-06-01 Chris Fleizach <cfleizach@apple.com> 2 20 -
trunk/Source/WebCore/ChangeLog
r151079 r151080 1 2013-06-02 Alexey Proskuryakov <ap@apple.com> 2 3 Unstyled XML viewer crashes when XML contains an element with id="tree" 4 https://bugs.webkit.org/show_bug.cgi?id=117117 5 <rdar://problem/13727267> 6 7 Reviewed by Darin Adler. 8 9 Test: http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml 10 11 * xml/XMLViewer.css: Removed the rule to hide source document, as we no longer 12 keep it in the tree. 13 14 * xml/XMLViewer.js: 15 (prepareWebKitXMLViewer): Make sourceXML a detached tree, as otherwise it can 16 have ID conflicts with elements we add. 17 (sourceXMLLoaded): Removed some commented out code. Removed code that was checking 18 whether an extension took over XML display, as it makes no sense to duplicate this 19 functionality in an extension. 20 1 21 2013-06-01 Chris Fleizach <cfleizach@apple.com> 2 22 -
trunk/Source/WebCore/xml/XMLViewer.css
r126241 r151080 44 44 } 45 45 46 #webkit-xml-viewer-source-xml {47 display: none;48 }49 50 46 .collapsible-content { 51 47 margin-left: 1em; -
trunk/Source/WebCore/xml/XMLViewer.js
r126241 r151080 1 1 /* 2 2 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 4 * 4 5 * Redistribution and use in source and binary forms, with or without … … 28 29 29 30 var nodeParentPairs = []; 31 var sourceXML; 30 32 31 33 // Script entry point. … … 41 43 var body = createHTMLElement('body'); 42 44 html.appendChild(body); 43 var sourceXML = createHTMLElement('div'); 44 sourceXML.id = 'webkit-xml-viewer-source-xml'; 45 body.appendChild(sourceXML); 45 sourceXML = createHTMLElement('div'); 46 46 47 47 var child; … … 70 70 function sourceXMLLoaded() 71 71 { 72 var sourceXML = document.getElementById('webkit-xml-viewer-source-xml');73 if (!sourceXML)74 return; // Stop if some XML tree extension is already processing this document75 //var style = document.head.firstChild;76 //document.head.removeChild(style);77 //document.head.appendChild(style);78 72 var root = document.getElementById('tree'); 79 73
Note: See TracChangeset
for help on using the changeset viewer.