Changeset 151174 in webkit

Timestamp:

Jun 4, 2013 9:59:04 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[sh4] Add floating point absolute function support in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=117147

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-06-04
Reviewed by Geoffrey Garen.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
(JSC::MacroAssemblerSH4::absDouble):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::dabs):
(JSC::SH4Assembler::printInstr):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerSH4.h (modified) (2 diffs)
• assembler/SH4Assembler.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-06-04  Julien Brianceau  <jbrianceau@nds.com>
+
+        [sh4] Add floating point absolute function support in baseline JIT.
+        https://bugs.webkit.org/show_bug.cgi?id=117147
+
+        Reviewed by Geoffrey Garen.
+
+        * assembler/MacroAssemblerSH4.h:
+        (JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
+        (JSC::MacroAssemblerSH4::absDouble):
+        * assembler/SH4Assembler.h:
+        (JSC::SH4Assembler::dabs):
+        (JSC::SH4Assembler::printInstr):
+
 2013-06-04  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h

@@ -947 +947 @@
     static bool supportsFloatingPointTruncate() { return true; }
     static bool supportsFloatingPointSqrt() { return true; }
-    static bool supportsFloatingPointAbs() { return false; }
+    static bool supportsFloatingPointAbs() { return true; }
 
     void moveDoubleToInts(FPRegisterID src, RegisterID dest1, RegisterID dest2)
@@ -1393 +1393 @@
     }
     
-    void absDouble(FPRegisterID, FPRegisterID)
-    {
-        RELEASE_ASSERT_NOT_REACHED();
+    void absDouble(FPRegisterID src, FPRegisterID dest)
+    {
+        moveDouble(src, dest);
+        m_assembler.dabs(dest);
     }
 

trunk/Source/JavaScriptCore/assembler/SH4Assembler.h

@@ -179 +179 @@
     LDSRMFPUL_OPCODE = 0x405a,
     FSTSFPULFRN_OPCODE = 0xf00d,
+    FABS_OPCODE = 0xf05d,
     FSQRT_OPCODE = 0xf06d,
     FSCHG_OPCODE = 0xf3fd,
@@ -958 +959 @@
     }
 
+    void dabs(FPRegisterID dst)
+    {
+        uint16_t opc = getOpcodeGroup7(FABS_OPCODE, dst >> 1);
+        oneShortOp(opc);
+    }
+
     void dsqrt(FPRegisterID dst)
     {
@@ -1837 +1844 @@
             format = "    FTRC FR%d, FPUL\n";
             break;
+        case FABS_OPCODE:
+            format = "    FABS FR%d\n";
+            break;
         case FSQRT_OPCODE:
             format = "    FSQRT FR%d\n";