Changeset 151240 in webkit

Timestamp:

Jun 5, 2013 2:40:19 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Make image clickable when it has anchor as parent node.
​https://bugs.webkit.org/show_bug.cgi?id=117271

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-06-05
Reviewed by Rob Buis.

BlackBerry PR 345995
Internally Reviewed by Genevieve Mak.

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/FatFingers.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-06-05  Tiancheng Jiang  <tijiang@rim.com>
+
+        [BlackBerry] Make image clickable when it has anchor as parent node.
+        https://bugs.webkit.org/show_bug.cgi?id=117271
+
+        Reviewed by Rob Buis.
+
+        BlackBerry PR 345995
+        Internally Reviewed by Genevieve Mak.
+        * WebKitSupport/FatFingers.cpp:
+        (BlackBerry::WebKit::FatFingers::isElementClickable):
+
 2013-06-05  Mike Fenton  <mifenton@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp

@@ -93 +93 @@
     if (element->webkitMatchesSelector("a[href],*:link,*:visited,*[role=button],button,input,select,label[for],area[href],textarea,embed,object", ec)
         || element->isMediaControlElement()
-        || element->isContentEditable())
+        || element->isContentEditable()
+        || (element->hasTagName(HTMLNames::imgTag) && element->parentNode() && element->parentNode()->hasTagName(HTMLNames::aTag)))
         return true;