Changeset 151344 in webkit

Timestamp:

Jun 7, 2013 5:11:34 PM (11 years ago)

Author:

andersca@apple.com

Message:

Coalesce multiple calls to WebPageProxy::windowAndViewFramesChanged
​https://bugs.webkit.org/show_bug.cgi?id=117364
<rdar://problem/14042099>

Reviewed by Geoffrey Garen.

-[WKView _updateWindowAndViewFrames] can be called many times per run loop iteration so coalesce calls
to WebPageProxy::windowAndViewFrames using dispatch_async.

• UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-06-07  Anders Carlsson  <andersca@apple.com>
+
+        Coalesce multiple calls to WebPageProxy::windowAndViewFramesChanged
+        https://bugs.webkit.org/show_bug.cgi?id=117364
+        <rdar://problem/14042099>
+
+        Reviewed by Geoffrey Garen.
+
+        -[WKView _updateWindowAndViewFrames] can be called many times per run loop iteration so coalesce calls
+        to WebPageProxy::windowAndViewFrames using dispatch_async.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView _updateWindowAndViewFrames]):
+
 2013-06-07  Thomas Deniau  <deniau@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -217 +217 @@
     BOOL _viewInWindowChangeWasDeferred;
 
+    BOOL _didScheduleWindowAndViewFrameUpdate;
+
     // Whether the containing window of the WKView has a valid backing store.
     // The window server invalidates the backing store whenever the window is resized or minimized.
@@ -456 +458 @@
 - (void)_updateWindowAndViewFrames
 {
-    NSRect viewFrameInWindowCoordinates = [self convertRect:[self frame] toView:nil];
-    NSPoint accessibilityPosition = NSMakePoint(0, 0);
-    if (WebCore::AXObjectCache::accessibilityEnabled())
-        accessibilityPosition = [[self accessibilityAttributeValue:NSAccessibilityPositionAttribute] pointValue];
-    
-    _data->_page->windowAndViewFramesChanged(viewFrameInWindowCoordinates, accessibilityPosition);
     if (_data->_clipsToVisibleRect)
         [self _updateViewExposedRect];
+
+    if (_data->_didScheduleWindowAndViewFrameUpdate)
+        return;
+
+    _data->_didScheduleWindowAndViewFrameUpdate = YES;
+
+    dispatch_async(dispatch_get_main_queue(), ^{
+        NSRect viewFrameInWindowCoordinates = [self convertRect:[self frame] toView:nil];
+        NSPoint accessibilityPosition = NSMakePoint(0, 0);
+        if (WebCore::AXObjectCache::accessibilityEnabled())
+            accessibilityPosition = [[self accessibilityAttributeValue:NSAccessibilityPositionAttribute] pointValue];
+
+        _data->_page->windowAndViewFramesChanged(viewFrameInWindowCoordinates, accessibilityPosition);
+        _data->_didScheduleWindowAndViewFrameUpdate = NO;
+    });
 }