Changeset 151348 in webkit

Timestamp:

Jun 8, 2013 2:33:40 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[curl] Allow headers with empty value
​https://bugs.webkit.org/show_bug.cgi?id=117344

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-06-08
Reviewed by Brent Fulgham.

No new tests, already covered by:
http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
http/tests/xmlhttprequest/post-blob-content-type-sync.html

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/ResourceHandleManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-08  Peter Gal  <galpeter@inf.u-szeged.hu>
+
+        [curl] Allow headers with empty value
+        https://bugs.webkit.org/show_bug.cgi?id=117344
+
+        Reviewed by Brent Fulgham.
+
+        No new tests, already covered by:
+        http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
+        http/tests/xmlhttprequest/post-blob-content-type-sync.html
+
+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::ResourceHandleManager::initializeHandle):
+
 2013-06-08  Peter Gal  <galpeter@inf.u-szeged.hu>
 

trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp

@@ -762 +762 @@
             String value = it->value;
             String headerString(key);
-            headerString.append(": ");
-            headerString.append(value);
+            if (value.isEmpty())
+                // Insert the ; to tell curl that this header has an empty value.
+                headerString.append(";");
+            else {
+                headerString.append(": ");
+                headerString.append(value);
+            }
             CString headerLatin1 = headerString.latin1();
             headers = curl_slist_append(headers, headerLatin1.data());