Changeset 151554 in webkit

Timestamp:

Jun 13, 2013 9:49:20 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Regions] Regions auto-height and absolute positioning bug
​https://bugs.webkit.org/show_bug.cgi?id=111092

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-06-13
Reviewed by David Hyatt.

During last layout that should update the auto-height regions new auto-height region height
is calculated correctly based on the text content, but it requires extra step
to reposition the render block after new logical height is set (correct logical height becomes
available only during last layout).

Tests: fast/regions/autoheight-abspos-bottom-align.html

• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::updateLogicalHeight):

Location:

trunk

Files:

• LayoutTests/fast/regions/autoheight-abspos-bottom-align-expected.txt (added)
• LayoutTests/fast/regions/autoheight-abspos-bottom-align.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderRegion.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-06-13  Anton Obzhirov  <a.obzhirov@samsung.com>
+
+        [CSS Regions] Regions auto-height and absolute positioning bug
+        https://bugs.webkit.org/show_bug.cgi?id=111092
+
+        Reviewed by David Hyatt.
+
+        During last layout that should update the auto-height regions new auto-height region height
+        is calculated correctly based on the text content, but it requires extra step 
+        to reposition the render block after new logical height is set (correct logical height becomes
+        available only during last layout). 
+
+        Tests: fast/regions/autoheight-abspos-bottom-align.html
+
+        * rendering/RenderRegion.cpp:
+        (WebCore::RenderRegion::updateLogicalHeight):
+
 2013-06-13  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebCore/rendering/RenderRegion.cpp

@@ -667 +667 @@
     LayoutUnit newLogicalHeight = overrideLogicalContentHeight() + borderAndPaddingLogicalHeight();
     ASSERT(newLogicalHeight < LayoutUnit::max() / 2);
-    if (newLogicalHeight > logicalHeight())
+    if (newLogicalHeight > logicalHeight()) {
         setLogicalHeight(newLogicalHeight);
+        // Recalculate position of the render block after new logical height is set.
+        // (needed in absolute positioning case with bottom alignment for example)
+        RenderBlock::updateLogicalHeight();
+    }
 }